search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

Quotas for Ephemeral Storage #1029

Open RobertKrawitz opened 5 years ago

RobertKrawitz commented 5 years ago

Enhancement Description

Priyankasaggu11929 commented 2 years ago

Hello @pacoxu 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to update the open PR https://github.com/kubernetes/enhancements/pull/2697 as per the pending following suggestions and get it merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

pacoxu commented 2 years ago

Thanks, @Priyankasaggu11929 The KEP update is waiting for review from sig-node. The PRR review was passed. @kubernetes/sig-node-feature-requests

Priyankasaggu11929 commented 2 years ago

Hey @pacoxu, thanks for the prompt update. The Open PR still misses updating the Test Plan Section as per required details mentioned here

Could you please update the PR with the same. Thank you so much! 🙂

pacoxu commented 2 years ago

Updated in https://github.com/kubernetes/enhancements/pull/2697/commits/45a80c49f439dd101a698cf952c5b9979b4416a4. Thanks.

Priyankasaggu11929 commented 2 years ago

With KEP PR https://github.com/kubernetes/enhancements/pull/2697 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as Tracked. Thank you so much! 🙂

sethmccombs commented 2 years ago

Hello @pacoxu! :wave:,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Priyankasaggu11929 commented 2 years ago

Hi @pacoxu 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

pacoxu commented 2 years ago

@Priyankasaggu11929 Thanks for reminding me. The PR is waiting for approval. And there is a small log improvement pr in https://github.com/kubernetes/kubernetes/pull/107490 for this feature as well.

pacoxu commented 2 years ago

The PRs were merged. I will open a website update pr later.

Priyankasaggu11929 commented 2 years ago

Thank you so much for the update, @pacoxu.

With the PRs merged, the enhancement is ready for 1.25 code freeze. The status is now marked as tracked. 🚀

pacoxu commented 2 years ago

Openshift team meet a bug with this feature after we enable it by default in https://github.com/kubernetes/kubernetes/pull/112076. And @rphillips raise a pr to revert this feature to alpha.

kikisdeliveryservice commented 2 years ago

@pacoxu Please update the enhancement as it still shows it as being beta in 1.25: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/1029-ephemeral-storage-quotas/kep.yaml

cc: @sftim

pacoxu commented 2 years ago

Wasn't it reverted to beta because of problems?

I have tried to promote it to beta in v1.25 and openshift found a regression issue on it. Currently, v1.25.1 and v1.26 will revert it to alpha. Only this feature is in beta only in v1.25.0.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pacoxu commented 1 year ago

/remove-lifecycle stale A related issue: https://github.com/kubernetes/kubernetes/issues/114506

pacoxu commented 1 year ago

If https://github.com/kubernetes/kubernetes/pull/112624 can fix the bug we meet in v1.25.0, can we re-promote this feature to beta?

pacoxu commented 1 year ago

There are some discussions about this feature in the last sig node meetings.

Why do we have this feature?: we don’t have an efficient way to track disk usage

I prefer to promote this feature if the blocking bugs(https://github.com/kubernetes/kubernetes/issues/112081) are fixed. The reason is that du in some scenarios will hang or take too much time. It happens in our customers' clusters and we want to alter it to a stable quick way for that. This is one of the solutions.

Of course, there may be some other ways.

@rphillips: user can change the project id of a directory which becomes a security problem.

This is one of the reasons that @rphillips asked for deprecating this feature as it is not promoted to beta for a long time. Should we open an issue to track this security problem?

pacoxu commented 1 year ago

https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-fsquota-ubuntu is added for this feature to enable it in tests.

SergeyKanzhelev commented 1 year ago

/milestone v1.28

adding tracking of this feature since it is being worked on

pacoxu commented 1 year ago

https://github.com/kubernetes/enhancements/pull/3821

SergeyKanzhelev commented 1 year ago

/label lead-opted-in

npolshakova commented 1 year ago

Hello @pacoxu 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

It looks like https://github.com/kubernetes/enhancements/pull/3821/files will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova commented 1 year ago

Hi @pacoxu, just checking in once more as we approach the 1.29 enhancement freeze deadline this week on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze.

It looks like when https://github.com/kubernetes/enhancements/pull/3821 merges in it will address most of the requirements. Let me know if I missed anything. Thanks!

npolshakova commented 1 year ago

With https://github.com/kubernetes/enhancements/pull/3821 merged this is now tracked for enhancement freeze for 1.29. 🚀

drewhagen commented 1 year ago

Hello @RobertKrawitz @pacoxu :wave:, v1.29 Docs Shadow here. Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

pacoxu commented 1 year ago

https://github.com/kubernetes/website/pull/43455 is open for website.

a-mccarthy commented 1 year ago

Hi @pacoxu, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

npolshakova commented 1 year ago

Hey again @pacoxu 👋 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs have been merged:

The following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

The status of this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

pacoxu commented 1 year ago

The pr needs review/approve. @rphillips @SergeyKanzhelev @derekwaynecarr PTAL

npolshakova commented 1 year ago

Hello @pacoxu 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

salehsedghpour commented 10 months ago

/remove-label lead-opted-in

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pacoxu commented 6 months ago

https://github.com/kubernetes/kubernetes/pull/112626#issuecomment-1864986501 kernel @haircommander pointed out that it's in a user namespace it can't change the projid and if not, project ID could be changed. So we want to wait for User Namespace beta before promoting this to beta.

/remove-lifecycle stale since User Namespace is beta, we can make it.

pacoxu commented 5 months ago

@haircommander After the User Namespace https://github.com/kubernetes/enhancements/issues/127 was promoted to beta in v1.30, it would be nice to promote this KEP to beta in v1.31 or v1.32.

I may have limited time this release cycle and will try to do the promotion not after the next release cycle.

haircommander commented 5 months ago

I can see if I can find someone!

kwilczynski commented 5 months ago

/cc @bitoku

kwilczynski commented 5 months ago

/cc @sohankunkerkar

sohankunkerkar commented 5 months ago

I can pick this one.

PannagaRao commented 5 months ago

I will be looking into this

haircommander commented 4 months ago

PR for beta (third try): https://github.com/kubernetes/enhancements/pull/4699

mrunalp commented 4 months ago

/milestone v1.31 /label lead-opted-in

dipesh-rawat commented 4 months ago

Hello @RobertKrawitz @pacoxu @PannagaRao 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for 1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

It looks like https://github.com/kubernetes/enhancements/pull/4699 will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat commented 4 months ago

Hello @RobertKrawitz @pacoxu @PannagaRao 👋, Enhancements team here.

Now that PR https://github.com/kubernetes/enhancements/pull/4699 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

hacktivist123 commented 4 months ago

Hello @RobertKrawitz 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

a-mccarthy commented 4 months ago

Hi @RobertKrawitz,

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Princesso commented 4 months ago

Hi @RobertKrawitz @pacoxu @PannagaRao , 1.31 Doc lead here. I noticed that this Enhancement work already has a draft PR here, however, the PR is closed. Can you re-open the PR against dev-1.31 branch in the k/website repo. This deadline for having a draft PR up is Thursday June 27, 2024 18:00 PDT.

Princesso commented 4 months ago

Hi @RobertKrawitz @pacoxu @PannagaRao, this is a gentle reminder that today is the deadline for having the doc draft PR opened against dev-1.31.

haircommander commented 4 months ago

here's the PR https://github.com/kubernetes/website/pull/46967

a-mccarthy commented 4 months ago

hi @haircommander, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

dipesh-rawat commented 4 months ago

Hey again @RobertKrawitz @pacoxu @PannagaRao 👋, 1.31 Enhancements team here,

Just checking in as we approach code freeze at at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Additionally, please let me know if there are any other PRs in k/k not listed in the descrption that we should track for this KEP, so that we can maintain accurate status.

For this KEP, we would need to do the following:

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

Edited: To include the PR related to the KEP