search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Immutable Fields API #1101

Open apelisse opened 5 years ago

apelisse commented 5 years ago

Enhancement Description

apelisse commented 5 years ago

/sig api-machinery

kacole2 commented 5 years ago

@apelisse is this going to go straight to Beta in 1.16?

/milestone v1.16 /stage beta

kacole2 commented 5 years ago

@apelisse this is a reminder that Enhancement Freeze is tomorrow and this KEP #1099 needs to be merged by EOD. If not, it will be removed from the milestone. Thanks

apelisse commented 5 years ago

Thanks for the reminder Kendrick, work is actually going-on (https://github.com/apelisse/enhancements/pull/1) and mostly driven by @sttts We'll try to mark it implementable before tomorrow!

kacole2 commented 5 years ago

@apelisse @sttts

Enhancement Freeze has passed for 1.16. The KEP at #1099 was never merged and now this is being removed from the 1.16 milestone. If this would like to be re-added, please file an exception and it will require approval from the release lead.

/milestone clear

apelisse commented 5 years ago

Thanks Kendrick, we've decided to take our time and do it well! We're planning to do it for the next release

palnabarun commented 5 years ago

Hey there @apelisse , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta in 1.17?

The current release schedule is:

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

sttts commented 5 years ago

Yes, please add it to the tracking sheet. We are on it.

palnabarun commented 5 years ago

Awesome. :tada:

Just FYI, for the enhancement to be accepted into the release:

  1. KEP PR must be merged
  2. KEP should be in an implementable state
  3. KEP should have test plans and graduation criteria.

/milestone v1.17

palnabarun commented 5 years ago

Hi @sttts @apelisse , just a friendly reminder. We are just 5 days away from the Enhancements Freeze.

I see that the KEP PR is still not merged and is in the provisional state.

For the KEP to be considered for 1.17,

  1. KEP PR must be merged
  2. KEP should be in an implementable state
  3. KEP should have test plans and graduation criteria.
palnabarun commented 4 years ago

@sttts @apelisse -- Unfortunately the deadline for the 1.17 Enhancement freeze has passed and the KEP is still not merged and in the provisional state. For now, this is being removed from the milestone and 1.17 tracking sheet. If there is a need to get this in, please file an enhancement exception.

palnabarun commented 4 years ago

/milestone clear

palnabarun commented 4 years ago

@stts @apelisse Since, the exception request filed here was accepted, I'm adding back the enhancement to the tracking sheet.

palnabarun commented 4 years ago

/milestone v1.17

palnabarun commented 4 years ago

@apelisse I see that #1099 has been succeeded by #1265. Can you please update the issue description? :)

PS: I have updated the same information in the tracking sheet.

apelisse commented 4 years ago

Done!

daminisatya commented 4 years ago

Hello, @apelisse, I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

apelisse commented 4 years ago

Yeah, we'll have to document that, I've created an empty PR: https://github.com/kubernetes/website/pull/17316

daminisatya commented 4 years ago

Thank you @apelisse

palnabarun commented 4 years ago

Hi @apelisse

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. Can you please link the PR's related to this enhancement here?

Thank you in advance :smile:

palnabarun commented 4 years ago

/cc @sttts (as per offline discussion with @apelisse)

palnabarun commented 4 years ago

/assign @sttts @apelisse

palnabarun commented 4 years ago

Hi @apelisse @sttts , tomorrow is code freeze for the 1.17 release cycle. Can you please link the k/k PR's related to this enhancement? We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

palnabarun commented 4 years ago

Hi @apelisse @stts, Code Freeze is into effect now. I am Removing this enhancement from the 1.17 milestone.

Please feel free to raise an exception if you want to get it into this milestone.

palnabarun commented 4 years ago

/milestone clear

jeremyrickard commented 4 years ago

Hi @apelisse @sttts ,

1.18 enhancements team reaching out 👋

It looks like the PR that didn't make code freeze for 1.17 has merged. Are you planning on including this in the 1.18 release?

Thanks!

apelisse commented 4 years ago

I think we do. We need to talk about what's left to be done. I think you can track it for now, we'll let you know if we can't make it.

jeremyrickard commented 4 years ago

/milestone v1.18

apelisse commented 4 years ago

No plan for 1.18, you can stop tracking and move it to 1.19 :-/

jeremyrickard commented 4 years ago

Thanks for the update @apelisse

jeremyrickard commented 4 years ago

/milestone v1.19

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

palnabarun commented 4 years ago

Hi @apelisse -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

The current release schedule is:

apelisse commented 4 years ago

Hi there, we're not planning on promoting this feature this cycle, thank you!

palnabarun commented 4 years ago

Thank you @apelisse for the update. I will update the tracking sheet accordingly. :+1:

palnabarun commented 4 years ago

/milestone clear

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

sttts commented 4 years ago

/remove-lifecycle stale

kikisdeliveryservice commented 4 years ago

Hi @apelisse

Enhancements Lead here. Any plans for this in 1.20?

Thanks! Kirsten

apelisse commented 4 years ago

Hopefully next release

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

apelisse commented 3 years ago

This is on my backlog, and I believe we can have a new discussion around this since we changed the null semantics. /remove-lifecycle stale

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

apelisse commented 3 years ago

/lifecycle frozen

fejta-bot commented 3 years ago

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen. Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

apelisse commented 3 years ago

/lifecycle frozen

sftim commented 1 year ago

It'd be lovely to account for immutability in the API reference docs (and the code that generates them).

Example: https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/object-meta/ doesn't mention that some fields, such as name and namespace (if set) aren't mutable.

FWIW, https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names also doesn't mention this.