search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

Add a configurable default constraint to PodTopologySpread #1258

Closed alculquicondor closed 2 years ago

alculquicondor commented 5 years ago

Enhancement Description

alculquicondor commented 4 years ago

We are graduating to beta for 1.20. I'll prepare a KEP update soon.

kikisdeliveryservice commented 4 years ago

Thanks @alculquicondor !

When you update the KEP can you also please fix the target and KEP link in the description?

/milestone v1.20

alculquicondor commented 4 years ago

/retitle Add a configurable default constraint to PodTopologySpread

MorrisLaw commented 4 years ago

Hey @alculquicondor -- 1.20 Enhancements Shadow here 👋

I see that a PR with changes to a KEP is still in flight. Just a friendly reminder that the Enhancements Freeze deadline is October 6th. Otherwise, an exception will need to be submitted.

Appreciate the work!

Regards, Jeremy

MorrisLaw commented 4 years ago

Hey @alculquicondor 👋

Just a reminder that the changes to this KEP will need to be in by the October 6th Enhancements freeze deadline if we want to graduate to beta in 1.20.

Regards, Jeremy

alculquicondor commented 4 years ago

graduation to Beta was just approved, thanks :)

MorrisLaw commented 4 years ago

Hi @alculquicondor ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Best, Jeremy

reylejano commented 4 years ago

Hello @alculquicondor , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

reylejano commented 3 years ago

Hi @alculquicondor

The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

alculquicondor commented 3 years ago

All tasks for 1.20 are completed

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

alculquicondor commented 3 years ago

/lifecycle frozen

fejta-bot commented 3 years ago

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen. Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

k8s-triage-robot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

alculquicondor commented 3 years ago

/help for graduation to GA.

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 3 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1258#issuecomment-931386462): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alculquicondor commented 3 years ago

/reopen

I'm gonna graduate this feature to GA in 1.24

k8s-ci-robot commented 3 years ago

@alculquicondor: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1258#issuecomment-931444843): >/reopen > >I'm gonna graduate this feature to GA in 1.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1258#issuecomment-955383457): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alculquicondor commented 2 years ago

/reopen

/help

k8s-ci-robot commented 2 years ago

@alculquicondor: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1258#issuecomment-1006041809): >/reopen > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alculquicondor commented 2 years ago

/remove-lifecycle rotten

alculquicondor commented 2 years ago

/assign @gavinfish

/remove help

alculquicondor commented 2 years ago

/remove-help

kerthcet commented 2 years ago

DefaultPodTopologySpread is GA in https://github.com/kubernetes/kubernetes/pull/108278 already. Should we updated the description and whether any works remaining? @alculquicondor

alculquicondor commented 2 years ago

You need to update the state of the feature in the website https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/#internal-default-constraints

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

alculquicondor commented 2 years ago

Thanks @kerthcet for graduating this feature!

/close

k8s-ci-robot commented 2 years ago

@alculquicondor: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1258#issuecomment-1141398683): >Thanks @kerthcet for graduating this feature! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.