search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.39k stars 1.46k forks source link

Support of mixed protocols in Services with type=LoadBalancer #1435

Closed janosi closed 1 year ago

janosi commented 4 years ago

Enhancement Description

KEP document: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20200103-mixed-protocol-lb.md

GA k/k PR in v1.26: https://github.com/kubernetes/kubernetes/pull/112895

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

janosi commented 4 years ago

/sig network

janosi commented 4 years ago

Original issue: https://github.com/kubernetes/kubernetes/issues/23880

helayoty commented 4 years ago

Hey there @janosi -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze Thursday, March 5th, EOD PST - Code Freeze Monday, March 16th - Docs must be completed and reviewed Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

janosi commented 4 years ago

Hello @helayoty, thank you for your guidance! I really hope we can make it in 1.18. Let's hope we can have an agreed design plan via the KEP on time, and then the implementation can be finished.

The relevant PR in k/k: https://github.com/kubernetes/kubernetes/pull/75831

helayoty commented 4 years ago

Thanks, @janosi for the update. Would you please include the KEP PR if any?

helayoty commented 4 years ago

/milestone v1.18

janosi commented 4 years ago

Would you please include the KEP PR if any?

@helayoty Yes, of course. I added the ref to the KEP PR to the initial description of this issue.

kikisdeliveryservice commented 4 years ago

Hi @janosi as a reminder: today is the deadline for Enhancements Freeze for 1.18. If you need any help from the release team's side please let us know.

janosi commented 4 years ago

@kikisdeliveryservice Yeah, thank you! Actually I wait for a go/no go statement on the KEP PR from the SIG Network members @thockin @caseydavenport @andrewsykim

jeremyrickard commented 4 years ago

Hey @janosi, unfortunately since the KEP didn't merge before enhancement freeze, we're going to need to remove it from the milestone. If you can get the KEP merged, you can file an Exception Request and we can add it back to the milestone.

jeremyrickard commented 4 years ago

/milestone clear

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

palnabarun commented 4 years ago

Hi @janosi -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

janosi commented 4 years ago

Hi @palnabarun , The situation is same here as with the SCTP feature. I do not know what will happen. The KEP waits for more comments as there was an alternative proposal for the control of the solution. That is the last update that happened 28 days ago.

@thockin @andrewsykim

kenperkins commented 4 years ago

What's needed here? This appears to have stalled; I'd love to help if there's anything I can do.

palnabarun commented 4 years ago

@janosi -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

janosi commented 4 years ago

PR: https://github.com/kubernetes/kubernetes/pull/94028

kikisdeliveryservice commented 4 years ago

Hi @janosi

Enhancements Lead here. Any plans for this in 1.20?

Thanks! Kirsten

janosi commented 4 years ago

Hello @kikisdeliveryservice

Yes, I would like to have it in 1.20. The PR is open, waiting for further reviews. As it includes an API change an API review is required, too.

Thanks!

Laszlo

kikisdeliveryservice commented 4 years ago

Hi @janosi

Thank you for the update! I took a look at the KEP (and updated the description of this issue to link to it), but it seems to be provisional. As noted here KEPs must be in an implementable state, as well have testing plans and graduation criteria to be included in the milestone.

Please update your KEP as per the templates here, as you are using an old format: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template and ensure the above criteria are satisfied. I will update the tracking sheet and we will check back in to ensure this is up to date.

Also can you please update the description above with the new target milestones for this KEP?

Best, Kirsten

/milestone v1.20

MorrisLaw commented 3 years ago

Hey @janosi -- 1.20 Enhancements Shadow here 👋

Just a friendly reminder that the Enhancements Freeze deadline is October 6th.

Please update your KEP to match the new format detailed in https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Appreciate your work!

Regards, Jeremy

janosi commented 3 years ago

@MorrisLaw please see the KEP PR here https://github.com/kubernetes/enhancements/pull/2058 Your comments are welcome!

MorrisLaw commented 3 years ago

As a reminder, Enhancements Freeze deadline is Tomorrow October 6th EOD PST.

janosi commented 3 years ago

@MorrisLaw Thank you. I updated the KEP PR here https://github.com/kubernetes/enhancements/pull/2058 as you requested

kikisdeliveryservice commented 3 years ago

Hi @janosi

Enhancements Freeze is now in effect. Unfortunately, your PR making the required changes has not merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best, Kirsten 1.20 Enhancements Lead

janosi commented 3 years ago

Hi @kikisdeliveryservice

Thank you. Just sent the exception request.

Best regards, Laszlo

kikisdeliveryservice commented 3 years ago

Hi @janosi

Your Exception Request was approved so moving this back into 1.20 milestone. =)

MorrisLaw commented 3 years ago

Hi @janosi ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Best, Jeremy

kcmartin commented 3 years ago

Hello @janosi , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

kcmartin commented 3 years ago

Hi @janosi

The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

janosi commented 3 years ago

@kcmartin Thank you for the notification! I created the document PR: https://github.com/kubernetes/website/pull/24874

MorrisLaw commented 3 years ago

Hi @janosi

The code freeze deadline is almost here. Please make sure to merge in any k/k PRs by the deadline if we plan to keep this enhancement in the 1.20 milestone.

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

janosi commented 3 years ago

Hello @MorrisLaw

Yeah, I hope I can get the lgtm on the k/k PR again. I lost it as I had to rebase.

kikisdeliveryservice commented 3 years ago

Hi @janosi is this going to get in bc I see that it is missing a LGTM (for your latest update for thockin's comment) and needs a rebase. https://github.com/kubernetes/kubernetes/pull/94028

Thanks, Kirsten

kikisdeliveryservice commented 3 years ago

Hi @janosi

Code Freeze is now in effect. Your PR is still unmerged, but has full approval. It needs a final rebase (sorry I know this has happened a lot) so that it can merge. If you can please rebase and get another LGTM ASAP that would be great.

Best, Kirsten

agrbhuvnesh commented 3 years ago

Any plan to backport MixedProtocolLBService support in earlier releases?

haslersn commented 3 years ago

Will this land in Kubernetes 1.20?

janosi commented 3 years ago

@agrbhuvnesh About backport: I do not know about such plans. @haslersn Yes, it is in 1.20 as alpha, behind the MixedProtocolLBService feature gate. https://kubernetes.io/docs/concepts/services-networking/service/#load-balancers-with-mixed-protocol-types

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

m-yosefpor commented 3 years ago

/remove-lifecycle stale

thockin commented 3 years ago

@janosi - any reason not to bump this to beta?

janosi commented 3 years ago

@thockin Unfortunately, the 2nd part of the implementation is still missing: the kubelet does not update the problematic ports in the new condition.

aojea commented 3 years ago

@thockin Unfortunately, the 2nd part of the implementation is still missing: the kubelet does not update the problematic ports in the new condition.

do you mean kube-proxy @janosi ?

feiskyer commented 3 years ago

Unfortunately, the 2nd part of the implementation is still missing: the kubelet does not update the problematic ports in the new condition.

@janosi any github issues to track the problem and what's the plan to fix it?

feiskyer commented 3 years ago

@thockin @khenidak do you know the plans to move this to GA?

aojea commented 3 years ago

@thockin @khenidak do you know the plans to move this to GA?

There is no owner of the feature, the author is not longer replying ...

I've tried to move it forward this cycle, but I couldn't find the cloud providers information

All of the major clouds support this or indicate non-support properly

it has to meet the alpha to beta criteria https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/1435-mixed-protocol-lb#alpha---beta-graduation

feiskyer commented 3 years ago

there's another issue in kubelet, which is not clear enough either:

Unfortunately, the 2nd part of the implementation is still missing: the kubelet does not update the problematic ports in the new condition.

janosi commented 3 years ago

@aojea @feiskyer I am sorry for my silence. :( It was not about abandoning this feature.

do you mean kube-proxy @janosi ?

Yes, I meant kube-proxy. And the kube-proxy should use the status of the LB Service as input to learn which ports should be really opened. My bad.

feiskyer commented 3 years ago

@janosi could you open a bug with details so that others could help to fix in case you're not available?