search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.44k stars 1.48k forks source link

Speed up recursive SELinux label change #1710

Open jsafrane opened 4 years ago

jsafrane commented 4 years ago

Enhancement Description

The KEP describes 3 phases / 3 feature gates.

SELinuxMountReadWriteOncePod:

SELinuxChangePolicy

SELinuxMount

jsafrane commented 4 years ago

/sig storage /sig node

palnabarun commented 4 years ago

Hey @jsafrane -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

palnabarun commented 4 years ago

Hi @jsafrane,

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

Will this enhancement be part of the 1.19 release cycle?

palnabarun commented 4 years ago

@jsafrane -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

jsafrane commented 4 years ago

@palnabarun hey, we've just merged the KEP yesterday, at the last moment. I admit I did not pay attention to this enhancement issue and focused on the design. Do I really need an exception just to restore the milestone?

palnabarun commented 4 years ago

Do I really need an exception just to restore the milestone?

Yes, an exception would be needed. Here is the process on how to file and exception request.

palnabarun commented 4 years ago

@jsafrane -- Your exception request was approved. I have updated the tracking sheet accordingly.

palnabarun commented 4 years ago

/milestone v1.19

palnabarun commented 4 years ago

/stage alpha

zestrells commented 4 years ago

Hi @jsafrane - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :) If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

jsafrane commented 4 years ago

@zestrells, yes, documentation will be needed. I can't edit the tracking sheet, can you please note it there?

harshanarayana commented 4 years ago

Hey @jsafrane, I am with the enhancements team for the v1.19 release cycle as a shadow.

The code freeze deadline for the Enhancement is Thursday, June 25. I am checking in to see if there is any k/k PR that you have already opened for this enhancement and if so, would you be able to point me in the direction of the PR so that the same can be updated in the tracking sheet

Have a wonderful day. 🖖

zestrells commented 4 years ago

Hi @jsafrane - Just a reminder that docs placeholder PR against dev-1.19 is due by June 12th. Does this enhancement require any changes to docs? If so, can you update here with a link to the PR once you have it in place? If not, please update the same, so that the tracking sheet can be updated accordingly. Thanks!

harshanarayana commented 4 years ago

Hey @jsafrane, This is just a reminder that the code freeze for the enhancement is Thursday, June 25. I am checking in to see if there is any k/k PR that is already open against this enhancement that needs to be tracked.

Have a wonderful day. 🖖

jsafrane commented 4 years ago

API PR: https://github.com/kubernetes/kubernetes/pull/91838 WIP Docs: https://github.com/kubernetes/website/pull/21773

harshanarayana commented 4 years ago

Hi, @jsafrane

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

harshanarayana commented 4 years ago

Hi @jsafrane ,

This is just a follow up to my earlier messages on the upcoming deadlines. The code freeze deadline is Thursday, July 9th EOD PST and I noticed that the k/k PRs are still in flight.

For the enhancement to be included into v1.19 this PR needs to be merged before the code freeze deadline.

Please refer to the Exception Process documentation in case if there is a need for one.

harshanarayana commented 4 years ago

/milestone clear /milestone v1.20

harshanarayana commented 4 years ago

/milestone v1.20

kikisdeliveryservice commented 4 years ago

Hi @jsafrane !

Enhancements Lead here, do you intend to do work on this for alpha in 1.20?

Thanks! Kirsten

kikisdeliveryservice commented 4 years ago

Hi @jsafrane

Following up is this going to be included in 1.20?

Thanks, Kirsten

kikisdeliveryservice commented 4 years ago

Hi @jsafrane : Final Reminder: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20? Also, the current KEP needs a kep.yaml update along with a README.md update to correct the milestones.

Thanks. Kirsten

jsafrane commented 4 years ago

Hello, this feature won't be implemented in 1.20. We'd like to focus on the design in this release.

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1710#issuecomment-790838971): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 3 years ago

/reopen /remove-lifecycle rotten

k8s-ci-robot commented 3 years ago

@gnufied: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1710#issuecomment-911021569): >/reopen >/remove-lifecycle rotten > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
m-yosefpor commented 3 years ago

Tested in k8s 1.20, CRI-O 1.20, changing fsGroupChangePolicy to OnRootMismatch significantly improves mount time, however volumes still take many minutes to be mounted due to this issue. I can see high CRI-O iops during the operation, and here is the events of pod:

 Warning  Failed          5m41s (x2 over 7m42s)  kubelet            Error: context deadline exceeded
  Warning  Failed          5m10s                  kubelet            Error: Kubelet may be retrying requests that are timing out in CRI-O due to system load: the requested container xxxx is now ready and will be provided to the kubelet on next retry: error reserving ctr name xxxx for id xxxx : name is reserved

This is a test volume with only 500K files which took 5 minutes to be mounted! (note we have IOPS qos (300 IO per second per volume) on our Cluster for volumes for stability reasons.)

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jsafrane commented 2 years ago

/remove-lifecycle stale

xing-yang commented 2 years ago

/milestone v1.24

hosseinsalahi commented 2 years ago

Hello @jsafrane

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24.

Here’s where this enhancement currently stands:

The status of this enhancement is marked as tracked. Thanks!

jsafrane commented 2 years ago

I am updating the KEP (quite a lot) in #3172.

didicodes commented 2 years ago

Hi @jsafrane, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

hosseinsalahi commented 2 years ago

Hello @jsafrane

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

jsafrane commented 2 years ago

We're postponing this to 1.25, we can't get all the required changes in for the feature freeze in 1.24. /milestone 1.25

k8s-ci-robot commented 2 years ago

@jsafrane: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to [this](https://github.com/kubernetes/enhancements/issues/1710#issuecomment-1076631743): >We're postponing this to 1.25, we can't get all the required changes in for the feature freeze in 1.24. >/milestone 1.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jsafrane commented 2 years ago

/milestone v1.25

Priyankasaggu11929 commented 2 years ago

Hello @jsafrane 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands: (updated on June 9, 2022)

Looks like for this one, we would need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

jsafrane commented 2 years ago

@Priyankasaggu11929 I updated the KEP with a new template and updated the test plan. Let me know if there is anything missing. (Do you have a script that checks / generates the checklist above? Can I run it by myself?)

Priyankasaggu11929 commented 2 years ago

Thanks for the update @jsafrane 🙂

Do you have a script that checks / generates the checklist above? Can I run it by myself?

No yet, the team do a manual check through the KEPs :)

With the KEP PR https://github.com/kubernetes/enhancements/pull/3348 merged now, this enhancements is all good for the upcoming enhancements freeze 🚀

For note, the status of the enhancement is now marked as tracked.

krol3 commented 2 years ago

Hello @jsafrane 👋, 1.25 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

rhockenbury commented 2 years ago

👋 Hey @jsafrane,

Enhancements team checking in as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed by code freeze: [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes). [ ] All PRs are fully merged by the code freeze deadline.

Looks like there is one PR in k/k for alpha for this enhancement. Let me know if I missed any other PRs that need to be tracked.

As always, we are here to help should questions come up. Thanks!!

rhockenbury commented 2 years ago

Gentle reminder that we are about a week from code freeze, and all k/k PRs need to be merged before code freeze for this enhancement to be included in v1.25. Please also let me know if there are any other PRs we should be tracking.

Priyankasaggu11929 commented 2 years ago

Hello :wave:, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

jsafrane commented 2 years ago

I asked for an exception, I got API approval 1 hour after feature freeze.

jsafrane commented 2 years ago

Added ~placeholder~ real doc PR: https://github.com/kubernetes/website/pull/35667

jsafrane commented 2 years ago

Doc for CSI driver vendors: https://github.com/kubernetes-csi/docs/pull/524