search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

kubeadm: customization with patches #1739

Open neolit123 opened 4 years ago

neolit123 commented 4 years ago

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

kubeadm tracking issue: https://github.com/kubernetes/kubeadm/issues/2046

this feature replaces and existing feature added with this KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cluster-lifecycle/kubeadm/20190722-Advanced-configurations-with-kubeadm-(Kustomize).md

palnabarun commented 4 years ago

Hey @neolit123 -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating to Alpha in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

neolit123 commented 4 years ago

hi, yes the feature is planned as alpha for 1.19. the KEP in https://github.com/kubernetes/enhancements/pull/1742 should merge as "implementable" before the 19th.

palnabarun commented 4 years ago

@neolit123 Awesome! :fireworks: Thank you for the update.

I am going ahead and updating the tracking sheet accordingly.

PS: Until the PR gets merged, I'm marking the enhancement At Risk. Once, the PR gets merged, I would update the status.

palnabarun commented 4 years ago

/stage alpha /milestone v1.19

neolit123 commented 4 years ago

@palnabarun

PS: Until the PR gets merged, I'm marking the enhancement At Risk. Once, the PR gets merged, I would update the status.

hi, the KEP merged as "implementable": https://github.com/kubernetes/enhancements/pull/1742 https://github.com/kubernetes/enhancements/pull/1742/files#diff-43d8c9f7a843e756c4e752fd1f7fbe44R8

palnabarun commented 4 years ago

@neolit123 -- Thanks for the ping. I have updated the tracking sheet. :+1:

palnabarun commented 4 years ago

PS: I have updated the issue description with the link to the KEP.

msedzins commented 4 years ago

Hi @neolit123 , enhancement shadow here -- Can you please link to all the implementation PR's here - k/k or otherwise? :slightly_smiling_face:

The current release schedule is:

neolit123 commented 4 years ago

@msedzins hi, the PRs are not created yet, but i can link them once that is done.

msedzins commented 4 years ago

Thank you @neolit123!

divya-mohan0209 commented 4 years ago

Hello @neolit123 , I'm one of the v1.19 docs shadows.

Could you please let me know if this piece of enhancement work planned for 1.19 release requires any new docs (or modifications to existing docs)?

If not, can you please update the 1.19 Enhancement Tracker Sheet (or let me know and I'll do so)

If yes, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time.

Please do let me know if you have any questions!

Regards, Divya

neolit123 commented 4 years ago

hi, @divya-mohan0209 this feature will only be documented in the help message for a command line flag in its Alpha state, but we do plan to have e2e tests for the Alpha.

divya-mohan0209 commented 4 years ago

So to clarify my understanding @neolit123 , you will not be requiring documentation on the Kubernetes website right?

neolit123 commented 4 years ago

correct. for 1.19 we don't need k/website PRs.

divya-mohan0209 commented 4 years ago

Alright, thank you for the confirmation!

msedzins commented 4 years ago

Hi @neolit123, any update on PRs?

Thank you.

neolit123 commented 4 years ago

not yet.

neolit123 commented 4 years ago

WIP PR is here (more commits to be added this week): https://github.com/kubernetes/kubernetes/pull/92017

msedzins commented 4 years ago

Thank you @neolit123!

msedzins commented 4 years ago

Hi, @neolit123

This is a follow-up to the communication that went out to k-dev today. There has been a revision to the release schedule of v1.19 as follows.

Thursday, July 9th: Week 13 - Code Freeze
Thursday, July 16th: Week 14 - Docs must be completed and reviewed
Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released
Thursday, August 27th: Week 20 - Release Retrospective

You can find the revised Schedule in the sig-release Repo

Please let me know if you have any questions. 🖖

msedzins commented 4 years ago

Hi @neolit123 , from what I can see this enhancement is Code complete so it's ready for Code freeze deadline which happens July 9th. Please let me know if you think otherwise and there are any risks for that enhancement to be included in v.1.19.

neolit123 commented 4 years ago

@msedzins hi, the code changes merged: https://github.com/kubernetes/kubernetes/pull/92017

e2e PRs too: https://github.com/kubernetes/test-infra/pull/17934 https://github.com/kubernetes/kubeadm/pull/2184

docs are planned for the beta.

kikisdeliveryservice commented 4 years ago

Hi @neolit123

Enhancements Lead here. Any plans for this in 1.20?

Thanks! Kirsten

neolit123 commented 4 years ago

Hi, this feature will likely remain alpha in 1.20. Will keep this issue updated if we change the plan.

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

neolit123 commented 3 years ago

/remove-lifecycle stale

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

neolit123 commented 3 years ago

/remove-lifecycle stale

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

neolit123 commented 3 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten