search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

Expose metrics about resource requests and limits that represent the pod model #1748

Closed smarterclayton closed 4 months ago

smarterclayton commented 4 years ago

Enhancement Description

dgrisonnet commented 2 years ago

I opened https://github.com/kubernetes/kube-state-metrics/issues/1846 in kube-state-metrics to make the transition to the kube-scheduler metrics.

dgrisonnet commented 1 year ago

@smarterclayton we are now recommending users to switch to the scheduler resource metrics in kube-state-metrics and there is an open PR to propagate the use of the new metrics in the Prometheus mixins: https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/815. Based on that, we should have a good enough user base for these metrics, so would it make sense to graduate the effort to stable?

npolshakova commented 1 year ago

Hello @dgrisonnet 👋, 1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

It looks like https://github.com/kubernetes/kubernetes/pull/115454 and https://github.com/kubernetes/enhancements/pull/3810 will address most of these issues.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

dgrisonnet commented 1 year ago

Hi @npolshakova, I completed the different action items, please let me know if there is anything else I need to do.

npolshakova commented 1 year ago

Great, I'm marking this enhancement as tracked for v1.27. Thanks!

/remove-label tracked/no /label tracked/yes

k8s-ci-robot commented 1 year ago

@npolshakova: Those labels are not set on the issue: tracked/no

In response to [this](https://github.com/kubernetes/enhancements/issues/1748#issuecomment-1424752720): >Great, I'm marking this enhancement as tracked for v1.27. >Thanks! > >/remove-label tracked/no >/label tracked/yes Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
npolshakova commented 1 year ago

Hi @dgrisonnet,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP. As always, we are here to help should questions come up. Thanks!

dgrisonnet commented 1 year ago

Hi @npolshakova, I have updated everything, thank you for the reminder :)

LukeMwila commented 1 year ago

Hi @dgrisonnet @smarterclayton, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

dgrisonnet commented 1 year ago

Hi @LukeMwila, I completely missed the fact that we add to write a doc for this KEP. I opened a placeholder PR for now https://github.com/kubernetes/website/pull/39970.

@smarterclayton do you perhaps remember what you had in mind for the doc? I was thinking about drafting something about capacity planning in general.

dashpole commented 9 months ago

@dgrisonnet reminder to write the documentation for this. After that, we can move the KEP to implemented and close this.

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 4 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/1748#issuecomment-2171806715): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.