search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

Support recovery from volume expansion failure #1790

Open gnufied opened 4 years ago

gnufied commented 4 years ago

Enhancement Description

gnufied commented 4 years ago

/sig storage

palnabarun commented 4 years ago

/milestone v1.19

palnabarun commented 4 years ago

/stage alpha

palnabarun commented 4 years ago

@gnufied -- Can you please link to all the implementation PR's here - k/k or otherwise? :slightly_smiling_face:

The current release schedule is:

mikejoh commented 4 years ago

Hello, @gnufied ! :wave: I'm one of the v1.19 Docs shadows. Does this enhancement work planned for v1.19 require any new docs (or modifications to existing docs)?

This is a friendly reminder that we're looking for a PR against kubernetes/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Regards, Mikael.

palnabarun commented 4 years ago

Can you please link to all the implementation PR's here - k/k or otherwise?

@gnufied -- Pinging back as a friendly reminder for the above. :slightly_smiling_face:

gnufied commented 4 years ago

@palnabarun thanks for the reminder. there isn't one yet.

gnufied commented 4 years ago

PR that implements necessary API changes and updates quota calculation code - https://github.com/kubernetes/kubernetes/pull/91976

mikejoh commented 4 years ago

Hi @gnufied! Friendly reminder regarding that docs placeholder PR against kubernetes/website (branch dev-1.19). The deadline for this have been pushed to Friday the 19th of June. Let me know if you have any questions!

palnabarun commented 4 years ago

Hi @gnufied -- just wanted to check in about the progress of the enhancement.

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. :slightly_smiling_face:

The revised release schedule is:

gnufied commented 4 years ago

Docs PR - https://github.com/kubernetes/website/pull/21920

palnabarun commented 4 years ago

Hi @gnufied :wave:, I see that https://github.com/kubernetes/kubernetes/pull/91976 and https://github.com/kubernetes/kubernetes/pull/92770 yet to be merged. Do you think that they will be merged before the Code Freeze on Thursday, July 9th?

Thank you. :slightly_smiling_face:

Code Freeze begins on Thursday, July 9th EOD PST

annajung commented 4 years ago

Hi @gnufied 👋 docs shadow here. Just a quick reminder to get your doc PR ready for review (Remove WIP/rebased/all ready to go) by EOD. Thank you!

gnufied commented 4 years ago

@annajung done. thank you.

palnabarun commented 4 years ago

@gnufied -- Please note that tomorrow is Code Freeze.

If the enhancement misses the code freeze, you will need to file an Exception Request in order to get this back into 1.19.

Code Freeze begins on Thursday, July 9th EOD PST

kikisdeliveryservice commented 4 years ago

I spoke to @gnufied this evening as since all of the related PRs have not merged he would like to defer this to 1.20

/milestone 1.20

k8s-ci-robot commented 4 years ago

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to [this](https://github.com/kubernetes/enhancements/issues/1790#issuecomment-656445317): >I spoke to @gnufied this evening as since all of the related PRs have not merged he would like to defer this to 1.20 > >/milestone 1.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kikisdeliveryservice commented 4 years ago

/milestone v1.20

kikisdeliveryservice commented 4 years ago

Hi @gnufied !

Enhancements Lead here, do you still intend to target this for alpha in 1.20?

Thanks! Kirsten

kikisdeliveryservice commented 4 years ago

Hi @gnufied

Checking in again - will this go alpha in 1.20?

By Enhancements Freeze, Oct 6th, all KEPs intended for the 1.20 Release must be:

Thanks, Kirsten

gnufied commented 4 years ago

We are just planning to design this feature in 1.20. I do not think we will be able to implement this in 1.20.

kikisdeliveryservice commented 4 years ago

Sounds good, if anything changes just LMK.

Thank you!

/milestone clear

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1790#issuecomment-782891772): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnufied commented 3 years ago

/reopen

gnufied commented 3 years ago

/remove-lifecycle rotten

k8s-ci-robot commented 3 years ago

@gnufied: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1790#issuecomment-833171100): >/reopen > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xing-yang commented 3 years ago

@JamesLaverack Can you track this for v1.22? Thanks. The KEP is https://github.com/kubernetes/enhancements/pull/2685.

gracenng commented 3 years ago

Hi @gnufied 👋 1.22 Enhancements Shadow here.

Does sig-storage need to do anything for this enhancement and if so, is the SIG ok with it?

I also have some minor change requests in light of Enhancement Freeze on Thursday May 13th:

Thanks!

gnufied commented 3 years ago

@gracenng thanks. I have asked @deads2k to do a PRR review if possible. Updated rest of the stuff.

gracenng commented 3 years ago

Hi @gnufied , I just wanted to check in and let you know that I reviewed the requested changes and will update this enhancement status as soon as the KEP is merged. Please ping me on slack if needed. Thanks!

PI-Victor commented 3 years ago

Hello @gnufied 👋, 1.22 Docs release lead here. This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 
Thank you!

gracenng commented 3 years ago

Hi @gnufied 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is at risk as there is no k/k PR associated. Please update the issue description so enhancements can update your status for code freeze.

Thanks!

gnufied commented 3 years ago

@gracenng most of changes into k/k repo is captured in - https://github.com/kubernetes/kubernetes/pull/103124

gnufied commented 3 years ago

This feature is going to miss 1.22 release. We will try again in 1.23

gracenng commented 3 years ago

Removing 1.22 milestone

/milestone clear

xing-yang commented 3 years ago

/milestone v1.23

lauralorenz commented 3 years ago

Hi @gnufied! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09.

If I understand correctly, you are targeting beta graduation for release 1.23.

Here's where this enhancement currently stands for beta graduation for 1.23:

Starting with 1.23, we have implemented a soft freeze on requesting production readiness reviews beginning TOMORROW, Thursday 09/02. If your enhancement needs a PRR, please make sure to request it by tomorrow!

Thanks!

deads2k commented 3 years ago

This is actually targeting alpha for 1.23: https://github.com/kubernetes/enhancements/pull/2807#issuecomment-914531636

/stage alpha

lauralorenz commented 3 years ago

Great, thank you @deads2k!

In that case, @gnufied as long as your PR is merged by enhancements freeze on Thursday 09/09 by 23:59:59 PDT you are on track!

ramrodo commented 3 years ago

Hi @gnufied :wave: 1.23 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

lauralorenz commented 2 years ago

Hi @gnufied, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

Thanks!!

gnufied commented 2 years ago

Placeholder doc PR - https://github.com/kubernetes/website/pull/30552

xing-yang commented 2 years ago

/milestone v1.24

gracenng commented 2 years ago

/stage beta /tracked yes

rhockenbury commented 2 years ago

Hi @gnufied! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting beta for 1.24.

Here’s where this enhancement currently stands:

Please plan to update the kep.yaml and complete a production readiness review.

The status of this enhancement is at risk. Thanks!

rhockenbury commented 2 years ago

With #3188 merged, I've moved this KEP to tracked for this cycle. All set for enhancement freeze. 🚀

didicodes commented 2 years ago

Hi @gnufied, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌