search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.33k stars 1.44k forks source link

Make Kubernetes aware of the LoadBalancer behaviour #1860

Open Sh4d1 opened 4 years ago

Sh4d1 commented 4 years ago

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

Sh4d1 commented 4 years ago

/sig network

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

Sh4d1 commented 3 years ago

/remove-lifecycle stale

kikisdeliveryservice commented 3 years ago

Hi @Sh4d1

1.20 Enhancements Lead here. This KEP still seems to be a draft (it's provisional) but wanted to check-in to see if you thought this would be graduating alpha in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state The KEP must have test plans The KEP must have graduation criteria The KEP must have an issue in the milestone

Best, Kirsten

kikisdeliveryservice commented 3 years ago

Note: this provisional kep was implemented without having a compliant kep or indicating to the enhancements team that it would be in the 1.20 milestone.

jeremyrickard commented 3 years ago

Hey @Sh4d1 and @thockin,

:wave: 1.20 release lead here. We're really close to code freeze at this point (Thursday) and it seems like this KEP fell through the cracks and the process.

Based on this comment in the PR above: https://github.com/kubernetes/kubernetes/pull/92312#issuecomment-724907740 can we not land this in 1.20 and instead target 1.21?

There are few things w/ the KEP that really should be address:

Looks like there is also a PR to update the KEP https://github.com/kubernetes/enhancements/pull/2134/files that addresses this stuff, however it also marks it as implemented and targets 1.21. Typically, we set to implemented only after the release.

Can we circle back around on this and agree that we should try to land this in 1.21 at this point? We've already got a lot of content for the release so far (sig-docs has their work cut out for themselves!!!), we're two days out from code freeze, we have these disconnects mentioned above?

Sh4d1 commented 3 years ago

@jeremyrickard just opened https://github.com/kubernetes/kubernetes/pull/96454 to revert it, sorry again! And updated #2134 to set it as implentable instead of implemented

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1860#issuecomment-817125152): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Sh4d1 commented 3 years ago

/reopen

k8s-ci-robot commented 3 years ago

@Sh4d1: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1860#issuecomment-817128305): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1860#issuecomment-836685386): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
thockin commented 2 years ago

@Sh4d1 Are we going to revisit this?

thockin commented 2 years ago

FTR: latest word (https://github.com/kubernetes/kubernetes/pull/96454#issuecomment-903566373) is:

@Sh4d1 is stepping away.

101027 needs to be finished

97681 needs to be rebased once the one above is merged

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

thockin commented 1 year ago

No progress for 1.26

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

choerl-sys11 commented 1 year ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

choerl-sys11 commented 1 year ago

/remove-lifecycle stale

RyanAoh commented 1 year ago

Hi @thockin, are you currently working on this? If not, I can try to submit a PR. I have already made some commits in my code.

thockin commented 1 year ago

I have some half-cooked branch, but have not had time to really followup. Feel free to start on it if you like, but this KEP is not going into 1.28

thockin commented 1 year ago

xref https://github.com/kubernetes/kubernetes/pull/97681 as a starting point

npolshakova commented 9 months ago

Hi @RyanAoh, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancements and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

RyanAoh commented 9 months ago

cc @thockin https://github.com/kubernetes/enhancements/pull/4114 has been merged.

RyanAoh commented 9 months ago

@npolshakova The enhancement was ready. Now need the lead-opted-in label by @thockin

sreeram-venkitesh commented 9 months ago

Hello @RyanAoh πŸ‘‹, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. πŸš€

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

harshitasao commented 8 months ago

Hi @Sh4d1 πŸ‘‹, v1.29 Docs Shadow here Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

sreeram-venkitesh commented 8 months ago

Hey again @RyanAoh πŸ‘‹ v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs has been merged before code freeze. Please update the issue description with the PR. Currently marking the KEP as tracked for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

RyanAoh commented 8 months ago

@sreeram-venkitesh I can't update the issue description since I'm not the author for this. Just comment here. All PRs related to this kep:

and the one for doc:

RyanAoh commented 8 months ago

Or do I need to open a new issue for it？

sreeram-venkitesh commented 8 months ago

@RyanAoh This is fine, you don't need to open a different issue. Thanks for the quick update!

kcmartin commented 8 months ago

Hi @RyanAoh ! πŸ‘‹ from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

salehsedghpour commented 6 months ago

/remove-label lead-opted-in

salehsedghpour commented 5 months ago

Hello πŸ‘‹ 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

thockin commented 5 months ago

Hi @RyanAoh - are you shooting for beta in 1.30?

RyanAoh commented 5 months ago

@thockin Sorry for the delayed response. I've just returned to work after completing my leave. It's a bit late to progress this in v1.30. I'll aim to include it in v1.31.

rikatz commented 4 months ago

@RyanAoh @thockin if this is just on the goal to get it promoted to beta, I can deal with it today.

danwinship commented 4 months ago

/label lead-opted-in /milestone v1.30

salehsedghpour commented 4 months ago

Hey again @RyanAoh and @thockin πŸ‘‹ Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

rikatz commented 4 months ago

@salehsedghpour @aojea is reviewing it :)

as neither me or @RyanAoh have access to edit the issue, we need someone with write access to do it and add thePR :/

thanks

rikatz commented 4 months ago

@salehsedghpour πŸ‘‹ The PR is merged on k/k, https://github.com/kubernetes/website/pull/45219 is waiting to be merged on k/docs.

I think we can move out of "Risk for Code freeze", right?

Thanks!

salehsedghpour commented 4 months ago

@rikatz with https://github.com/kubernetes/kubernetes/pull/123418 being merged, this can now be marked as tracked for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

thockin commented 1 month ago

This went beta in 30. GA in 31? Or wait for 32?