search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.34k stars 1.44k forks source link

Azure file in-tree to CSI driver migration #1885

Closed andyzhangx closed 1 year ago

andyzhangx commented 4 years ago

Enhancement Description

Parent enhancement: #625

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig cloud-provider /area provider/azure /sig storage /assign

msau42 commented 3 years ago

@andyzhangx do you plan to target beta for this in 1.20?

andyzhangx commented 3 years ago

yes, here is the detailed plan: https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/115

kikisdeliveryservice commented 3 years ago

Hi @andyzhangx

The design doc that you linked for this Enhancement is using an old format, please update to use the current KEP format here: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Also please note that Enhancements Freeze is October 6th and by that time we expect that:

The KEP must be merged in an implementable state (the format you are using has no such state) The KEP must have test plans (can you specify which need to be done for beta https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md#testing) The KEP must have graduation criteria (The schedule is stale and references milestones that has already passed: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md#implementation-schedule)

Thanks Kirsten

kikisdeliveryservice commented 3 years ago

Hi @andyzhangx

Enhancements Freeze is October 6th. Can you please respond to the above query and update the doc as requested?

Thanks! Kirsten

msau42 commented 3 years ago

Hi @kikisdeliveryservice, this is the KEP we're using to track all the different csi migration implementations https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md

kikisdeliveryservice commented 3 years ago

Hi @msau42 I spoke to @palnabarun earlier today and got the background. I marked this tracked and good to go for 1.20 :+1:

kendallroden commented 3 years ago

Hey @andyzhangx !

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks so much,

Kendall

somtochiama commented 3 years ago

Hello @andyzhangx, 1.20 Docs shadow here 👋🏽. Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

somtochiama commented 3 years ago

Hi @andyzhangx The docs placeholder deadline is almost here. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

Thank you

kikisdeliveryservice commented 3 years ago

Hi @andyzhangx

Code Freeze is now in effect. Your PR is still unmerged, with no approvals and has a hold. If you believe this should be in the 1.20 Release, please file an Exception.

Best, Kirsten

annajung commented 3 years ago

Hi @andyzhangx, 1.21 Enhancements Lead here. This enhancement has been opt-in for the 1.21 release without a KEP link. However, I was able to locate the CSI migration KEP under sig storage. Could you confirm that https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration is the correct one that's associated with this issue?

andyzhangx commented 3 years ago

Hi @andyzhangx, 1.21 Enhancements Lead here. This enhancement has been opt-in for the 1.21 release without a KEP link. However, I was able to locate the CSI migration KEP under sig storage. Could you confirm that https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration is the correct one that's associated with this issue?

@annajung yes, thanks, we resolved the blocking issue, and Azure file in-tree to CSI driver migration would go beta in 1.21.

annajung commented 3 years ago

Hi @andyzhangx

This enhancement is currently being tracked by the enhancements team for the upcoming release 1.21. However, it's at risk due to missing PRR requirements.

Please make sure that KEP is updated with PRR questionnaires and you follow the requirement for submitting a KEP for PRR approval.

In the KEP, it mentions sig architecture and cluster-lifecycle as participation SIGs. Would you require any work from them to graduate to beta?

msau42 commented 3 years ago

@Jiawei0227 is working on updating the KEP with the PRR

annajung commented 3 years ago

Hi @andyzhangx

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR https://github.com/kubernetes/enhancements/pull/2432). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

annajung commented 3 years ago

With PR https://github.com/kubernetes/enhancements/pull/2432 merged in, this enhancement has met all the criteria for the enhancements freeze 👍

kendallroden commented 3 years ago

Hi @andyzhangx , Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

Thanks!

kendallroden commented 3 years ago

@andyzhangx Hey Andy! I couldn't find any k/k PR(s) linked to this issue.. can you confirm if there is WIP for this enhancement as it pertains to the 1.21 release and the upcoming Code Freeze on 3/9? If so, please link them here for tracking. In the meantime, this enhancement will be marked as "At Risk" for the 3/9 deadline.

Thanks!

andyzhangx commented 3 years ago

@andyzhangx Hey Andy! I couldn't find any k/k PR(s) linked to this issue.. can you confirm if there is WIP for this enhancement as it pertains to the 1.21 release and the upcoming Code Freeze on 3/9? If so, please link them here for tracking. In the meantime, this enhancement will be marked as "At Risk" for the 3/9 deadline.

Thanks!

@kendallnelson k/k code change is done in master branch, there is a related website PR: https://github.com/kubernetes/website/pull/26818

kendallroden commented 3 years ago

I think @kendallnelson has received multiple "@" this release cycle on my behalf :P Thanks for the update @andyzhangx will mark this as good to go for the upcoming freeze! Thanks so much!

kendallnelson commented 3 years ago

I think you have the wrong github handle :) I am @kendallnelson on github and while I do k8s things, I don't have anything to do with Azure.

-Kendall Nelson

On Thu, Mar 4, 2021 at 8:02 PM Kendall @.***> wrote:

I think @kendallnelson https://github.com/kendallnelson has received multiple "@" this release cycle on my behalf :P Thanks for the update @andyzhangx https://github.com/andyzhangx will mark this as good to go for the upcoming freeze! Thanks so much!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/1885#issuecomment-791136369, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGHT4GC2VY42LL7HPZZK53TCBJV5ANCNFSM4ORTBCLA .

k8s-triage-robot commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

Jiawei0227 commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jiawei0227 commented 2 years ago

/remove-lifecycle stale

reylejano commented 2 years ago

/milestone v1.23 An exception request was filed on 11/12/21 for the 1.23 Enhancements Freeze. The exception request was approved on 11/13/21 Please update the kep.yaml to reflect the latest milestone (1.23) and have the PR to update the kep.yaml and any open k/k PRs approved by 18:00 PST on November 16th Linked k/k PR: https://github.com/kubernetes/kubernetes/pull/105070

This enhancement does not graduate phases for 1.23, it remains in beta. The default behavior changes from off to on in 1.23

msau42 commented 2 years ago

KEP milestone update: https://github.com/kubernetes/enhancements/pull/3049 Docs: https://github.com/kubernetes/website/pull/30495

msau42 commented 2 years ago

/milestone v1.24

Priyankasaggu11929 commented 2 years ago

Hello @andyzhangx @Jiawei0227 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting for stage beta for 1.24, and https://github.com/kubernetes/enhancements/pull/3123 is the latest KEP PR, are these correct?

Here’s where this enhancement currently stands:

Looks like for this one, we would just need to update the following:

At the moment, the status of this enhancement is track as at risk. Please update this issue description with appropriate stages as well. Thank you!

Jiawei0227 commented 2 years ago

update the issue description to add current Enhancement target

@andyzhangx Can you help to edit the issue enhancement target?

update the KEP PR KEP-1885: add csi migration kep for azurefile #3123 to add a test plan & graduation criteria and make it even with the latest KEP template.

The migration feature here is a little bit complicated than other features. The Azurefile csi migration is part of the overall CSI migration feature, and we already linked it to the original KEP here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration

The Azurefile PR states that: 

This inherits all the contents from its parent KEP. It will introduce two new feature gates to be 
used as as described in its parent KEP. For all other contents, please refer to the parent KEP.

We have communicated this with sig-release team in previous release and this has been agreed in previous releases. Please let me know if there is anything else we need to do. Thanks a lot!

andyzhangx commented 2 years ago

@Jiawei0227 thanks a lot, I have set as Stable release target (x.y) 1.25

Priyankasaggu11929 commented 2 years ago

The Azurefile PR states that:

This inherits all the contents from its parent KEP. It will introduce two new feature gates to be used as as described in its parent KEP. For all other contents, please refer to the parent KEP.

We have communicated this with sig-release team in previous release and this has been agreed in previous releases. Please let me know if there is anything else we need to do. Thanks a lot!

Hello @Jiawei0227, thanks so much for the clarification ^. That helps! 🙂

Priyankasaggu11929 commented 2 years ago

All of the above criteria are satisfied now that the KEP PR https://github.com/kubernetes/enhancements/pull/3123 has been merged. This enhancement is ready for the upcoming 1.24 enhancements freeze. 🚀

For note, the status of this enhancement is now tracked now. Thank you so much!

didicodes commented 2 years ago

Hi @andyzhangx & @Priyankasaggu11929, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

Priyankasaggu11929 commented 2 years ago

Hello @andyzhangx 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Could you please link recent PRs for the enhancements in the issue description (for tracking purpose)? I wasn't able to identify any related recent PRs on the Kubernetes/Kubernetes repository. Thank you so much!

Priyankasaggu11929 commented 2 years ago

Hello @andyzhangx, just checking in one more time as we are 2 days from the 1.24 code freeze.

Could you confirm if there are any k/k PRs tracking the code implementation for this KEP? Thank you!

andyzhangx commented 2 years ago

Hello @andyzhangx, just checking in one more time as we are 2 days from the 1.24 code freeze.

Could you confirm if there are any k/k PRs tracking the code implementation for this KEP? Thank you!

@Priyankasaggu11929 there is no pending k/k PRs related to this KEP, thanks.

Priyankasaggu11929 commented 2 years ago

@Priyankasaggu11929 there is no pending k/k PRs related to this KEP, thanks. With no k/k PRs pending for 1.24 milestone, I'm moving the status for this enhancement to tracked. Thank you!

xing-yang commented 2 years ago

/milestone v1.25

Atharva-Shinde commented 2 years ago

Hello @andyzhangx 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage stable for 1.25 release

Here's where this enhancement currently stands:

Referring to above conversations I have noted that the graduation criteria and test-plan is inherited by this parent KEP (correct me if thats not true)

So it looks like for this one, we would need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

andyzhangx commented 2 years ago

we are targeting CSI migration GA on 1.25, here is the k/k PR: https://github.com/kubernetes/kubernetes/pull/110458

xing-yang commented 2 years ago

Moving to 1.26 per comment here: https://github.com/kubernetes/kubernetes/pull/110458#issuecomment-1151110509

Priyankasaggu11929 commented 2 years ago

Thanks for the clarification ^ @xing-yang. 👍

Atharva-Shinde commented 2 years ago

Hey @andyzhangx @xing-yang 👋 Just for note: Enhancements Freeze is now extended to next week till Thursday June 23, 2022 🚀 So we now have one more week :)

xing-yang commented 2 years ago

Thanks @Atharva-Shinde! We are still targeting GA in 1.26.

andyzhangx commented 1 year ago

I have set Stable release target 1.26

rhockenbury commented 1 year ago

Hello @andyzhangx 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

rhockenbury commented 1 year ago

With #3360 merged, this enhancement is now tracked for the v1.26 cycle. Thanks!

rhockenbury commented 1 year ago

Hi @andyzhangx 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

For this enhancement, it looks like we'll need a PR to graduate this feature to stable.

As always, we are here to help should questions come up. Thanks!

katmutua commented 1 year ago

Hello @andyzhangx ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. As a reminder, please link all of your docs PR to this issue so we can easily track it.