search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Support to size memory backed volumes #1967

Open derekwaynecarr opened 4 years ago

derekwaynecarr commented 4 years ago

Enhancement Description

derekwaynecarr commented 4 years ago

/sig node

kikisdeliveryservice commented 4 years ago

Hi @derekwaynecarr !

Enhancements Lead here. You've seemed have linked a PR instead of your KEP (https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1967-size-memory-backed-volumes) I've updated the description to fix.

kikisdeliveryservice commented 4 years ago

Related PR https://github.com/kubernetes/kubernetes/pull/94444

MorrisLaw commented 4 years ago

Hey @derekwaynecarr ,

Another friendly reminder that since this Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates: Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline Thursday, Nov 12th: Week 9 - Code Freeze

Also, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you, Jeremy

annajung commented 3 years ago

Hello @derekwaynecarr 👋 , 1.20 Docs lead here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

annajung commented 3 years ago

Hi @derekwaynecarr

The docs placeholder deadline is this Friday. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

MorrisLaw commented 3 years ago

Hi @derekwaynecarr

Just a friendly reminder the code freeze deadline is this Thursday. Please make sure to have any code merged in before the deadline.

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

kikisdeliveryservice commented 3 years ago

Double checked with Derek and this is completed for code freeze.

derekwaynecarr commented 3 years ago

/milestone v1.21

mvortizr commented 3 years ago

/assign

arunmk commented 3 years ago

Hi @derekwaynecarr, @mvortizr,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

arunmk commented 3 years ago

Hi @derekwaynecarr @mvortizr ,

Enhancements team does not have a linked PR to track for the upcoming code freeze. Could you please link a PR to this KEP so that we may track it.

We are currently marking this KEP as 'At Risk' for the upcoming code freeze on 3/9.

Thanks

arunmk commented 3 years ago

Hi @derekwaynecarr @mvortizr ,

A friendly reminder that Code freeze is 4 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

annajung commented 3 years ago

Hi @derekwaynecarr, with code freeze now in effect, we are removing this enhancement from 1.21 release due to no code PR being tracked for this enhancement.

If needed, feel free to file an exception to add this back into the release. thanks!

ehashman commented 3 years ago

/milestone v1.22

pacoxu commented 3 years ago

Per KEP, the Graduation Criteria from Alpha to Beta Graduation includes

Per https://github.com/kubernetes/kubernetes/pull/100319

E2E testing was already defined and had coverage here: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/storage/empty_dir.go#L298

As kubernetes/kubernetes#101048 1.22 is done to promote SizeMemoryBackedVolumeSizing to beta, is there anything to do in this cycle 1.22?

ehashman commented 3 years ago

@pacoxu nope, this one just slipped. The doc update got held.

jrsapi commented 3 years ago

Greetings @derekwaynecarr @mvortizr! Enhancement shadow checking in. After reviewing the KEP, there are a few things that need to be complete before the 1.22 Enhancements Freeze, which is this Thursday, 5/13.

Thanks!

jrsapi commented 3 years ago

Greetings @derekwaynecarr @mvortizr! After re-reviewing the KEP and approved PRR, this enhancement is now being tracked for the v1.22 milestone.

Thanks!

ehashman commented 3 years ago

Let me revive https://github.com/kubernetes/website/pull/27086 and then this will be complete for 1.22.

jrsapi commented 3 years ago

Greetings @derekwaynecarr , Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you confirm if the following k/k PR is all that is needed for the implementation of this enhancement for the 1.22 milestone?

Thanks!

jrsapi commented 3 years ago

Greetings @derekwaynecarr, A #reminder that code freeze is this Thursday, July 7th and Docs placeholder PR deadline is this Friday, July 8th. This is to update you that with kubernetes/kubernetes/101048 merged and k/website PR kubernetes/website/27990 in place. This KEP is marked "Tracked" for the 1.22 milestone.

ehashman commented 3 years ago

@jrsapi it seems that my PR for the docs was made redundant, @tengqm already made the changes. No remaining work for beta.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1967#issuecomment-1013967459): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pacoxu commented 1 year ago

/reopen

@derekwaynecarr this feature is beta since 1.22 and do we have a plan to make it GA

When I look into ci-crio-cgroupv1-node-e2e-eviction, there are some test cases around feature gate SizeMemoryBackedVolumes.

k8s-ci-robot commented 1 year ago

@pacoxu: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1967#issuecomment-1582003320): >/reopen > >@derekwaynecarr this feature is beta since 1.22 and do we have a plan to make it GA > >When I look into `ci-crio-cgroupv1-node-e2e-eviction`, there are some test cases around feature gate SizeMemoryBackedVolumes. > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/1967#issuecomment-1626898725): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SergeyKanzhelev commented 1 year ago

/reopen

Still need to GA

k8s-ci-robot commented 1 year ago

@SergeyKanzhelev: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/1967#issuecomment-1671833818): >/reopen > >Still need to GA Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pacoxu commented 1 year ago

/remove-lifecycle rotten

The feature has been in beta since 1.22. @SergeyKanzhelev can we add this to v1.29 release cycle to promote it to GA? Is there any pending bug reported?

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

2rs2ts commented 7 months ago

/remove-lifecycle rotten

Just curious, why is it taking so long to graduate from beta to GA? Technical issues like this one? https://github.com/kubernetes/kubernetes/issues/119611

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

2rs2ts commented 4 months ago

/remove-lifecycle stale

thockin commented 3 months ago

This gate has been Beta since 1.22 - is there any reason not to just set it to GA? Seems like something any contributor can do to score some brownie points, and since it has been beta so long, I doubt we can change any behavior, even if we want to?

kannon92 commented 1 month ago

I agree with @thockin.

/assign

I opened up https://github.com/kubernetes/enhancements/pull/4812 to get this conversation started.

haircommander commented 3 weeks ago

/milestone v1.32 /label lead-opted-in

kannon92 commented 3 weeks ago

/tracked yes

kannon92 commented 3 weeks ago

/stage stable

kannon92 commented 3 weeks ago

/assign

Going to take this to stable in 1.32.

kannon92 commented 3 weeks ago

Opened up https://github.com/kubernetes/enhancements/pull/4812.

dipesh-rawat commented 2 weeks ago

Hello @kannon92 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

It looks like https://github.com/kubernetes/enhancements/pull/4812 will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

sohankunkerkar commented 1 week ago

@kannon92 could you address this comment and prepare https://github.com/kubernetes/enhancements/pull/4812 for the PRR review?

kannon92 commented 2 days ago

@kannon92 could you address this comment and prepare #4812 for the PRR review?

I addressed these comments and PRR reviewing is ongoing.

kannon92 commented 2 days ago

I also opened up https://github.com/kubernetes/website/pull/48254 to reflect the website changes.