search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Support for Windows privileged containers #1981

Closed ambguo closed 1 year ago

ambguo commented 4 years ago

Enhancement Description

ambguo commented 4 years ago

/sig windows

ambguo commented 4 years ago

/sig node

ambguo commented 4 years ago

/kind feature

ambguo commented 4 years ago

/stage alpha /milestone v1.20

k8s-ci-robot commented 4 years ago

@ambguo: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/1981#issuecomment-691208958): >/stage alpha >/milestone v1.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
immuzz commented 4 years ago

/stage alpha /milestone v1.20

k8s-ci-robot commented 4 years ago

@immuzz: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/1981#issuecomment-691209178): >/stage alpha >/milestone v1.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
immuzz commented 4 years ago

cc: @marosset @michmike @ddebroy @jsturtevant

kikisdeliveryservice commented 4 years ago

Hi all,

Enhancements Lead here. Will just update the milestone for you :smile:

Best, Kirsten

kikisdeliveryservice commented 4 years ago

Just as a note when you convert your KEP don't forget to also include the kep.yaml

Both templates that you will need can be found here: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Please also update the description when you make the PR and please link any other PRs so that this enhancement can be tracked to the milestone.

Hope that helps.

Best, Kirsten

kinarashah commented 4 years ago

Hi @ambguo,

Enhancement shadow for 1.20 release here 👋.

Just wanted to check if you had a chance to convert KEP according to the template posted above (https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template).

Please note that the Enhancement freeze deadline for KEPs to be included in 1.20 milestone is Tuesday, October 6.

Your proposal looks great 😄, could you please include the following when you make the KEP PR:

Thank you!

kinarashah commented 4 years ago

Thank you @ambguo for actively working on the KEP PR!

Here's the status update based on the freeze requirements:

Requirement Status Comments
Test Plan ❗ missing test plans for alpha
Graduation Criteria ❗ confirm milestone to 1.20 for alpha here. Beta's set to 1.20+.
Implementable State ❗ add KEP yaml with state implementable as mentioned here. If you're looking for an example, hopefully this recently merged sig node kep yaml gives you an idea.
Merged ❗

Just a friendly reminder that we'd need all of them with ✅ status to be included in 1.20 milestone by Enhancement Freeze deadline Tuesday, October 6.

Ping me anytime on slack (kinarashah) or here if you have any questions 😄.

Thank you!!

kinarashah commented 4 years ago

/milestone v1.21

k8s-ci-robot commented 4 years ago

@kinarashah: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/1981#issuecomment-702874791): >/milestone v1.21 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kinarashah commented 4 years ago

Spoke with @marosset and @ambguo, this will be tracked alpha for 1.21 milestone and KEP PR would be merged in provisional status for now.

michmike commented 4 years ago

@marosset i thought we are doing privileged containers as alpha for v1.20, not 1.21

ambguo commented 4 years ago

@michmike from our discussion on Tuesday, we are looking into ways to address the pod networking issues mentioned. We are still investigating ways to address the challenges, so will not be able to pursue the alpha release in 1.20 since APIs may require changes depending on the solution.

craiglpeters commented 3 years ago

@ambguo can you please update the description on this issue to point to the KEP, rather than the draft in Gdocs?

ambguo commented 3 years ago

/assign @marosset

marosset commented 3 years ago

This pull request adds the required functionality to start Windows privileged containers / Job object containers to hcsshim https://github.com/microsoft/hcsshim/pull/903

kendallroden commented 3 years ago

Hey @marosset , 1.21 Enhancements Shadow here! Please ensure the following are completed prior to the Code Freeze on Tuesday, Feb 9th:

There are a few 1.20 references that I believe can be updated to reflect the shift to targeting 1.21 for alpha (i.e. latest-milestone in kep.yaml, alpha graduation criteria) In order to avoid filing an exception, the following changes need to be merged by EOD on Feb 9th.

If you have any questions please feel free to reach out here or via slack!

Thank you!

annajung commented 3 years ago

Hi @marosset, 1.21 Enhancements Lead here

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR https://github.com/kubernetes/enhancements/pull/2288). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

marosset commented 3 years ago

@annajung is the test plan outlined in updated added PR #2288 sufficient here?

annajung commented 3 years ago

Yes, once the PR merges in, it will meet all requirements needed for the enhancements freeze.

marosset commented 3 years ago

Yes, once the PR merges in, it will meet all requirements needed for the enhancements freeze.

Thanks for confirming!

annajung commented 3 years ago

Hi @marosset,

Enhancements Freeze is now in effect.

Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

jayunit100 commented 3 years ago

are we submitting an exception here?

lippertmarkus commented 3 years ago

@jayunit100 yes, see https://groups.google.com/g/kubernetes-sig-windows/c/eY4cuTsOEa4?pli=1

mvortizr commented 3 years ago

/milestone v1.21

k8s-ci-robot commented 3 years ago

@mvortizr: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/1981#issuecomment-782544730): >/milestone v1.21 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mvortizr commented 3 years ago

/assign

kendallroden commented 3 years ago

Hi @ambguo , Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

Thanks!

marosset commented 3 years ago

@kendallroden ambguo is no longer working on the project. I'll be primary point of contact here.

Also, previously I used to be able to edit the original message in the thread to link PRs there (I think this was restricted to milestone-maintainers which I am part of). Do you know if anything changed here?

annajung commented 3 years ago

Hey @marosset, all members of milestone-maintainers used to have write access to k/enhancements repo but recently have been downgraded to triage access. Therefore, members of that group no longer have access to edit the description of any issues unless it's your own.

I followed up on this in #sig-release channel to clarify the role and to see if there is a way to give SIG Leads write access. I'll tag you there and we can continue the conversation there.

annajung commented 3 years ago

Hi @marosset, with code freeze now in effect, we are removing this enhancement from 1.21 release due to https://github.com/kubernetes/kubernetes/pull/99576 not being merged or approved.

Feel free to file an exception to add this back into the release. thanks!

marosset commented 3 years ago

/milestone v1.22

marosset commented 3 years ago

@annajung / @kendallnelson since the KEP for this was approved for an alpha implementation in v1.21 but the implementation PRs didn't get merged in time can we start tracking this for v1.22?

annajung commented 3 years ago

Hi @marosset, once you opt-in to the 1.22 tracking sheet @JamesLaverack will mark this as tracked for the 1.22. Then, you would just need to make sure KEP has been updated to reflect 1.22 and that it still meets all the criteria required before the enhancements freeze. hope this helps!

marosset commented 3 years ago

Thanks @annajung! https://github.com/kubernetes/enhancements/pull/2659 updates the KEP to reflect 1.22

salaxander commented 3 years ago

Hi @marosset , 1.22 enhancements team here

For the enhancement to be included in the milestone, it must meet the following criteria:

[DONE] The KEP must be merged in an implementable state [DONE] The KEP must have test plans [DONE] The KEP must have graduation criteria [DONE] The KEP must have a production readiness review

Looks like we're in good shape! Let us know if there's anything we can do to help in preparation for enhancements freeze on 5/13.

Thanks!!

PI-Victor commented 3 years ago

Hello @marosset 👋, 1.22 Docs release lead here. This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.


Thank you!

p.s.: Please remember to add WindowsHostProcessContainers to feature gates table to reflect this change.

brasmith-ms commented 3 years ago

Hi @PI-Victor, a draft PR against dev-1.22 has been created in the k/website repo with the feature gate table update as a placeholder. We'll be adding in more documentation this month.

https://github.com/kubernetes/website/pull/28413

salaxander commented 3 years ago

Hi @marosset - Just checking in as we're about 2 weeks away from code freeze. Looks like we're all set with https://github.com/kubernetes/kubernetes/pull/99576 merged, but let me know if there are any other open or merged k/k PRs we should be tracking. Thanks!!

marosset commented 3 years ago

Hi @salaxander - I'm just returning to work today after ~2 months off. @jsturtevant / @jayunit100 are we all set with this enhancement for a v1.22 alpha release?

thanks!

jsturtevant commented 3 years ago

We have a test running at https://testgrid.k8s.io/sig-windows-master-release#ci-kubernetes-e2e-aks-engine-azure-master-windows-containerd-hostprocess-alpha

There is one PR we are tracking as a bug fix for hostprocess containers: https://github.com/kubernetes/kubernetes/pull/103434

salaxander commented 3 years ago

Hi @jsturtevant - I'll add #103434 to our tracking. It'll need to merge before code freeze tomorrow evening (PST), I'll keep an eye out :)

jsturtevant commented 3 years ago

@salaxander I thought since it is a bug fix we would have till test freeze? Fyi @perithompson

salaxander commented 3 years ago

Oh I may be mistaken on that! I'll double check - CC @JamesLaverack

JamesLaverack commented 3 years ago

Hey @jsturtevant, 1.22 Enhancements Lead here. I'm afraid that https://github.com/kubernetes/kubernetes/pull/103434 must be approved by code freeze, not test freeze. Test freeze, as defined in the release documentation, is for changes to tests only.

jsturtevant commented 3 years ago

Docs PR: https://github.com/kubernetes/website/pull/28413