search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

CronJobs (previously ScheduledJobs) #19

Closed soltysh closed 2 years ago

soltysh commented 8 years ago

Enhancement Description

soltysh commented 6 years ago

For the 1.10 milestone there are 3 topics:

  1. TimeZone support in CronJob (https://github.com/kubernetes/kubernetes/pull/47266) - @iterion see this comment for reasoning why
  2. CronJob manual instantiation (https://github.com/kubernetes/kubernetes/pull/53988) - @erhudy
  3. (?) Re-write the controller to use shared informers (https://github.com/kubernetes/kubernetes/issues/17130) - @soltysh
idvoretskyi commented 6 years ago

@soltysh and still beta, right?

soltysh commented 6 years ago

Stable requirements:

  1. Shared informers in the controller (https://github.com/kubernetes/kubernetes/issues/17130)
  2. Support different time formats (ISO 8601, GCE time format).
Bradamant3 commented 6 years ago

@soltysh feature tracking spreadsheet indicates doc updates are needed. Is this indeed the case? If so, please get your PR in asap (today is doc deadline, but I haven't been good about notifying folks). If not, could you please update the spreadsheet? Thanks!

Bradamant3 commented 6 years ago

@soltysh docs ping -- deadline for merging docs PRs is this Friday, March 9. See previous comment. Thanks! /cc @idvoretskyi

soltysh commented 6 years ago

@Bradamant3 sorry for the delay, no doc update is needed for this feature. I've added a comment in the linked spreadsheet.

justaugustus commented 6 years ago

@soltysh Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

cc @idvoretskyi

soltysh commented 6 years ago

Any plans for this in 1.11?

Controller re-write to satisfy https://github.com/kubernetes/kubernetes/issues/17130 but I'm still struggling with time. So this is more of a wishful thinking than actual plans :wink:

justaugustus commented 6 years ago

Okay cool. I'm going to push the milestone on this.

spiffxp commented 6 years ago

any update on plans to bring this to stable? I'm assuming based on lack of milestone this isn't going to happen for 1.12?

justaugustus commented 6 years ago

any update on plans to bring this to stable? I'm assuming based on lack of milestone this isn't going to happen for 1.12?

@soltysh ^^

justaugustus commented 6 years ago

@spiffxp -- I spoke with @soltysh earlier. Nothing planned for 1.12.

kacole2 commented 6 years ago

Hi This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

soltysh commented 6 years ago

@kacole2 this is not moving anywhere until we fix the biggest issue with cronjob controller, which is shared informers. We'll be discussing this topic during next SIG-Apps call.

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

wadadli commented 5 years ago

How about a prefix to jobs such as 20190212T2157Z

mattfarina commented 5 years ago

/remove-lifecycle rotten

mattfarina commented 5 years ago

/lifecycle frozen

fejta-bot commented 5 years ago

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen. Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

kacole2 commented 5 years ago

Hello @soltysh , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. As usual, a KEP will need to be merged before this can progress.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

kfox1111 commented 5 years ago

As a user, I've been successfully using this resource kind for a long time now. I have not seen any major problems with the api. Is it time to ship it as GA?

kow3ns commented 5 years ago

We are working on a KEP for graduation

kfox1111 commented 5 years ago

Ok. Thanks for the update.

kacole2 commented 5 years ago

Hi @kow3ns @soltysh , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

palnabarun commented 5 years ago

Hey there @soltysh @kow3ns , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

palnabarun commented 4 years ago

Hey there @soltysh @kow3ns ,

1.18 Enhancements team member here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.18? Enhancements are going to be frozen on January 28.

If you do, I'll add it to the 1.18 tracking sheet (https://bit.ly/k8s-1-18-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. :+1:

Thanks!

palnabarun commented 4 years ago

The current release schedule is:

soltysh commented 4 years ago

Hey @palnabarun @barney-s is working on closing the KEP in time, the implementation will proceed.

palnabarun commented 4 years ago

Thanks, @soltysh for the updates. I'm guessing the enhancement is targeted to be stable for the release. I am updating the same in the tracking sheet. Please let me know if it is otherwise.

palnabarun commented 4 years ago

/stage stable

palnabarun commented 4 years ago

/milestone v1.18

palnabarun commented 4 years ago

@barney-s Just a friendly reminder, we are just 7 days away from the Enhancement Freeze (Tuesday, January 28th).

Do you have any updates on the KEP?

jeremyrickard commented 4 years ago

Per @mattfarina on Slack, this won't be graduating to stable in 1.18. I'm going to remove it from the 1.18 milestone and drop it from the release tracking sheet.

palnabarun commented 4 years ago

KEP PR: https://github.com/kubernetes/enhancements/pull/978

jeremyrickard commented 4 years ago

/milestone clear

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

harshanarayana commented 4 years ago

Hey there @soltysh @kow3ns, 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

harshanarayana commented 4 years ago

Hey @soltysh / @kow3ns, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

harshanarayana commented 4 years ago

Hey @soltysh / @kow3ns, I'm following up on my previous update on this Enhancement being part of the v1.19 release.

Do you happen to have any update on the possiblity of this being included in the release v1.19?

Thanks again for your time and contributions. 🖖

harshanarayana commented 4 years ago

Hey @soltysh / @kow3ns, any plans for the Enhancements to be included in v1.19? Please let me know so that I can update the tracking sheet to show the inclusion state.

Enhancements freeze is on May 19

Note that recently the KEP format has changed. Additionally, #1620 merged recently, adding production readiness review questions to the KEP template. Please take this opportunity to reformat your KEP and also answer the questions added to the template in that PR.

Thanks, 🖖

harshanarayana commented 4 years ago

Hey @soltysh / @kow3ns, Unfortunately the deadline for the 1.19 Enhancement freeze has passed and the KEP #978 is still in flight. For now this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

soltysh commented 4 years ago

/lifecycle frozen

fejta-bot commented 4 years ago

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen. Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

kikisdeliveryservice commented 4 years ago

/lifecycle frozen

Hi @soltysh

Enhancements Lead here. Any plans for this in 1.20?

Thanks, Kirsten

soltysh commented 4 years ago

@kikisdeliveryservice yes, we are planning on moving this slowly, see https://github.com/kubernetes/enhancements/pull/1996 for proposal, so 1.20 is when we'll be introducing the new controller as alpha. I've just updated the initial description with all the proper links and to match the current template.