search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.35k stars 1.44k forks source link

Random Pod selection on ReplicaSet downscaling #2185

Open alculquicondor opened 3 years ago

alculquicondor commented 3 years ago

Enhancement Description

alculquicondor commented 3 years ago

/sig apps /sig scheduling

alculquicondor commented 3 years ago

cc @damemi

damemi commented 3 years ago

/assign

damemi commented 3 years ago

Haven't fogotten about this, just didn't get it in time for the new year... will open a PR soon based on @alculquicondor's draft

damemi commented 3 years ago

Filled out most of the sections and opened a KEP here: https://github.com/kubernetes/enhancements/pull/2233

Looking for anything I missed or could improve on. Pretty straightforward mostly since it's not affecting a user-documented behavior

jrsapi commented 3 years ago

Greetings @damemi! Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates: • Tuesday, March 9th: Week 9 - Code Freeze • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo. As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them. Thanks!

damemi commented 3 years ago

xref - wip PR https://github.com/kubernetes/kubernetes/pull/96898

I'll be picking up this PR and working to get that merged for code freeze. Thanks for the update @jrsapi !

damemi commented 3 years ago

Opened new PR in https://github.com/kubernetes/kubernetes/pull/99212

jrsapi commented 3 years ago

Greetings @damemi,

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST Any enhancements that are NOT code complete by the freeze will be removed from the milestone will require an exception to be added back. Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST. Thanks!

alculquicondor commented 3 years ago

Should we consider any updates to documentation for this? https://kubernetes.io/docs/concepts/workloads/controllers/replicaset/#scaling-a-replicaset

Current documentation doesn't give any details about internal selection, which might still be desired.

@janetkuo @soltysh

janetkuo commented 3 years ago

Yes, please update docs and the feature gate for this.

PI-Victor commented 3 years ago

Hello @damemi, 1.21 Docs shadow here. Does this enhancement work planned for 1.21 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

damemi commented 3 years ago

Yeah, I will open a PR to update the docs Aldo linked above

damemi commented 3 years ago

Docs PR opened at https://github.com/kubernetes/website/pull/26993, which just copies the comments from code into the docs

ahg-g commented 3 years ago

@alculquicondor can you update the description checklist?

@damemi do you plan on submitting a KEP update to graduate the feature to Beta?

alculquicondor commented 3 years ago

Updated alpha links

damemi commented 3 years ago

@ahg-g yes, I'll update the KEP with what's necessary for Beta graduation

reylejano commented 3 years ago

Hi @damemi ,

1.22 release team here. After reviewing the kep there are a few things that need to be complete before the 1.22 Enhancements Freeze which starts at 23:59:59 pst on Thursday, May 13:

damemi commented 3 years ago

@reylejano thanks for the update, we have a PR to update the KEP that is currently undergoing review at https://github.com/kubernetes/enhancements/pull/2691 to make the changes you have listed. This should be able to make the enhancements freeze

reylejano commented 3 years ago

Hi @damemi , I see that sig scheduling is a participating sig for this enhancement. Does sig scheduling need to do anything for this enhancement for the 1.22 release?

alculquicondor commented 3 years ago

sig-scheduling, in particular @damemi and me, proposed the change. But there's no AI on sig-scheduling.

reylejano commented 3 years ago

Hi @damemi, With the merge of PR 2691, this enhancement is all set for the 1.22 Enhancements Freeze 🎉 Thank you!

chrisnegus commented 3 years ago

Hi @damemi ! I'm @chrisnegus , a Docs Shadow for release 1.22. This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

damemi commented 3 years ago

Hi @chrisnegus, I opened the placeholder PR here: https://github.com/kubernetes/website/pull/28102 Besides the status change from Alpha to Beta, I think the only other user-facing change for this release will be a KCM metric we planned to add (from the discussion in https://github.com/kubernetes/enhancements/pull/2691). Do those get documented as well?

reylejano commented 3 years ago

Hi @dememi,

With about 2 weeks until code freeze (July 8, 2021), Can you confirm if the following k/k PR is all that is needed for the implementation of this enhancement for the 1.22 release?

damemi commented 3 years ago

@reylejano yes, that and the docs PR (https://github.com/kubernetes/website/pull/28102) are all that is needed for this. Thanks!

reylejano commented 3 years ago

Hi @damemi ,

Just a reminder that the 1.22 code freeze starts next week on July 8, 2021. We're tracking https://github.com/kubernetes/kubernetes/pull/101767 for 1.22. Looks like you're set for the 1.22 Docs Placeholder PR deadline (July 9, 2021) with https://github.com/kubernetes/website/pull/28102

reylejano commented 3 years ago

Hi @damemi ,

The 1.22 code freeze starts in a few days on Thursday, July 8 at 18:00 PDT. The following PR and any other PR required for this enhancement for 1.22 has to merge by then:

This enhancement is currently at-risk of falling out of 1.22 with kubernetes/kubernetes#101767 open

damemi commented 3 years ago

@reylejano that PR was tagged for merge this morning and should have no issues making it in by Thursday 🙂

reylejano commented 3 years ago

Hi @damemi ,

This enhancement is all set for the 1.22 code freeze 🎉

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

alculquicondor commented 2 years ago

/remove-lifecycle stale

should be ready for GA in 1.24

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2185#issuecomment-1105619070): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
damemi commented 2 years ago

@alculquicondor did this ever move to GA?

alculquicondor commented 2 years ago

/reopen

No, still beta

k8s-ci-robot commented 2 years ago

@alculquicondor: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2185#issuecomment-1116455506): >/reopen > >No, still beta Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
janetkuo commented 2 years ago

I removed 1.23 from Stable release target (x.y) in the issue description to avoid confusion.

soltysh commented 2 years ago

/milestone clear since you can always check the latest-milestone in https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/kep.yaml

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2185#issuecomment-1179220289): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
soltysh commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@soltysh: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2185#issuecomment-1456531909): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/2185#issuecomment-1497887480): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xuzhenglun commented 4 months ago

is any plan to GA this enhancement?

alculquicondor commented 4 months ago

/reopen This is open for contributors

k8s-ci-robot commented 4 months ago

@alculquicondor: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2185#issuecomment-2007376728): >/reopen >This is open for contributors Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.