go test -v failed , different error msg

shekhar-rajak commented 3 years ago

(Part of https://github.com/kubernetes/enhancements/issues/2348.)

I am getting different error msg each time I run go test -v in pkg

=== RUN   TestWriteKep
=== RUN   TestWriteKep/simple_kep
    TestWriteKep/simple_kep: create_test.go:149: Writing kep.yaml to /tmp/704987220/enhancements/keps/NNNN-kep-template/kep.yaml
    TestWriteKep/simple_kep: create_test.go:149: Writing README.md to /tmp/704987220/enhancements/keps/NNNN-kep-template/README.md
    TestWriteKep/simple_kep: create_test.go:75: cleanup!
=== RUN   TestWriteKep/opts_repo_path_works
    TestWriteKep/opts_repo_path_works: create_test.go:149: Writing kep.yaml to /tmp/736162211/enhancementz/keps/NNNN-kep-template/kep.yaml
    TestWriteKep/opts_repo_path_works: create_test.go:149: Writing README.md to /tmp/736162211/enhancementz/keps/NNNN-kep-template/README.md
    TestWriteKep/opts_repo_path_works: create_test.go:75: cleanup!
--- PASS: TestWriteKep (0.01s)
    --- PASS: TestWriteKep/simple_kep (0.00s)
    --- PASS: TestWriteKep/opts_repo_path_works (0.00s)
=== RUN   TestValidate
=== RUN   TestValidate/valid_kep_passes_valdiate
=== RUN   TestValidate/invalid_kep_fails_valdiate_for_owning-sig
    TestValidate/invalid_kep_fails_valdiate_for_owning-sig: kepctl_test.go:59: 
            Error Trace:    kepctl_test.go:59
            Error:          Error message not equal:
                            expected: "kep is invalid: error validating KEP metadata: \"owning-sig\" must be one of (committee-code-of-conduct,committee-product-security,committee-steering,sig-api-machinery,sig-apps,sig-architecture,sig-auth,sig-autoscaling,sig-cli,sig-cloud-provider,sig-cluster-lifecycle,sig-contributor-experience,sig-docs,sig-instrumentation,sig-multicluster,sig-network,sig-node,sig-release,sig-scalability,sig-scheduling,sig-security,sig-service-catalog,sig-storage,sig-testing,sig-ui,sig-usability,sig-windows,ug-big-data,ug-vmware-users,wg-api-expression,wg-component-standard,wg-data-protection,wg-iot-edge,wg-k8s-infra,wg-lts,wg-multitenancy,wg-naming,wg-policy,wg-security-audit) but it is a string: sig-awesome"
                            actual  : "kep is invalid: error validating KEP metadata: \"beta\" must be a milestone but it is a string: "
            Test:           TestValidate/invalid_kep_fails_valdiate_for_owning-sig
--- FAIL: TestValidate (0.00s)
    --- PASS: TestValidate/valid_kep_passes_valdiate (0.00s)
    --- FAIL: TestValidate/invalid_kep_fails_valdiate_for_owning-sig (0.00s)
=== RUN   TestFindLocalKEPs
--- PASS: TestFindLocalKEPs (0.00s)
FAIL
exit status 1
FAIL    k8s.io/enhancements/pkg/kepctl  1.657s

$ sudo go test -v
=== RUN   TestWriteKep
=== RUN   TestWriteKep/simple_kep
    TestWriteKep/simple_kep: create_test.go:149: Writing kep.yaml to /tmp/881905900/enhancements/keps/NNNN-kep-template/kep.yaml
    TestWriteKep/simple_kep: create_test.go:149: Writing README.md to /tmp/881905900/enhancements/keps/NNNN-kep-template/README.md
    TestWriteKep/simple_kep: create_test.go:75: cleanup!
=== RUN   TestWriteKep/opts_repo_path_works
    TestWriteKep/opts_repo_path_works: create_test.go:149: Writing kep.yaml to /tmp/869338971/enhancementz/keps/NNNN-kep-template/kep.yaml
    TestWriteKep/opts_repo_path_works: create_test.go:149: Writing README.md to /tmp/869338971/enhancementz/keps/NNNN-kep-template/README.md
    TestWriteKep/opts_repo_path_works: create_test.go:75: cleanup!
--- PASS: TestWriteKep (0.00s)
    --- PASS: TestWriteKep/simple_kep (0.00s)
    --- PASS: TestWriteKep/opts_repo_path_works (0.00s)
=== RUN   TestValidate
=== RUN   TestValidate/valid_kep_passes_valdiate
=== RUN   TestValidate/invalid_kep_fails_valdiate_for_owning-sig
    TestValidate/invalid_kep_fails_valdiate_for_owning-sig: kepctl_test.go:59: 
            Error Trace:    kepctl_test.go:59
            Error:          Error message not equal:
                            expected: "kep is invalid: error validating KEP metadata: \"owning-sig\" must be one of (committee-code-of-conduct,committee-product-security,committee-steering,sig-api-machinery,sig-apps,sig-architecture,sig-auth,sig-autoscaling,sig-cli,sig-cloud-provider,sig-cluster-lifecycle,sig-contributor-experience,sig-docs,sig-instrumentation,sig-multicluster,sig-network,sig-node,sig-release,sig-scalability,sig-scheduling,sig-security,sig-service-catalog,sig-storage,sig-testing,sig-ui,sig-usability,sig-windows,ug-big-data,ug-vmware-users,wg-api-expression,wg-component-standard,wg-data-protection,wg-iot-edge,wg-k8s-infra,wg-lts,wg-multitenancy,wg-naming,wg-policy,wg-security-audit) but it is a string: sig-awesome"
                            actual  : "kep is invalid: error validating KEP metadata: \"alpha\" must be a milestone but it is a string: "
            Test:           TestValidate/invalid_kep_fails_valdiate_for_owning-sig
--- FAIL: TestValidate (0.00s)
    --- PASS: TestValidate/valid_kep_passes_valdiate (0.00s)
    --- FAIL: TestValidate/invalid_kep_fails_valdiate_for_owning-sig (0.00s)
=== RUN   TestFindLocalKEPs
--- PASS: TestFindLocalKEPs (0.00s)
FAIL
exit status 1
FAIL    k8s.io/enhancements/pkg/kepctl  1.153s

$ sudo go test -v
=== RUN   TestWriteKep
=== RUN   TestWriteKep/simple_kep
    TestWriteKep/simple_kep: create_test.go:149: Writing kep.yaml to /tmp/531257763/enhancements/keps/NNNN-kep-template/kep.yaml
    TestWriteKep/simple_kep: create_test.go:149: Writing README.md to /tmp/531257763/enhancements/keps/NNNN-kep-template/README.md
    TestWriteKep/simple_kep: create_test.go:75: cleanup!
=== RUN   TestWriteKep/opts_repo_path_works
    TestWriteKep/opts_repo_path_works: create_test.go:149: Writing kep.yaml to /tmp/233822886/enhancementz/keps/NNNN-kep-template/kep.yaml
    TestWriteKep/opts_repo_path_works: create_test.go:149: Writing README.md to /tmp/233822886/enhancementz/keps/NNNN-kep-template/README.md
    TestWriteKep/opts_repo_path_works: create_test.go:75: cleanup!
--- PASS: TestWriteKep (0.01s)
    --- PASS: TestWriteKep/simple_kep (0.00s)
    --- PASS: TestWriteKep/opts_repo_path_works (0.00s)
=== RUN   TestValidate
=== RUN   TestValidate/valid_kep_passes_valdiate
=== RUN   TestValidate/invalid_kep_fails_valdiate_for_owning-sig
    TestValidate/invalid_kep_fails_valdiate_for_owning-sig: kepctl_test.go:59: 
            Error Trace:    kepctl_test.go:59
            Error:          Error message not equal:
                            expected: "kep is invalid: error validating KEP metadata: \"owning-sig\" must be one of (committee-code-of-conduct,committee-product-security,committee-steering,sig-api-machinery,sig-apps,sig-architecture,sig-auth,sig-autoscaling,sig-cli,sig-cloud-provider,sig-cluster-lifecycle,sig-contributor-experience,sig-docs,sig-instrumentation,sig-multicluster,sig-network,sig-node,sig-release,sig-scalability,sig-scheduling,sig-security,sig-service-catalog,sig-storage,sig-testing,sig-ui,sig-usability,sig-windows,ug-big-data,ug-vmware-users,wg-api-expression,wg-component-standard,wg-data-protection,wg-iot-edge,wg-k8s-infra,wg-lts,wg-multitenancy,wg-naming,wg-policy,wg-security-audit) but it is a string: sig-awesome"
                            actual  : "kep is invalid: error validating KEP metadata: \"owning-sig\" must be one of (committee-code-of-conduct,committee-product-security,committee-steering,sig-api-machinery,sig-apps,sig-architecture,sig-auth,sig-autoscaling,sig-cli,sig-cloud-provider,sig-cluster-lifecycle,sig-contributor-experience,sig-docs,sig-instrumentation,sig-multicluster,sig-network,sig-node,sig-release,sig-scalability,sig-scheduling,sig-security,sig-service-catalog,sig-storage,sig-testing,sig-ui,sig-usability,sig-windows,ug-big-data,ug-vmware-users,wg-api-expression,wg-component-standard,wg-data-protection,wg-iot-edge,wg-k8s-infra,wg-multitenancy,wg-naming,wg-policy,wg-reliability) but it is a string: sig-awesome"
            Test:           TestValidate/invalid_kep_fails_valdiate_for_owning-sig
--- FAIL: TestValidate (0.00s)
    --- PASS: TestValidate/valid_kep_passes_valdiate (0.00s)
    --- FAIL: TestValidate/invalid_kep_fails_valdiate_for_owning-sig (0.00s)
=== RUN   TestFindLocalKEPs
--- PASS: TestFindLocalKEPs (0.00s)
FAIL
exit status 1
FAIL    k8s.io/enhancements/pkg/kepctl  1.015s

justaugustus commented 3 years ago

Looking into this as part of https://github.com/kubernetes/enhancements/issues/2283.

/assign /sig architecture /area enhancements

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

spiffxp commented 3 years ago

/remove-lifecycle stale https://github.com/kubernetes/enhancements/pull/2753 will fix this

spiffxp commented 3 years ago

/assign

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

spiffxp commented 3 years ago

/remove-lifecycle stale /help I believe this has been fixed if someone wants to verify

k8s-ci-robot commented 3 years ago

@spiffxp: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes/enhancements/issues/2283): >/remove-lifecycle stale >/help >I believe this has been fixed if someone wants to verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

spiffxp commented 3 years ago

/close make test now passes, I believe https://github.com/kubernetes/enhancements/pull/2753 was the fix

k8s-ci-robot commented 3 years ago

@spiffxp: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2283#issuecomment-899685587): >/close >`make test` now passes, I believe https://github.com/kubernetes/enhancements/pull/2753 was the fix Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kubernetes / enhancements

go test -v failed , different error msg #2283