search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.39k stars 1.46k forks source link

Metric cardinality enforcement #2305

Closed ehashman closed 1 week ago

ehashman commented 3 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

ehashman commented 3 years ago

/sig instrumentation /stage alpha

lilic commented 3 years ago

@ehashman is there any action items for either Han or me? Thank you!

ehashman commented 3 years ago

@lilic this KEP graduated to alpha last cycle (1.20), it would be good to finish up beta and graduation criteria and target releases for those.

ehashman commented 3 years ago

@lilic @logicalhan once we have beta/graduation criteria we should decide how we want to target milestones for this moving forward. That's all currently empty:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2305-metrics-cardinality-enforcement#post-beta-tasks

ehashman commented 3 years ago

/milestone v1.21

slipped from 1.20

annajung commented 3 years ago

Hi @logicalhan and @lilic, 1.21 Enhancements Lead here

For the enhancement to be included in the milestone, it must meet the following criteria:

Please make sure you update the KEP using the latest template.

Also starting 1.21, all KEP must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include this. For PRR review, please make sure to reach out to #prod-readiness slack channel asap to get this in before the enhancements freeze coming up on Feb. 9th.

Thank you!

JamesLaverack commented 3 years ago

Hey @logicalhan and @lilic, 1.21 enhancements shadow here,

Just to add to Anna's comment above — enhancement's freeze is 2 days away, Feb 9th EOD PST. Any enhancements that do not complete the requirements in Anna's comment above by the freeze will require an exception.

ehashman commented 3 years ago

I've pinged @logicalhan about getting this added today.

YoyinZyc commented 3 years ago

Opened https://github.com/kubernetes/enhancements/pull/2468 to update kep and request for PPR approval.

ehashman commented 3 years ago

@annajung everything should now be addressed.

annajung commented 3 years ago

With PR https://github.com/kubernetes/enhancements/pull/2468 merged, this enhancement meets all criteria required for the enhancements freeze 👍

alculquicondor commented 3 years ago

ref kubernetes/kubernetes#97208

I have a couple of suggestions for extensions:

JamesLaverack commented 3 years ago

Hi @logicalhan and @lilic,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

JamesLaverack commented 3 years ago

Hi @logicalhan and @lilic,

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

ehashman commented 3 years ago

@JamesLaverack I'm updating the point contacts to be @logicalhan and @YoyinZyc

YoyinZyc commented 3 years ago

@JamesLaverack There is one ongoing pr https://github.com/kubernetes/kubernetes/pull/99385

YoyinZyc commented 3 years ago

ref kubernetes/kubernetes#97208

I have a couple of suggestions for extensions:

  • Can we generalize the proposal to allow for mapping? That is, instead of replacing the value with "unknown", allowing configurable renaming, maybe with numeric intervals or regex.
  • Make this configurable via component configs, as a CLI arg would be harder to maintain.

I think they are good ideas. I'll keep that in mind. Thanks!

JamesLaverack commented 3 years ago

@ehashman Thanks for the clarification! We'll update our tracking spreadsheet to reflect that.

@YoyinZyc Thank you for linking me, i've set this enhancement back to "Tracked". I see that https://github.com/kubernetes/kubernetes/pull/99385 is now merged. Are there any other k/k pull requests outstanding (/need doing before code freeze) or can I mark you as done?

YoyinZyc commented 3 years ago

Yuchen Zhou Thank you for linking me, i've set this enhancement back to "Tracked". I see that kubernetes/kubernetes#99385 is now merged. Are there any other k/k pull requests outstanding (/need doing before code freeze) or can I mark you as done?

@JamesLaverack I have one more pr https://github.com/kubernetes/kubernetes/pull/99738. Once it is merged, you can mark it as done.:)

ehashman commented 3 years ago

Code changes are complete, we just need to follow up with documentation updates.

YoyinZyc commented 3 years ago

Code changes are complete, we just need to follow up with documentation updates.

Can you give me some instruction on which document I should update? I am not sure I know all. Thanks!

JamesLaverack commented 3 years ago

Thanks both. I've now updated the enhancement tracking spreadsheet to note this enhancement as done for code freeze.

PI-Victor commented 3 years ago

Hello @YoyinZyc , 1.21 Docs shadow here. Does this enhancement work planned for 1.21 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

reylejano commented 3 years ago

Hi @logicalhan and @YoyinZyc, 1.21 Docs lead here. Just a reminder that the Docs Placeholder PR deadline for 1.21 is around the corner on March 16. If this enhancement needs new documentation or an entry/update to the feature gates page please open a PR against the dev-1.21 branch in the k/website repo.

YoyinZyc commented 3 years ago

@reylejano kubernetes/website#27069 is there waiting for owners' approval.

ehashman commented 3 years ago

/remove-label tracked/yes /label stage/beta /milestone v1.22

k8s-ci-robot commented 3 years ago

@ehashman: The label(s) /label stage/beta , /remove-label tracked/yes cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda

In response to [this](https://github.com/kubernetes/enhancements/issues/2305#issuecomment-820595780): >/remove-label tracked/yes >/label stage/beta >/milestone v1.22 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ehashman commented 3 years ago

/stage beta /remove-stage alpha

ehashman commented 3 years ago

/milestone v1.22

ehashman commented 3 years ago

Oh I did that already, woot :)

supriya-premkumar commented 3 years ago

👋🏼 Hi @ehashman

This is Supriya, v1.22 enhancement shadow here. For the enhancement to be included in the 1.22 milestone, it must meet the following criteria:

The KEP must be updated with stage(beta) and milestones in kep.yaml The KEP must be updated with stage(beta) in production readiness review The KEP must include the PRR metrics for the beta release The KEP must include/update Test Plan and Graduation Criteria for beta release.

Thank you!

ehashman commented 3 years ago

/milestone clear

@supriya-premkumar talked to Han and we don't have the bandwidth to complete this for the 1.22 cycle. We'll revisit for 1.23.

supriya-premkumar commented 3 years ago

Hi @ehashman, Thanks for the update, let me make sure that it's updated accordingly on the tracking sheet.

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

PI-Victor commented 3 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

logicalhan commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2305#issuecomment-1094103242): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dgrisonnet commented 1 year ago

This KEP is still in Alpha, we need to do something about it.

/reopen /lifecycle frozen

k8s-ci-robot commented 1 year ago

@dgrisonnet: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2305#issuecomment-1258168022): >This KEP is still in Alpha, we need to do something about it. > >/reopen >/lifecycle frozen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dgrisonnet commented 1 year ago

/label lead-opted-in

dgrisonnet commented 1 year ago

/milestone v1.26

k8s-ci-robot commented 1 year ago

@dgrisonnet: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/2305#issuecomment-1260938297): >/milestone v1.26 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
marosset commented 1 year ago

/milestone v1.26 /label tracked/yes

marosset commented 1 year ago

Hello @dgrisonnet 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, I do see https://github.com/kubernetes/enhancements/pull/3560. In addition to the current changes in this PR can you

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

dgrisonnet commented 1 year ago

Hi @marosset, thank you for the feedback.

Considering that we need to revisit the test plan of the KEP, this would require more involvement than expected, so it would be better to defer the graduation to 1.27. As such, could you please remove the KEP from the list for the 1.26 milestone?

/remove-label lead-opted-in

marosset commented 1 year ago

No problem. /milestone clear