search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.46k stars 1.49k forks source link

cAdvisor-less, CRI-full Container and Pod Stats #2371

Open haircommander opened 3 years ago

haircommander commented 3 years ago

Enhancement Description

haircommander commented 2 years ago

we'll be making a major change to alpha in 1.26

derekwaynecarr commented 2 years ago

/milestone v1.26 /label lead-opted-in

rhockenbury commented 2 years ago

Hello @haircommander and @bobbypage 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the KEP yaml to reflect the latest milestones.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

rhockenbury commented 2 years ago

We would also need to have the milestone stages updated in the KEP yaml - https://github.com/kubernetes/enhancements/pull/3559/files#diff-0ed5ee24cb73f3749f465e3aa48380d7daf115cdb2e1e83bb2c0aa3c4786d662R22

rhockenbury commented 2 years ago

I'll mark this as tracked for enhancements freeze but please update the milestone stages in the KEP yaml.

haircommander commented 2 years ago

It looks to me this was done https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2371-cri-pod-container-stats/kep.yaml#L18-L20

rhockenbury commented 2 years ago

Okay, I think it should be fine. I was referring to this line, but since this went into alpha in v1.23, we should probably leave it as v1.23 rather than updating to v1.26.

Thanks!

ruheenaansari34 commented 2 years ago

Hi @haircommander 👋,

Checking in once more as we approach the 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

For this enhancement, I could not locate any k/k PRs, other than https://github.com/kubernetes/kubernetes/pull/103095. If you do have k/k PRs open, please link them to this issue.

As always, we are here to help should questions come up. Thanks!

krol3 commented 2 years ago

Hello @haircommander 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

krol3 commented 2 years ago

Hello @haircommander and @bobbypage :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

haircommander commented 2 years ago

I think we can not have docs for this release. How do we opt-out?

krol3 commented 2 years ago

@reylejano , This KEP is keeping the 1.23 version, we don't need to update the doc for 1.26.

haircommander commented 2 years ago

we did have new pieces for alpha retargeted at 1.26, but I don't think they require documentation

krol3 commented 2 years ago

Hi @haircommander , I think at least we will need to update the new changes of these feature PodAndContainerStatsFromCRI in https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

cc: @reylejano

palnabarun commented 2 years ago

https://github.com/kubernetes/website/issues/33509 is relevant here.

krol3 commented 2 years ago

@haircommander and @bobbypage could you help with the documentation relevant for the release 1.26?

haircommander commented 2 years ago

I've opened https://github.com/kubernetes/website/pull/37962

marosset commented 1 year ago

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

haircommander commented 1 year ago

/milestone 1.27

k8s-ci-robot commented 1 year ago

@haircommander: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/2371#issuecomment-1400727311): >/milestone 1.27 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SergeyKanzhelev commented 1 year ago

/milestone 1.27

k8s-ci-robot commented 1 year ago

@SergeyKanzhelev: The provided milestone is not valid for this repository. Milestones in this repository: [v1.24, v1.25, v1.26, v1.27, v1.28]

Use /milestone clear to clear the milestone.

In response to [this](https://github.com/kubernetes/enhancements/issues/2371#issuecomment-1414434743): >/milestone 1.27 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SergeyKanzhelev commented 1 year ago

/milestone v1.27

bobbypage commented 1 year ago

@SergeyKanzhelev can you please add lead-opted-in label?

SergeyKanzhelev commented 1 year ago

/label lead-opted-in

fsmunoz commented 1 year ago

Hello @haircommander 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

haircommander commented 1 year ago

thanks for the heads up about template changes! I've updated https://github.com/kubernetes/enhancements/pull/3770 to reflect them

fsmunoz commented 1 year ago

Thank you @haircommander , feel free to ping me when this is merged (I see that there is ongoing discussion) for me to act ASAP. It currently seems to cover everthing.

marosset commented 1 year ago

Unfortunately, this exception hasn't satisfied all of the requirements by the v1.27 code freeze and will be removed from the milestone.

If you feel it is important to include this exception in v1.27 please consider filing an exception as outlined at https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

SergeyKanzhelev commented 1 year ago

My understanding is that Windows support is being added now. Applying the label to track it:

/milestone v1.28

SergeyKanzhelev commented 1 year ago

/stage beta

marosset commented 1 year ago

My understanding is that Windows support is being added now. Applying the label to track it:

/milestone v1.28

Windows support is being added with https://github.com/kubernetes/kubernetes/pull/116968 /sig windows

SergeyKanzhelev commented 1 year ago

/label lead-opted-in

Kasambx commented 1 year ago

Hello @haircommander 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023..

This enhancement is targeting for stage beta for v 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

haircommander commented 1 year ago

I've opened https://github.com/kubernetes/kubernetes/pull/118838 to verify metrics are present as expected

Rishit-dagli commented 1 year ago

Hello @bobbypage @haircommander :wave:, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Rishit-dagli commented 1 year ago

Hey @haircommander , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

haircommander commented 1 year ago

done! https://github.com/kubernetes/website/pull/42012

Atharva-Shinde commented 1 year ago

Hey @haircommander Enhancements team here :wave:

Just checking in as we approach Code freeze at 01:00 UTC Wednesday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

For this enhancement, it looks like the following code related PR is open and it needs to be merged or should be in merge-ready state before the code freeze commences :

This is the code related PR/s that I found on this KEP issue

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

Atharva-Shinde commented 1 year ago

Hello @haircommander 👋, 1.28 Enhancements Lead here.

Unfortunately, the e2e test PR associated with this enhancement was not in the merge-ready state by the code-freeze and hence this enhancement is now being removed from the v1.28 milestone.

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

SergeyKanzhelev commented 1 year ago

/milestone v1.29

@haircommander can you please send a PR to bump kep.yaml metadata?

npolshakova commented 1 year ago

Hi @haircommander 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

It looks like https://github.com/kubernetes/enhancements/pull/4249/files will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

SergeyKanzhelev commented 1 year ago

/stage alpha

npolshakova commented 1 year ago

Hi @haircommander, just checking in once more as we approach the 1.29 enhancement freeze deadline this week on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze.

It looks like when https://github.com/kubernetes/enhancements/pull/4249 is merged in it will address most of the requirements. Let me know if I missed anything. Thanks!

npolshakova commented 1 year ago

With https://github.com/kubernetes/enhancements/pull/4249 merged this enhancement is tracked for enhancement freeze! 🚀

drewhagen commented 1 year ago

Hello @bobbypage @haircommander :wave:, v1.29 Docs Shadow here. Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

haircommander commented 1 year ago

I don't believe so. thanks!

a-mccarthy commented 1 year ago

Hi @bobbypage @haircommander, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

AnaMMedina21 commented 1 year ago

Hello @haircommander @bobbypage 👋, v1.29 Enhancements team here.

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023

Here's where this enhancement currently stands:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

With all this, the status of this KEP is tracked for code freeze.

As always, we are here to help if any questions come up. Thanks!

npolshakova commented 1 year ago

Hello @haircommander @bobbypage 👋, 1.29 Enhancements team here!

With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. The tracked test PRs for this KEP are:

Please let me know if there are additional test PRs we should track. Thanks!