kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.34k stars 1.44k forks source link

kubetest2 CI migration #2464

Open amwat opened 3 years ago

amwat commented 3 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

This will be in: https://github.com/kubernetes/enhancements/tree/master/keps/sig-testing/2464-kubetest2-ci-migration

/assign /sig testing /sig release

spiffxp commented 3 years ago

/milestone v1.21

spiffxp commented 3 years ago

/priority important-soon

BenTheElder commented 3 years ago

This will be merged implementable momentarily #2479

spiffxp commented 3 years ago

I would bucket this KEP under process when https://github.com/kubernetes/enhancements/issues/2311 is completed

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot commented 3 years ago

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen. Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

BenTheElder commented 3 years ago

Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

Release cycles are now 4 months long. I don't believe this is accurate / the most reasonable anymore. fejta-bot stales an issue after 90 days (rotten + closed after 30 more), but release cycles are now roughly 1/3 a year ...

spiffxp commented 2 years ago

I'm adding a tracked/no label to this as a best guess but I'm open to suggestion from @kubernetes/enhancements or @kubernetes/release-team

It's the sort of thing that either lands prior to Test Freeze, or it doesn't, since this determines what is being used for CI signal

spiffxp commented 2 years ago

/milestone v1.23

spiffxp commented 2 years ago

/stage beta https://github.com/kubernetes/enhancements/pull/2871 proposes moving this to beta in v1.23

Priyankasaggu11929 commented 2 years ago

Hi @amwat! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

Looks like for this one, we would just need the following:

Thanks!

Priyankasaggu11929 commented 2 years ago

Thanks so much for the changes, @amwat. With the KEP PR merged, this enhancement is ready for 1.23 enhancements freeze. :)

spiffxp commented 2 years ago

/kind kep

spiffxp commented 2 years ago

Checklist for beta:

Priyankasaggu11929 commented 2 years ago

Hello @amwat 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

As always, we are here to help should questions come up.

Thank you so much! 🙂

amwat commented 2 years ago

Thanks @Priyankasaggu11929 , updated the PR description with latest info.

Priyankasaggu11929 commented 2 years ago

Thank you so much for the update @amwat. 🙂

spiffxp commented 2 years ago

@amwat did we complete any of the checklist items to actually graduate to beta? I saw a lot of shadow presubmits added this cycle but I'm less clear whether there are any more blocking jobs using kubetest2 than last release

amwat commented 2 years ago

Yeah, all of those are are towards the 3rd beta requirement of having shadow node jobs.

We have an overall community guide for migration at: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests-kubetest2.md#testing-against-an-existing-cluster I think we can keep adding FAQs for migrating specific types of jobs to this doc, but that probably also extends beyond the limitations of this KEP.

But we have not yet made pull-kubernetes-e2e-gce-kubetest2 blocking (thanks for the reminder!)

Note sure if we want to update the target accordingly then.

Priyankasaggu11929 commented 2 years ago

Hello @amwat, could you help providing a status summary on the checklist, mentioned in one of the above comments here. Want to confirm if all fo the items are checked or if not, what all are still in progress..

Thank you so much! 🙂

SergeyKanzhelev commented 2 years ago

@amwat what is the status of this? Is there plan to fully transition sig node tests to kubetest2 in 1.24?

BenTheElder commented 2 years ago

@SergeyKanzhelev amwat moved on before your comment and doesn't work in Kubernetes anymore. I don't know who can take up the remainder yet.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Namanl2001 commented 2 years ago

/remove-lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

cpanato commented 1 year ago

/remove-lifecycle stale

cpanato commented 1 year ago

i will take a look on this, maybe just need some quick recap :) cc @BenTheElder

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

cpanato commented 1 year ago

@BenTheElder gently ping here :)

BenTheElder commented 1 year ago

@cpanato I don't have a lot to add unfortunately, the last I saw we were blocked on getting SIG Node input to migrate node_e2e support, and the large lift to port existing job configs otherwise, in theory the tooling works for kube-up/kOps e2e tests today and it is used for kOps and some kube-up.sh/GCE jobs.

BenTheElder commented 1 year ago

I stepped down from kubetest/kubetest2, it became one too many projects to maintain with the high focus on infra costs. I'm no longer an approver in kubetest2.

cc @aojea @pohly @cjwagner @alvaroaleman (the rest of our SIG TLs)

aojea commented 1 year ago

If nobody is going to work on this we should close the issue,no?

is not really a feature, it seems to track only the effort to do it

BenTheElder commented 1 year ago

@aojea https://github.com/kubernetes/enhancements/issues/2464#issuecomment-1235407789 ?

otherwise yes

vaibhav2107 commented 1 year ago

/remove-lifecycle stale

cpanato commented 1 year ago

agree @aojea

upodroid commented 11 months ago

/assign

Can we track this for 1.29?

Core Goals:

~Stretch Goals:~

@dims

dims commented 11 months ago

@upodroid sounds good to me :)