search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.44k stars 1.49k forks source link

Ensure secret pulled images #2535

Open adisky opened 3 years ago

adisky commented 3 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig node

SergeyKanzhelev commented 1 year ago

/milestone v1.28

SergeyKanzhelev commented 1 year ago

/label lead-opted-in

Kasambx commented 1 year ago

Hello @pacoxu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on { FREEZE_DATETIME }.

This enhancement is targeting for stage alpha for v 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

mikebrow commented 1 year ago

@Kasambx see update commit to adjust based on latest test plan format: https://github.com/kubernetes/enhancements/pull/3532/commits

thx!

Atharva-Shinde commented 1 year ago

Hello 👋, 1.28 Enhancements Lead here. Unfortunately, this enhancement did not meet requirements for v1.28 enhancements freeze. Feel free to file an exception to add this back to the release tracking process. Thanks!

Atharva-Shinde commented 1 year ago

/milestone clear

pacoxu commented 1 year ago

https://github.com/kubernetes/enhancements/pull/3532#issuecomment-1592147464

The enhancements update is about the implementation details in persistence. And no PRR update is needed.

IMO, this can be still in v1.28 milestone. Not sure if we need to open an exception for it. @SergeyKanzhelev

VibhorChinda commented 1 year ago

Hello @pacoxu :wave:, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

pacoxu commented 1 year ago

@VibhorChinda Thanks for reminding me. I created https://github.com/kubernetes/website/pull/41753 as a placeholder. I will update it once https://github.com/kubernetes/kubernetes/pull/114847/ is merged.

VibhorChinda commented 1 year ago

@VibhorChinda Thanks for reminding me. I created kubernetes/website#41753 as a placeholder. I will update it once kubernetes/kubernetes#114847 is merged.

Thanks @pacoxu 😄 Please add the placeholder PR link in the description under the Docs section too. Thanks 😁

pacoxu commented 1 year ago

@VibhorChinda I am afraid that I have no permission to update the issue. @adisky do you have time to update?

adisky commented 1 year ago

@pacoxu Thanks, updated

Atharva-Shinde commented 1 year ago

Hey @pacoxu @mikebrow Enhancements lead here! Looks like there has been an oversight while tracking this KEP, the KEP didn't satisfy the enhancements freeze criteria and was later still marked as "tracked" by one of our enhancements team members. And from the current state of the KEP it looks like it still hasn't been updated with latest information. Therefore unfortunately this KEP won't be able to move forward for the current 1.28 release cycle. Feel free to opt-in for the next release cycle i.e v1.29.

Sorry for the inconvenience!

mikebrow commented 1 year ago

Thx @Atharva-Shinde, yes the https://github.com/kubernetes/enhancements/pull/3532 did not get merged yet. Will adjust for v1.29! Cheers

pacoxu commented 1 year ago

https://github.com/kubernetes/enhancements/pull/3532 needs a version bump then😄

pacoxu commented 1 year ago

Thx @Atharva-Shinde, yes the #3532 did not get merged yet. Will adjust for v1.29! Cheers

Hi Mike, do you have time to update the KEP in v1.29 release cycle? Hope we can have an early review and merge. 😄

SergeyKanzhelev commented 1 year ago

/milestone v1.29

Can somebody update the https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2535-ensure-secret-pulled-images/kep.yaml to indicate the target version?

mikebrow commented 1 year ago

/milestone v1.29

Can somebody update the https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2535-ensure-secret-pulled-images/kep.yaml to indicate the target version?

https://github.com/kubernetes/enhancements/pull/3532

sreeram-venkitesh commented 1 year ago

Hello @mikebrow 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

sreeram-venkitesh commented 1 year ago

@mikebrow I have moved this KEP to at risk for enhancement freeze since the changes haven't been merged into k/enhancements yet. I will update the enhancements tracking board once the PR is merged.

sreeram-venkitesh commented 1 year ago

Hi @mikebrow, checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC Friday, 6th October 2023. The status of this enhancement is marked as at risk. It looks like https://github.com/kubernetes/enhancements/pull/3532 will address most of the requirements. Please make sure that the changes are merged in time. Let me know if I missed anything. Thanks!

npolshakova commented 1 year ago

With KEP PR https://github.com/kubernetes/enhancements/pull/3532 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

drewhagen commented 1 year ago

Hello @mikebrow @pacoxu :wave:, v1.29 Docs Shadow here. Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

pacoxu commented 1 year ago

@drewhagen I opened https://github.com/kubernetes/website/pull/43454 as a placeholder. The PR is still in review.

a-mccarthy commented 1 year ago

Hi @mikebrow @pacoxu, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

sreeram-venkitesh commented 1 year ago

Hey again @pacoxu 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP if any).

The status for this KEP is currently at risk for code freeze. Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

pacoxu commented 1 year ago

Sorry for the late update due to missing @haircommander 's comments notification. I update the PR yesterday. And I may have to test it again with some changes. And the PR needs another round of review.

npolshakova commented 1 year ago

Hello @pacoxu 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

salehsedghpour commented 10 months ago

/remove-label lead-opted-in

pacoxu commented 9 months ago

kep update PR is open in https://github.com/kubernetes/enhancements/pull/4431. cc @SergeyKanzhelev for KEP planning

SergeyKanzhelev commented 9 months ago

/stage alpha /milestone v1.30

salehsedghpour commented 9 months ago

Hello @pacoxu and @mikebrow , 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

mrunalp commented 9 months ago

/label lead-opted-in

salehsedghpour commented 9 months ago

Hello @mikebrow and @pacoxu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

The status of this enhancement is marked as Tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

Princesso commented 9 months ago

Hello @adisky, @pacoxu 👋 1.30 Docs Shadow here. Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

fkautz commented 9 months ago

Hi @mikebrow @pacoxu

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

mikebrow commented 8 months ago

@adisky Pls update doc list to also include the wip blog entry ^^

salehsedghpour commented 8 months ago

Hey again @mikebrow and @pacoxu 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

salehsedghpour commented 8 months ago

With the exception request being approved, this can now be marked as tracked for code freeze.

drewhagen commented 8 months ago

Hello @mikebrow @pacoxu @adisky! Double checking with y'all, do you intend to release docs for this feature in release 1.30? If so, we have to get a review started as soon as possible given the deadline for docs PR Ready for Review was yesterday.

There appears to have been a mix-up where the blog PR was being tracked as a docs PR, so we'd like to help here if docs are needed. A complete review of new docs is due Tuesday March 26th, after which an exception needs to be filed.

Please let us know if docs are needed. Thanks! 😄 cc: @Princesso

pacoxu commented 8 months ago

/milestone clear

Some discussions around the design when doing the api review. This feature will be postponed.

sreeram-venkitesh commented 6 months ago

Hi 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

SergeyKanzhelev commented 5 months ago

@pacoxu do you plan to make progress on this in 1.31?

haircommander commented 5 months ago

I have taken this over in https://github.com/kubernetes/enhancements/pull/4693 (chatted with @pacoxu about it, he's swamped in kubecon china planning)

mrunalp commented 5 months ago

/milestone v1.31 /label lead-opted-in

dipesh-rawat commented 5 months ago

Hello @pacoxu @mikebrow @haircommander 👋, 1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage alpha for 1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

It looks like https://github.com/kubernetes/enhancements/pull/4693 will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat commented 5 months ago

Hi @pacoxu @mikebrow @haircommander 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/2535#issuecomment-2148682311 that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat commented 5 months ago

Hello @pacoxu @mikebrow @haircommander 👋, 1.31 Enhancements team here,

Now that PR https://github.com/kubernetes/enhancements/pull/4693 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

Aside from the minor nits mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

haircommander commented 5 months ago

@pacoxu or @adisky are either of you able to?

pacoxu commented 5 months ago

I will give it a try the next release cycle if no one take it in v1.31.