search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.38k stars 1.45k forks source link

Enhance CPU manager with L3 cache aware #2621

Closed hustcat closed 1 week ago

hustcat commented 3 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

hustcat commented 3 years ago

/sig node

hustcat commented 3 years ago

/assign @ranchothu @hustcat

k8s-ci-robot commented 3 years ago

@hustcat: GitHub didn't allow me to assign the following users: ranchothu.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes/enhancements/issues/2621#issuecomment-818600473): >/assign @ranchothu @hustcat Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 3 years ago

Hi! there is already a conversation (maybe a github issue?) in place on cadvisor project to report the informations about llc so kubelet can consume them? Could you please link it here maybe?

ffromani commented 3 years ago

Hi! there is already a conversation (maybe a github issue?) in place on cadvisor project to report the informations about llc so kubelet can consume them? Could you please link it here maybe?

nevermind, I just realized you documented in the KEP text itself.

hustcat commented 3 years ago

https://docs.google.com/document/d/1BuiBgsittUnU3heKHRCQ66YYxzAItT5gcPlu3N83PfA/edit?usp=sharing This is the design document.

k8s-triage-robot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

ffromani commented 3 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2621#issuecomment-1003991871): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/reopen

k8s-ci-robot commented 2 years ago

@fromanirh: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2621#issuecomment-1004001614): >/reopen > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2621#issuecomment-1027811359): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 months ago

/reopen

k8s-ci-robot commented 2 months ago

@ffromani: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2621#issuecomment-2184170111): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 months ago

@hustcat hi! are still interested in pushing forward this KEP?

sphrasavath commented 1 month ago

@ffromani Thanks for reopening this KEP. I am interested in pushing this forward. However, I would like to make changes to the design. Motivation for the KEP is the same. After reading through your comments for [pr-2684](https://github.com/kubernetes/enhancements/pull/2684) I agree with the approach of implementing this feature as a static policy option.

I’m still working out the details to the design but in general here is what we're thinking...

Revised design doc

sphrasavath commented 2 weeks ago

@ffromani created pr-126750 for this KEP

Thanks for the feedback! Per your comments in the design doc regarding the goal to support multiple socket due to decrease performance for cross-die placement, our intention is to add that as part of beta. However, the pull request above does not include 2P yet. Will create a new pr.

In response to your comments about how the new policy option works with existing options. "align-cpus-by-uncorecache" attempts to take full cores whether "full-pcpus-only" is enabled or not. Because it this new option follows the "pack" cpu sorting strategy, this option will not be allowed if "distribute-cpus-across-numa" or "distribute-cpus-across-cores" policy options are enabled.

Saw your comments and @kannon92 regarding e2e tests. Will update.

ffromani commented 2 weeks ago

@ffromani created pr-126750 for this KEP

thanks. We need now to resume the conversation about this KEP, incorporating the elements from the design doc you shared previously, and of course all the feedback from the community.

Lacking better options (cc @SergeyKanzhelev @mrunalp please suggest any) the best option is probably to create a new PR superceding the old one. We can't transfer ownership in github issues, so it's likely we would need a new issue to be able to interact efficiently with the release team.

kannon92 commented 1 week ago

/assign @sphrasavath

kannon92 commented 1 week ago

@ffromani created pr-126750 for this KEP

thanks. We need now to resume the conversation about this KEP, incorporating the elements from the design doc you shared previously, and of course all the feedback from the community.

Lacking better options (cc @SergeyKanzhelev @mrunalp please suggest any) the best option is probably to create a new PR superceding the old one. We can't transfer ownership in github issues, so it's likely we would need a new issue to be able to interact efficiently with the release team.

Yes, let's get new PR up for the KEP and close the old one.

And I think the best thing would be to close this issue and open a new one with @sphrasavath so that it can be updated with the correct details.

sphrasavath commented 1 week ago

@kannon92 Per your request, new issue created: #4800

kannon92 commented 1 week ago

/close

k8s-ci-robot commented 1 week ago

@kannon92: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/2621#issuecomment-2305805122): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.