search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.34k stars 1.44k forks source link

Dynamic Kubelet Configuration #281

Closed mtaufen closed 1 year ago

mtaufen commented 7 years ago

Dynamic Kubelet Configuration

mtaufen commented 7 years ago

Alpha PR: https://github.com/kubernetes/kubernetes/pull/46254

dchen1107 commented 7 years ago

Punt this to v1.8.

luxas commented 6 years ago

@mtaufen Any user/admin-facing docs ready for this feature?

mtaufen commented 6 years ago

No, I really need to write something to teach people how to play with the alpha. What's the preferred place for these docs again?

luxas commented 6 years ago

@mtaufen https://kubernetes.io/docs (https://github.com/kubernetes/kubernetes.github.io) I'll definitely read what it came to look like finally

mtaufen commented 6 years ago

@luxas https://github.com/kubernetes/kubernetes.github.io/pull/5523

idvoretskyi commented 6 years ago

@mtaufen can you update the features tracking board with the relevant data?

Thanks.

mtaufen commented 6 years ago

Done

pipejakob commented 6 years ago

Looks like the proposal has moved to:

https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/dynamic-kubelet-configuration.md

@mtaufen Want to update the link in the description?

mtaufen commented 6 years ago

Done, thanks!

luxas commented 6 years ago

Updated the labels here, @mtaufen please share the beta graduation requirements here for visibility

mtaufen commented 6 years ago

Deprecated and experimental fields removed from the KubeletConfiguration type in https://github.com/kubernetes/kubernetes/pull/53088. Next steps: push the type to beta, chase down loose ends (testing, node authorizer, etc.) and push dynamic config to beta.

fejta-bot commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta. /lifecycle stale

mtaufen commented 6 years ago

/lifecycle frozen

idvoretskyi commented 6 years ago

@mtaufen can you comment on the actual feature status?

mtaufen commented 6 years ago

still pushing for beta in 1.10

idvoretskyi commented 6 years ago

Ref https://github.com/kubernetes/kubernetes/pull/55718

timothysc commented 6 years ago

From https://github.com/kubernetes/kubernetes/pull/60412 it appears beta is a push to 1.11

mtaufen commented 6 years ago

@timothysc that is correct. I was hoping the node authorizer checkbox for v1.10 could at least make it, but that seems increasingly unlikely given the time constraints...

luxas commented 6 years ago

This is then wrongly flagged beta in http://blog.kubernetes.io/2018/03/first-beta-version-of-kubernetes-1-10.html, as this label is beta here, swapping. cc @nickchase (thanks for all your hard work on the article, seems to have been a communication issue here)

mtaufen commented 6 years ago

Thanks for catching that @luxas. @nickchase what do we need to do to update the post?

justaugustus commented 6 years ago

@mtaufen Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

cc @idvoretskyi

mtaufen commented 6 years ago

@justaugustus does stage indicate the target for the milestone, or the current status?

justaugustus commented 6 years ago

@mtaufen the stage represents the target for the current milestone (v1.11).

mtaufen commented 6 years ago

Thanks, updated.

mdlinville commented 6 years ago

@mtaufen please fill out the appropriate line item of the 1.11 feature tracking spreadsheet and open a placeholder docs PR against the release-1.11 branch by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are needed and a relevant PR has not yet been opened.

mtaufen commented 6 years ago

@mistyhacks done, thanks!

kacole2 commented 6 years ago

@mtaufen This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12 since there is nothing in the original post. This still has the 1.11 milestone as well so we need to update it accordingly.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

mtaufen commented 5 years ago

No plans to graduate for 1.12.

kacole2 commented 5 years ago

Hi This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

mtaufen commented 5 years ago

@kacole2 no plans to graduate in 1.13. Are the milestones already correct for this case (assuming yes given tracked/no)?

kacole2 commented 5 years ago

@mtaufen thank you. everything is correct for labels. thanks!

luxas commented 5 years ago

Are there plans to graduate this in v1.14?

mtaufen commented 5 years ago

I'd like to finish the flag migration for KubeletConfiguration, then take a step back and think about what we might want to change, then get KubeletConfiguration to GA, then finally consider how to move Dynamic Kubelet Config forward.

I'm hoping to make some significant progress on the flag migrations this quarter, and then start the discussions of what we might want to change as part of our component standardization work.

claurence commented 5 years ago

@mtaufen Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

mtaufen commented 5 years ago

Hi @claurence, We don't expect anything specific beyond the ongoing flag migrations (which are piecemeal and best-effort). Some more general things may be surfaced in KEPs by the Component Standard WG.

kacole2 commented 5 years ago

Hello @mtaufen, I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. This will require a formal KEP to be included. The community post will not suffice unfortunately.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

mtaufen commented 5 years ago

@kacole2 No plans for 1.15. Thanks for asking!

kacole2 commented 5 years ago

Hi @mtaufen , I'm the 1.16 Enhancement Lead/Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

mtaufen commented 5 years ago

No further plans this release, thanks!

On Tue, Jul 9, 2019 at 8:31 AM Kendrick Coleman notifications@github.com wrote:

Hi @mtaufen https://github.com/mtaufen , I'm the 1.16 Enhancement Lead/Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet http://bit.ly/k8s116-enhancement-tracking. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/281?email_source=notifications&email_token=AAG4TQJABPUD2RVQX4FUHWTP6SVLTA5CNFSM4DJGDYX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQUNBQ#issuecomment-509691526, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4TQMYXUSQEBH5PI4KFELP6SVLTANCNFSM4DJGDYXQ .

-- Michael Taufen Google SWE

annajung commented 4 years ago

Hello @mtaufen , 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?

 Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

mtaufen commented 4 years ago

Thanks Anna for reaching out. There is no ongoing work on this feature for 1.17.

On Tue, Oct 1, 2019 at 6:13 PM Anna notifications@github.com wrote:

Hello @mtaufen https://github.com/mtaufen , 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17? Please let me know so that this enhancement can be added to 1.17 tracking sheet https://bit.ly/k8s117-enhancement-tracking.

Thank you!

🔔Friendly Reminder

-

The current release schedule is

  • Monday, September 23 - Release Cycle Begins
    • Tuesday, October 15, EOD PST - Enhancements Freeze
    • Thursday, November 14, EOD PST - Code Freeze
    • Tuesday, November 19 - Docs must be completed and reviewed
    • Monday, December 9 - Kubernetes 1.17.0 Released

  • A Kubernetes Enhancement Proposal (KEP) must meet the following criteria before Enhancement Freeze to be accepted into the release

  • PR is merged in
    • In an implementable state
    • Include test plans and graduation criterias

  • All relevant k/k PRs should be listed in this issue

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/281?email_source=notifications&email_token=AAG4TQMZ7AXQHRBIH2H5VLTQMPYTRA5CNFSM4DJGDYX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADHHCA#issuecomment-537293704, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4TQINRZ4YPBGZVZQ4OB3QMPYTRANCNFSM4DJGDYXQ .

-- Michael Taufen Google SWE

annajung commented 4 years ago

@mtaufen Thank you for getting back to me! I will remove this from the tracking sheet 👍

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

mtaufen commented 4 years ago

/remove-lifecycle stale /lifecycle frozen /priority awaiting-more-evidence

For all future Enhancement Leads/Shadows: This feature is not being actively worked on at the moment. Our focus is pushing the underlying ComponentConfig APIs to a more stable state across core components. Once we get there, we will re-evaluate the usefulness of Dynamic Kubelet Config in its current state and consider updating the feature's design. Directly using the Kubelet's current ComponentConfig API results in a number of sharp edges for the dynamic config feature.

We will update this issue when we are ready to focus on improving the relationship to dynamic config. Until then, it is safe to assume that the dynamic config feature will not be graduating in whatever release you are working on. Thanks!

jeremyrickard commented 4 years ago

Thanks for the update @mtaufen.

fejta-bot commented 4 years ago

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen. Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale