search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Kubelet OpenTelemetry Tracing #2831

Open sallyom opened 3 years ago

sallyom commented 3 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

kikisdeliveryservice commented 3 years ago

@sallyom can you please add the mandatory discussion link to this issue?

ehashman commented 3 years ago

/sig node instrumentation

logicalhan commented 2 years ago

/assign

shivanshuraj1333 commented 2 years ago

/cc

yangjunmyfm192085 commented 2 years ago

/cc

249043822 commented 2 years ago

/cc

hosseinsalahi commented 2 years ago

Hello @sallyom

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Here’s where this enhancement currently stands:

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date for release v1.24. Thanks!

sallyom commented 2 years ago

@encodeflush thanks for the check-in - ~I'm not sure what the production readiness review is~ edit: found it, will add the questionnaire, I don't see it on the enhancements README ~can you point me to the steps to get that done~? Thanks again. Also, am I meant to check those off as they are done or are they for someone else to decide?

hosseinsalahi commented 2 years ago

@sallyom Thanks for the update. Those criterion should be fulfilled form your side. From enhancements team point of view, we go through them and check if your KEP meets the requirements.

chrisnegus commented 2 years ago

Hi @sallyom 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

valaparthvi commented 2 years ago

Hi @sallyom :wave: 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

hosseinsalahi commented 2 years ago

Hello @sallyom

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

ddebroy commented 2 years ago

https://github.com/kubernetes/enhancements/pull/3087 is not directly related to the overall OpenTelemetry enhancements.

sallyom commented 2 years ago

https://github.com/kubernetes/kubernetes/pull/105126 is the initial implementation for this enhancement

valaparthvi commented 2 years ago

Hi @sallyom :wave: 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

Hey @sallyom, can you please add a placeholder PR for this feature in https://github.com/kubernetes/website by March 30, that is our extended deadline for feature blog freeze?

Example of a feature blog PR: https://github.com/kubernetes/website/pull/30538 Example of a feature blog: https://github.com/kubernetes/website/blob/main/content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md

gracenng commented 2 years ago

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

wondywang commented 2 years ago

Hi @sallyom a question about Kubelet Tracing. Is there any trace information about the PLEG of the kubelet itself?

logicalhan commented 2 years ago

KEP will need to be updated with the new release versions since 1.24 was missed.

Priyankasaggu11929 commented 2 years ago

/milestone v1.25

marosset commented 2 years ago

Hello @sallyom 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

Looks like for this one, we would just need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

sallyom commented 2 years ago

Hello @marosset please see the PR to KEP-2831 https://github.com/kubernetes/enhancements/pull/3404, where I've updated

Thank you!

marosset commented 2 years ago

Hi @sallyom #3404 has everything required to track this enhancement for v1.25.

Please note that enhancement freeze is on 18:00 PST on Thursday June 23, 2022

Thanks!

Priyankasaggu11929 commented 2 years ago

Hello 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

The Open PR https://github.com/kubernetes/enhancements/pull/3404 is waiting on a SIG approval/lgtm.

Please plan to get the PR merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT (which is just over 3 days away from now)

For note, the current status of the enhancement is atat-risk. Thank you!

marosset commented 2 years ago

Hello @somalley, @husky-parul 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here’s where this enhancement currently stands:

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

sethmccombs commented 2 years ago

Hello @sallyom and @husky-parul! :wave:,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

jasonbraganza commented 2 years ago

Hi @sallyom, @husky-parul 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above. Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk. Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

husky-parul commented 2 years ago

Hi @jasonbraganza

@sallyom has a PR WIP for this. She is on PTO but will close this before the said deadline. Thank you for following up with us. :)

jasonbraganza commented 2 years ago

Hello @sallyom, @husky-parul 👋🏿

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022, tomorrow.

Please plan to get the open k/k PRs merged by then

The status of this enhancement is currently marked as at risk

Thank you!

Priyankasaggu11929 commented 2 years ago

With k/k PR https://github.com/kubernetes/kubernetes/pull/105126 merged now, this enhancement is marked as tracked for 1.25 code freeze. Thank you so much @sallyom @husky-parul.

logicalhan commented 2 years ago

/assign @dashpole

saschagrunert commented 1 year ago

@sallyom @dashpole I have to speak about our internal priorities for 1.27 but I may be able to pick this up.

Do you already have plans to graduate the feature in 1.27?

dashpole commented 1 year ago

@saschagrunert I don't personally have plans to drive this in 1.27

sallyom commented 1 year ago

@saschagrunert I haven't done anything to push this forward for 1.27 but I'll be interested to help - and @vrutkovs, too - we have time b4 1.27 enhancement freeze, let's get together on this

saschagrunert commented 1 year ago

@sallyom @vrutkovs I can spent time this week to update the KEP for beta graduation. Is this fine for you or do you prefer to do it?

vrutkovs commented 1 year ago

I would definitely need @saschagrunert's help on this :)

sallyom commented 1 year ago

@saschagrunert I was working on this Fri, & I opened a PR this morning! Please add to it, can be co-authored, too - https://github.com/kubernetes/enhancements/pull/3714

sallyom commented 1 year ago

@dashpole I've updated the description for this issue, and have a PR open to track for beta in 1.27, ptal if you have a chance, & thanks.

logicalhan commented 1 year ago

/stage beta

Atharva-Shinde commented 1 year ago

Hello @logicalhan @dashpole 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Atharva-Shinde commented 1 year ago

Hey again @logicalhan @dashpole Please try to get the KEP PR #3714 (addressing the changes mentioned above), merged before tomorrow's Enhancement Freeze :) The status of this enhancement is still marked as at risk

SergeyKanzhelev commented 1 year ago

@Atharva-Shinde, PR seems to be merged now. This KEP should be OK

marosset commented 1 year ago

This enhancement meets all the requirements to be tracked in v1.27.

Thanks @saschagrunert @sallyom @dashpole @SergeyKanzhelev !

katmutua commented 1 year ago

Hello @sallyom 👋🏾 !

@katmutua 1.27 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

If you already have existing open PRs please link them to the description so we can easily track them. Thanks!

saschagrunert commented 1 year ago

Thank you @katmutua, the placeholder is now available in https://github.com/kubernetes/website/pull/39904

Atharva-Shinde commented 1 year ago

Hey again @saschagrunert @vrutkovs 👋 Enhancements team here, Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

SergeyKanzhelev commented 1 year ago

@somalley, @dashpole do you want to GA in 1.28 as was planned in the issue description? It is not typical to do GA one release after beta as it typically doesn't give enough time to collect feedback.

saschagrunert commented 1 year ago

(I agree this should stay in beta for at least one more release)

dashpole commented 8 months ago

@saschagrunert Is GA planned for 1.30?

If it is, we need to add the 1.30 milestone, and the lead-opted-in label

saschagrunert commented 8 months ago

@dashpole not planned for 1.30, do we want to target it for 1.31?

dashpole commented 8 months ago

We definitely can, but we don't need to decide until the start of the 1.31 process. I'll check back in here then