search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.34k stars 1.44k forks source link

DRA: control plane controller ("classic DRA") #3063

Open pohly opened 2 years ago

pohly commented 2 years ago

Enhancement Description

pohly commented 2 years ago

/assign @pohly /sig node

ahg-g commented 2 years ago

do we have a discussion issue on this enhancement?

pohly commented 2 years ago

@ahg-g: with discussion issue you mean a separate issue in some repo (where?) in which arbitrary comments are welcome?

No, not at the moment. I've also not seen that done elsewhere before. IMHO at this point the open KEP PR is a good place to collect feedback and questions. I also intend to come to the next SIG-Scheduling meeting.

ahg-g commented 2 years ago

@ahg-g: with discussion issue you mean a separate issue in some repo (where?) in which arbitrary comments are welcome?

Yeah, this is what I was looking for, the issue would be under k/k repo.

No, not at the moment. I've also not seen that done elsewhere before.

That is actually the common practice, one starts a feature request issue where the community discusses initial ideas and the merits of the request (look for issues with label kind/feature). That is what I would expect in the discussion link.

IMHO at this point the open KEP PR is a good place to collect feedback and questions. I also intend to come to the next SIG-Scheduling meeting.

But the community have no idea what this is about yet, so better to have an issue discusses "What would you like to be added?" and "Why is this needed" beforehand. Also, meetings are attended by fairly small groups of contributors, having an issue tracking the discussion is important IMO.

pohly commented 2 years ago

In my work in SIG-Storage I've not seen much use of such a discussion issue. Instead I had the impression that the usage of "kind/feature" is discouraged nowadays.

https://github.com/kubernetes/kubernetes/issues/new?assignees=&labels=kind%2Ffeature&template=enhancement.yaml explicitly says

Feature requests are unlikely to make progress as issues. Please consider engaging with SIGs on slack and mailing lists, instead. A proposal that works through the design along with the implications of the change can be opened as a KEP.

This proposal was discussed with various people beforehand, now we are in the formal KEP phase. But I agree, it is hard to provide a good link to those prior discussions.

ahg-g commented 2 years ago

We use that in sig-scheduling, and it does serve as a very good place for initial rounds of discussions, discussions on slack and meetings are hard to reference as you pointed out.

I still have no idea what this is proposing, and I may not attend the next sig meeting for example...

gracenng commented 2 years ago

Hi @ ! 1.24 Enhancements team here. Checking in as we approach enhancements freeze in less than a week on 18:00pm PT on Thursday Feb 3rd Here’s where this enhancement currently stands:

The status of this enhancement is track as at risk. Thanks!

gracenng commented 2 years ago

The Enhancements Freeze is now in effect and this enhancement is removed from the release. Please feel free to file an exception.

/milestone clear

gracenng commented 2 years ago

Hi Patrick, tracked/yes will be applied when the KEP is merged and all requirements for Enhancement Freeze are met. We are definitely keeping an eye on this! Feel free to ping me once it's merged

On Tue, Mar 1, 2022 at 11:17 AM Patrick Ohly @.***> wrote:

@gracenng https://github.com/gracenng : an exception was requested and granted for this enhancement to move to GA in 1.24: https://groups.google.com/g/kubernetes-sig-release/c/sUpd2H1wxnk/m/lL_I6GT-BwAJ

Can you label it again as "tracked/yes"?

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/3063#issuecomment-1055774213, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCRLO46IYCBRTXXZE6EHGTU5ZUM3ANCNFSM5JCIMTQA . You are receiving this because you were mentioned.Message ID: @.***>

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

kerthcet commented 2 years ago

/remove-lifecycle stale

marosset commented 2 years ago

Hello @pohly 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

It looks like https://github.com/kubernetes/enhancements/pull/3064 will address everything in this list.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

marosset commented 2 years ago

Hello @pohly 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get #3064 reviewed and merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

Priyankasaggu11929 commented 2 years ago

With KEP PR #3064 merged now, the enhancement is ready for the upcoming Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

sethmccombs commented 2 years ago

Hello @pohly! :wave:,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

parul5sahoo commented 2 years ago

Hi @pohly 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

The status of the Enhancement is currently marked at-risk. And shall be marked tracked when all open PRs get merged.

As always, we are here to help should questions come up.

Thanks!!

pohly commented 1 year ago

This KEP needs to be moved to 1.26.

Priyankasaggu11929 commented 1 year ago

Thanks for the update @pohly.

/milestone clear

marosset commented 1 year ago

/milestone v1.26 /label lead-opted-in (I'm doing this on behalf of @ruiwen-zhao / SIG-node)

rhockenbury commented 1 year ago

/label tracked/yes /remove-label tracked/no

Atharva-Shinde commented 1 year ago

Hey @pohly 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26

Here's where this enhancement currently stands:

For this KEP, we would need to:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

derekwaynecarr commented 1 year ago

/milestone v1.26 /label lead-opted-in

Atharva-Shinde commented 1 year ago

Hello @pohly 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the action items mentioned in my comment above done before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

pohly commented 1 year ago

@Atharva-Shinde: I believe https://github.com/kubernetes/enhancements/pull/3502 will address the remaining opens, won't it?

It's been reviewed and is now awaiting approval.

rhockenbury commented 1 year ago

I have this marked as tracked but please update the KEP yaml to reflect the right latest-milestone v1.26.

pohly commented 1 year ago

PR https://github.com/kubernetes/enhancements/pull/3601 bumps the latest-milestone.

Atharva-Shinde commented 1 year ago

Hey @pohly 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

As always, we are here to help should questions come up. Thanks :)

cathchu commented 1 year ago

Hi there @pohly 👋 1.26 Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for 1.26 release. I see you've opened https://github.com/kubernetes/website/pull/37434. I'd like to confirm that all Docs related changes will be included in this PR.

If not, please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

sftim commented 1 year ago

I looked at https://github.com/kubernetes/kubernetes/pull/112981 and I'm concerned.

I saw several places where the API is defining not just lists of node names, but also limits on how many items can appear in those node lists. Elsewhere in Kubernetes - I'm thinking EndpointSlice - we've encountered problems with scaling and have gone to the effort of defining APIs to let us have and manage large lists, by splitting the information across multiple objects.

I recommend asking the SIG Scalability folks to take a look at this and see whether this proposed API design triggers similar questions. If it does, I recommend delaying even the alpha until we've got a sketch for how we'll deal with this, and what APIs we might need to let the mechanism scale.

Atharva-Shinde commented 1 year ago

Hey @pohly 👋, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow. Looks like we would at least need to get the code PR/s: https://github.com/kubernetes/kubernetes/pull/111023 (any other PRs?) merged before the code-freeze.

rhockenbury commented 1 year ago

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

leonardpahlke commented 1 year ago

Exception request submitted by @pohly has been accepted by the release team!

Your updated deadline to make any changes to your PR is 18:00 PST Friday 11th November 2022.

/milestone v1.26 /label tracked/yes /label lead-opted-in /remove-label tracked/no

krol3 commented 1 year ago

Hi @pohly ! here Carol Doc Lead from 1.26, I can't find the PR about documentation, I only see the placeholder to the blogs. cc: @cathchu

pohly commented 1 year ago

The second PR linked to in the description is the documentation: https://github.com/kubernetes/website/pull/37766/files

sftim commented 1 year ago

I've been looking at how we document this API.

Pretty much everything that has a kind in Kubernetes looks broadly idiomatic if you put a definite or indefinite article in front of it. However, PodScheduling is a bit weird.

(Fictional) examples:

Would we consider a rename for that alpha resource type? Future documentation writers will appreciate it.

pohly commented 1 year ago

Yes, we can definitely rename. At some point I suggested PodSchedulingState, but then we didn't pursue that aspect further.

sftim commented 1 year ago

Ideas:

pohly commented 1 year ago

Let's continue in https://github.com/kubernetes/kubernetes/issues/114283

marosset commented 1 year ago

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

alculquicondor commented 1 year ago

Any updates planning for this cycle? Even if a round of updates while remaining alpha?

pohly commented 1 year ago

We will work on a few things while keeping the feature itself in alpha.

The project board lists those: https://github.com/orgs/kubernetes/projects/95/views/4

alculquicondor commented 1 year ago

@marosset, if the enhancement is not switching stage, should we opt it in?

marosset commented 1 year ago

@marosset, if the enhancement is not switching stage, should we opt it in?

If there are significant user-facing changes (usually for enhancements in beta) that were called out in KEP updates you can opt in the enhancement to be tracked as 'Major Changes'. If there is minor incremental work being done the enhancement does not need to be tracked by the release team.

Hope this helps

alculquicondor commented 1 year ago

@pohly I think the list looks big enough to warrant the categorization as Major Changes. WDYT?

alculquicondor commented 1 year ago

cc @SergeyKanzhelev @klueska for a SIG Node POV

pohly commented 1 year ago

I don't know yet how much it will affect users, but the intention definitely is to do a significant amount of work towards beta, so yes, let's track it.

marosset commented 1 year ago

I don't know yet how much it will affect users, but the intention definitely is to do a significant amount of work towards beta, so yes, let's track it.

Is this just implementing work that is already outline in the KEP and marked required for beta or is alpha behavior as outlined in the KEP changing due to something like user-feedback or learning from the previous alpha implementation?

If it is the later, I would agree it should be tracked.

marosset commented 1 year ago

I don't know yet how much it will affect users, but the intention definitely is to do a significant amount of work towards beta, so yes, let's track it.

Is this just implementing work that is already outline in the KEP and marked required for beta or is alpha behavior as outlined in the KEP changing due to something like user-feedback or learning from the previous alpha implementation?

If it is the later, I would agree it should be tracked.

@salaxander too as FYI or for comment

pohly commented 1 year ago

We are continuing as described in the KEP.

alculquicondor commented 1 year ago

I would say just don't forget to update the implementation history after the k/k PRs merge