kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

DRA: control plane controller ("classic DRA") #3063

Open pohly opened 2 years ago

pohly commented 2 years ago

Enhancement Description

cyclinder commented 1 month ago

We haven't delved into whether the structured parameter will be able to meet our needs, and it will take some time. I can give you feedback on the results. 1.31 has removed the ResourceClass resource, so we had to make some changes to get ClassicDRA to run at 1.31, so we're considering moving directly to structured parameters.

aojea commented 1 month ago

It's important to note that it's not about supporting some existing solution. Instead, she is currently exploring both classic DRA and structured parameters and wants to have all options available until she reaches a conclusion of that exploration.

@pohly but this is still confusing, classic DRA has some limitations and we invested and decided to move with structured DRA, what is the point of exploring classic DRA? what happens if the result of the exploration is to use classic DRA? are we going to open the debate again?

thockin commented 1 month ago

I agree. I do not see any possible future where classic DRA is revived. "Exploring" can be done on 1.31 or 1.30 or ... - why do we need to keep it in 1.32?

jenshu commented 1 month ago

@pohly (enhancements team here) can you confirm if this is slated for deprecation in 1.32?

pohly commented 1 month ago

classic DRA has some limitations and we invested and decided to move with structured DRA, what is the point of exploring classic DRA?

Structured parameters has other limitations. That's why we are working on additional KEPs for it, and that is likely to continue for a while.

"Exploring" can be done on 1.31 or 1.30 or ... - why do we need to keep it in 1.32?

Perhaps because it's easier to install one version of Kubernetes and then try out different approaches? Just a thought.

can you confirm if this is slated for deprecation in 1.32?

I am not sure whether we have reached a consensus. Deadline for a decision is probably soon enough before KEP freeze so that we can still record a decision to remove it. If we keep it, no updates will be needed.

jenshu commented 1 month ago

@pohly ok thank you, I will mark this at risk for enhancement freeze for now, pending your decision.

Please keep in mind that the PRR freeze is coming up on Thursday 3rd October 2024 and the enhancements freeze is on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024

alculquicondor commented 1 month ago

Perhaps because it's easier to install one version of Kubernetes and then try out different approaches? Just a thought.

That's not a strong argument. Unless there is a compelling argument defending the need for classic DRA to stay one more release, I prefer we remove it ASAP. The more we keep it, the more vendors will depend on it and make it harder and harder to remove every passing release.

thockin commented 1 month ago

I agree. It also makes people think that we are hedging our bet around structured parameters, and I don't think we are. If there are truly shortcomings with it, and I accept that there are, and we will fix those forward.

pohly commented 1 month ago

I've created https://github.com/kubernetes/enhancements/pull/4904 to mark the KEP as "withdrawn" and notified folks on #wg-device-management.

kannon92 commented 4 weeks ago

@pohly can you update the PR description to include the latest changes for 1.32?

jenshu commented 3 weeks ago

1.32 Enhancements team here. I see the updates have been made to withdraw this KEP, and I've updated the status to tracked for enhancements freeze

rytswd commented 2 weeks ago

Hi @pohly 👋 -- this is Ryota (@rytswd) from the v1.32 Communications Team!

For the v1.32 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we are keen to hear if you would consider writing one for this withdrawal!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 30th Oct 2024? For more information about writing a blog, please find the blog contribution guidelines 📚

[!Tip] Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 30th Oct: Feature blog PR freeze
  • Monday, 25th Nov: Feature blogs ready for review
  • You can find more in the release document

[!Note] In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

jenshu commented 1 week ago

Hello @pohly 👋, v1.32 Enhancements team here.

With all the implementation (code related) PRs merged per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Additionally, please let me know if there are any other PRs in k/k that we should track for this KEP, so that we can maintain accurate status.

rytswd commented 6 days ago

Hi @pohly 👋, v1.32 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 30th Oct. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!