search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.46k stars 1.49k forks source link

Pod conditions around readiness to start containers after completion of pod sandbox creation #3085

Closed ddebroy closed 1 year ago

ddebroy commented 2 years ago

See https://github.com/kubernetes/enhancements/issues/4138 for latest update.

Enhancement Description

KEP work continues on : https://github.com/kubernetes/enhancements/issues/4138

ddebroy commented 2 years ago

/sig node

rhockenbury commented 2 years ago

Hi @ddebroy! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting alpha for 1.24.

Here’s where this enhancement currently stands:

Please plan to merge #3087 by enhancements freeze to complete the above items. The status of this enhancement is at risk. Thanks!

ddebroy commented 2 years ago

PRR for the KEP is complete for 1.24. Waiting on final reviews from sig-node.

gracenng commented 2 years ago

The Enhancements Freeze is now in effect and this enhancement is removed from the release. Please feel free to file an exception.

/milestone clear

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ddebroy commented 2 years ago

/remove-lifecycle stale

Priyankasaggu11929 commented 2 years ago

/milestone v1.25

Priyankasaggu11929 commented 2 years ago

Hello @ddebroy 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

Looks like for this one, we would need to update the open KEP PR https://github.com/kubernetes/enhancements/pull/3087 for following & get it merged by Enhancements Freeze:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ddebroy commented 2 years ago

I have updated the Test Plan section as recommended based on the latest template pointed out above.

Priyankasaggu11929 commented 2 years ago

Thanks for the quick update, @ddebroy 🙂

Priyankasaggu11929 commented 2 years ago

With KEP PR https://github.com/kubernetes/enhancements/pull/3087 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

didicodes commented 2 years ago

Hello @ddebroy 👋, 1.25 Release Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.


Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

parul5sahoo commented 2 years ago

Hi @ddebroy 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

parul5sahoo commented 2 years ago

Hi @ddebroy :wave:

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022, which is in two days.

please ensure that you have the following PR(s) merged before that :-

Thanks

ddebroy commented 2 years ago

https://github.com/kubernetes/kubernetes/pull/111358 has merged!

parul5sahoo commented 2 years ago

Thanks @ddebroy now the status is marked as tracked.

lujinda commented 2 years ago

excuse me. If this Condition is added, how can I distinguish whether it meets the PodHasNetwork condition for the existing Pod? @ddebroy

ddebroy commented 2 years ago

hi @lujinda can you please clarify your question (potentially with an example) a bit? Are you referring to how to find out if the condition was set?

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

ddebroy commented 1 year ago

/remove-lifecycle rotten

dchen1107 commented 1 year ago

/label lead-opted-in

dchen1107 commented 1 year ago

/milestone v1.27

k8s-ci-robot commented 1 year ago

@dchen1107: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to [this](https://github.com/kubernetes/enhancements/issues/3085#issuecomment-1411283065): >/label lead-opted-in > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mrunalp commented 1 year ago

/label lead-opted-in

ddebroy commented 1 year ago

/stage beta

ddebroy commented 1 year ago

/kind feature

npolshakova commented 1 year ago

Hello @ddebroy 👋, 1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

It looks like https://github.com/kubernetes/enhancements/pull/3778 will address most of these issues.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ddebroy commented 1 year ago

@npolshakova with https://github.com/kubernetes/enhancements/pull/3778 merged with PRR approval for Beta, can we consider this feature as ready for the 1.27 Freeze?

npolshakova commented 1 year ago

Looks good!

/remove-label tracked/no /label tracked/yes

npolshakova commented 1 year ago

Hi @ddebroy,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP. As always, we are here to help should questions come up. Thanks!

Rishit-dagli commented 1 year ago

Hi @ddebroy :wave:, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. Please feel free to reach out with any questions. Thanks!

npolshakova commented 1 year ago

Hi @ddebroy, this is the status as we approach code freeze today:

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

npolshakova commented 1 year ago

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear /remove-label tracked/yes /label tracked/no

ddebroy commented 1 year ago

We ran out of cycles for 1.27 and will try to get this in early 1.28.

qiutongs commented 1 year ago

Happy to help review the PRs.

kannon92 commented 1 year ago

Is the only thing outstanding for beta is to update the k/k code with the new condition name?

SergeyKanzhelev commented 1 year ago

/milestone v1.28

@ddebroy @kannon92 please comment if you do not plan to work on this.

Also please send the update to the kep.yaml to indicate the target milestone.

kannon92 commented 1 year ago

We are actively working on this for targeting 1.28.

https://github.com/kubernetes/kubernetes/pull/117702

https://github.com/kubernetes/website/pull/40945

are two active PRs we have targeting 1.28.

kannon92 commented 1 year ago

And I'll update kep.yaml next week.

SergeyKanzhelev commented 1 year ago

And I'll update kep.yaml next week.

Have you had a chance to send this PR?

SergeyKanzhelev commented 1 year ago

/label lead-opted-in

kannon92 commented 1 year ago

And I'll update kep.yaml next week.

Have you had a chance to send this PR?

I am sorry I missed this. I opened up a PR to correct the state.

https://github.com/kubernetes/enhancements/pull/4077

ruheenaansari34 commented 1 year ago

Hello @ddebroy 👋, 1.28 Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023.

This enhancement is targeting stage betaalpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to take care of:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with the appropriate stages as well. Thank you!

kannon92 commented 1 year ago

We are targeting alpha actually. I updated our KEP to reflect this.

ruheenaansari34 commented 1 year ago

@ddebroy @kannon92 👋🏼 Hey folks, gentle reminder that 1.28 Enhancements freeze is right around the corner. Please ensure KEP status is marked as implementable for latest-milestone: 1.28 here and merged into k/enhancements to meet KEP requirements.

The status of this enhancement is still marked as at risk. Please keep the issue description up-to-date with the appropriate stages as well. Thank you!

kannon92 commented 1 year ago

The PR was merged. Please let me know if you need anything more to make this not at risk.

Atharva-Shinde commented 1 year ago

Thanks @kannon92 :)

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀. The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well.

kannon92 commented 1 year ago

Can we change the stage of this to alpha? Not sure how to change that tag.

kannon92 commented 1 year ago

/assign