Add a new field maxRestartTimes to podSpec when running into RestartPolicyOnFailure

[kerthcet]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add a new field maxRestartTimes to podSpec when running into RestartPolicyOnFailure
• Kubernetes Enhancement Proposal: WIP
• Discussion Link: https://github.com/kubernetes/kubernetes/issues/65797
• Primary contact (assignee): @kerthcet
• Responsible SIGs:
  • sig/node
  • sig/apps
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.29
  • Beta release target (x.y): 1.31
  • Stable release target (x.y):
• [ ] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3339
  • [ ] Code (k/k) update PR(s):
  • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kerthcet]

/sig node apps

[kerthcet]

I think the goal of the KEP is clearly as the title describes, and the KEP is also on the way. Just want to make sure whether this feature will be accepted on top design. /assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[kerthcet]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[kerthcet]

/lifecycle rotten

[thockin]

Is this KEP actually being worked on?

[kerthcet]

em..., no time to working on this right now.

[SergeyKanzhelev]

@mimowo I wonder if this scenario support may be rolled into the https://github.com/kubernetes/enhancements/issues/3329? Not the new field, but the condition to be number of failures

[kerthcet]

But that's for job only, right? Or do you think this is also required for job users?

[mimowo]

@mimowo I wonder if this scenario support may be rolled into the #3329? Not the new field, but the condition to be number of failures

I prefer not to, unless for important reasons. We are in Beta already, and would prefer to limit the potential domino of feature extensions under the KEP (and delegate them to follow-up KEPs), but focus on bugs (as the remaining one being discussed here: https://github.com/kubernetes/enhancements/pull/3757). Also, for now, we decided to only enable podFailurePolicy when restartPolicy=Never. The reasons were recently discussed under the KEP, but generally it requires first deciding on the backoffLimit semantics in that case, which is currently only well defined only for restartPolicy=Never.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/3322#issuecomment-1455061109): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[kerthcet]

/reopen

[k8s-ci-robot]

@kerthcet: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/3322#issuecomment-1474629147): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/3322#issuecomment-1510620876): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[kerthcet]

/reopen

[k8s-ci-robot]

@kerthcet: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/3322#issuecomment-1520072096): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[SergeyKanzhelev]

/reopen

@kerthcet do you plan to work on this in 1.28?

[kerthcet]

Seems no pressure and no feedbacks on this KEP, but I'm planning to collect more convinced use cases, for 1.28, not quite sure.

[mimowo]

Heads up as I'm starting the KEP to add backoffLimitPerIndex for 1.28 (still in early phase of drafting): https://github.com/kubernetes/enhancements/pull/3967.

I'm thinking of scoping it to restartPolicy=Never. The maxRestartTimes could provide similar functionality when a pod's restartPolicy=OnFailure. I think the motivation for maxRestartTimes could be similar to the stories I describe.

[kerthcet]

Thanks @mimowo I'll read the KEP when I have time.

[SergeyKanzhelev]

Based on this comment: https://github.com/kubernetes/enhancements/pull/3967#discussion_r1185667857 - it sounds like you want to work on this KEP in 1.28. Should we track it for 1.28?

[kerthcet]

Yes, I'm working on the KEP.

[kerthcet]

FYI: KEP is ready for review.

[SergeyKanzhelev]

There is an active PR: https://github.com/kubernetes/enhancements/pull/3339

/remove-lifecycle rotten /milestone v1.28

[SergeyKanzhelev]

/label lead-opted-in

[SergeyKanzhelev]

/stage alpha

[ruheenaansari34]

Hello @kerthcet 👋, 1.28 Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023.

This enhancement is targeting stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.28
• [ ] KEP readme has a updated detailed test plan section filled out
• [ ] KEP readme has up-to-date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to take care of:

• Merging KEP update PR

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with the appropriate stages as well. Thank you!

[kerthcet]

We sill have several argus about the KEP and no sig node folk is reviewing. It's really at risk then.🤔

[ruheenaansari34]

@kerthcet 👋🏼 Gentle reminder that 1.28 Enhancements freeze is right around the corner. Please take care of merging KEP update PR to meet the KEP requirements.

The status of this enhancement is still marked as at risk. Please keep the issue description up-to-date with the appropriate stages as well. Thank you!

[Atharva-Shinde]

Hello @kerthcet 👋, 1.28 Enhancements Lead here. Unfortunately, this enhancement did not meet requirements for v1.28 enhancements freeze. Feel free to file an exception to add this back to the release tracking process. Thanks!

[Atharva-Shinde]

/milestone clear

[taniaduggal]

Hello @kerthcet ! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[Rishit-dagli]

@taniaduggal This is removed from 1.28 release so I have marked this as "removed form release" and there is no need for 1.28 docs PR

[SergeyKanzhelev]

@kerthcet do you plan to keep working on this in 1.29?

[kerthcet]

No I think, this will pending for one more release.

[rayandas]

Hello @kerthcet 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.29
• [ ] KEP readme has a updated detailed test plan section filled out
• [ ] KEP readme has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Update and merge PR https://github.com/kubernetes/enhancements/pull/3339

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[rayandas]

Hi @kerthcet 👋 checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like PR https://github.com/kubernetes/enhancements/pull/3339 will address most of the requirements. Let me know if I missed anything. Thanks.

[npolshakova]

Hello 👋, 1.29 Enhancements Lead here. Unfortunately, this enhancement did not meet requirements for v1.29 enhancements freeze. Feel free to file an exception to add this back to the release tracking process. Thanks!

/milestone clear

[salehsedghpour]

/remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[kerthcet]

/lifecycle frozen