search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

Add CPUManager policy option to align CPUs by Socket instead of by NUMA node #3327

Open klueska opened 2 years ago

klueska commented 2 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

arpitsardhana commented 2 years ago

PR for above enhancement: https://github.com/kubernetes/enhancements/pull/3334

Priyankasaggu11929 commented 2 years ago

/milestone v1.25

Priyankasaggu11929 commented 2 years ago

Hello @klueska, @arpitsardhana 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

Looks like for this one, we would need to update the open KEP PR https://github.com/kubernetes/enhancements/pull/3334 for following & get it merged by Enhancements Freeze:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

arpitsardhana commented 2 years ago

Thanks @Priyankasaggu11929 for heads up! I will update PR with test plan accordingly

arpitsardhana commented 2 years ago

@Priyankasaggu11929 Updated the KEP PR #3334 with test plan section and adhered to format Let me know if you see any further concerns

Priyankasaggu11929 commented 2 years ago

Hello @arpitsardhana, thanks for the heads up & quick update 🙂

Now we require to just get the open KEP PR merged before the updated enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT. Thank you!

Just one nit, we need marking this checkbox, in the Test Plan section:

[ ] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.

arpitsardhana commented 2 years ago

Updated the PR with above nit! Thanks

Priyankasaggu11929 commented 2 years ago

With KEP PR https://github.com/kubernetes/enhancements/pull/3334 merged, the PR is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as Tracked. Thank you so much! 🙂

Atharva-Shinde commented 2 years ago

Hi @klueska, Enhancements team here again 👋

Checking in as we approach Code Freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following items are completed before the code-freeze:

Currently, the status of the enhancement is marked as at-risk

Thanks :)

arpitsardhana commented 2 years ago

Pull Request for feature: https://github.com/kubernetes/kubernetes/pull/111278

Atharva-Shinde commented 2 years ago

Hey @arpitsardhana, reaching out again as we approach Code Freeze at 01:00 UTC on this Wednesday i.e 3rd August 2022. Try to get this PR https://github.com/kubernetes/kubernetes/pull/111278 merged before the code-freeze :) The status of the enhancement is still marked as at-risk

arpitsardhana commented 2 years ago

Issues to track for beta:

  1. Evaluate if AlignBySocket should be part of TopologyManager
  2. Correct place for ValidateStaticPolicyOptions()
  3. Unified container manager test cases covering multiple hint provider (under "pkg/kubelet/cm")
  4. Improve FakeManager implementation to be more generic

Noted all issues to be tracked for Beta @klueska @fromanirh @swatisehgal

Priyankasaggu11929 commented 2 years ago

With k/k code PR https://github.com/kubernetes/kubernetes/pull/111278 merged now, this enhancement is marked as tracked for 1.25 code freeze. Thank you so much @arpitsardhana.

klueska commented 2 years ago

Just out of curiosity, why was this moved to "tracked/no"? The code for this merged as an alpha release in 1.25 and we plan to transition it to beta in 1.26. Shouldn't it be stage/alpha instead?

Atharva-Shinde commented 2 years ago

Hey @klueska 👋 As per the new release opt-in process SIG Leads are supposed to apply lead-opted-in label to the KEP issue to opt it in for the release cycle.

Please refer: https://groups.google.com/a/kubernetes.io/g/dev/c/R1afPL7zpT4/m/lKv7eg3jBwAJ https://www.kubernetes.dev/blog/2022/09/09/enhancements-opt-in/ Example KEP issue: https://github.com/kubernetes/enhancements/issues/3325#issuecomment-1238296874

cc: @rhockenbury

klueska commented 2 years ago

Even though the code to bring this enhancement to alpha has already merged? I would expect a stage/alpha label in this case.

rhockenbury commented 2 years ago

Hi @klueska

Yes, enhancements need to opt into the current release cycle for when they are planned to graduate. We'll get this opted into v1.26 for beta, but for graduation to stable later on, you'll need to opt in again. The opt in process just involves applying the lead-opted-in label. This is targeting beta for 1.26 so the stage label should reflect that target stage. Let me know if you have any more questions.

/label lead-opted-in /milestone v1.26 /label tracked/yes /remove-label tracked/no /stage beta

Atharva-Shinde commented 2 years ago

Hey @klueska @arpitsardhana 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26

Here's where this enhancement currently stands:

For this KEP, we would need to:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

arpitsardhana commented 2 years ago

@Atharva-Shinde Thanks for reminder. As of now we plan to keep feature in alpha. Since there is additional work we want to do I will update kep.yaml shortly to reflect that

k8s-ci-robot commented 2 years ago

@Atharva-Shinde: The label(s) /label stage/alpha cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, lead-opted-in, tracked/no, tracked/out-of-tree, tracked/yes

In response to [this](https://github.com/kubernetes/enhancements/issues/3327#issuecomment-1255451967): >/label stage/alpha >remove stage/beta Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Atharva-Shinde commented 2 years ago

/stage alpha /remove-label stage/beta

k8s-ci-robot commented 2 years ago

@Atharva-Shinde: The label(s) /remove-label stage/beta cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, lead-opted-in, tracked/no, tracked/out-of-tree, tracked/yes

In response to [this](https://github.com/kubernetes/enhancements/issues/3327#issuecomment-1255459613): >/stage alpha >/remove-label stage/beta Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Atharva-Shinde commented 2 years ago

@Atharva-Shinde Thanks for reminder. As of now we plan to keep feature in alpha. Since there is additional work we want to do I will update kep.yaml shortly to reflect that

Hey @arpitsardhana, thanks for the update. I've updated the issue labels and have edited my comment with alpha stage. For further communications I've now tagged you in the comment too :)

Atharva-Shinde commented 2 years ago

Hello @klueska @arpitsardhana 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the action items mentioned in my comment above done before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

arpitsardhana commented 2 years ago

@Atharva-Shinde I have updated beta & stable target for KEP-3327. I did see need to update prod-readiness.

MR: https://github.com/kubernetes/enhancements/pull/3590 Let’s me know if any additional work i required.

rhockenbury commented 2 years ago

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

arpitsardhana commented 2 years ago

@rhockenbury @Atharva-Shinde I am not sure if i understand the action. I have raised MR to set the beta target to 1.27. The feature is alpha in 1.26 and we want to keep the status quo such as keep it alpha in 1.27

I have raised MR to update the beta target in KEP. My question is, do we need anything additional? I dont intend to commit any extra code with regards to align-by-socket, does that mean it wont be available in 1.26 even as alpha?

rhockenbury commented 2 years ago

No, we are set here and nothing additional is needed. This will remain in alpha for 1.26, and you'll need to opt in again when the 1.27 cycle starts to graduate the enhancements to beta.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

ffromani commented 1 year ago

/remove-lifecycle rotten

SergeyKanzhelev commented 1 year ago

is this KEP will be worked on in 1.28?

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ffromani commented 9 months ago

/remove-lifecycle stale

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ffromani commented 6 months ago

/remove-lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ffromani commented 3 months ago

/remove-lifecycle stale

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale