search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.33k stars 1.44k forks source link

Allow StatefulSet to control start replica ordinal numbering #3335

Open pwschuurman opened 2 years ago

pwschuurman commented 2 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pwschuurman commented 1 year ago

/sig multicluster

JeremyOT commented 1 year ago

/label lead-opted-in

rhockenbury commented 1 year ago

/milestone v1.26 /label tracked/yes /stage alpha

ruheenaansari34 commented 1 year ago

Hello @pwschuurman 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to merge https://github.com/kubernetes/enhancements/pull/3336, which will take care of above requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 commented 1 year ago

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to get the PR https://github.com/kubernetes/enhancements/pull/3336 merged.

pwschuurman commented 1 year ago

Hi @ruheenaansari34, #3336 has been merged.

pwschuurman commented 1 year ago

/sig apps

pwschuurman commented 1 year ago

/remove-sig multicluster

rhockenbury commented 1 year ago

Thanks, the enhancements team has this marked as tracked now.

soltysh commented 1 year ago

/remove-lifecycle stale

pwschuurman commented 1 year ago
pwschuurman commented 1 year ago

Hi @ruheenaansari34 @rhockenbury, this is currently marked as tracked by sig-multicluster, but the KEP is in sig-apps. Can the enhancements spreadsheet be updated to reflect the current state of this enhancement? https://github.com/orgs/kubernetes/projects/98/views/11?sortedBy%5Bdirection%5D=asc&sortedBy%5BcolumnId%5D=15217749&filterQuery=sig%3Asig-multicluster

rhockenbury commented 1 year ago

Thanks. Fixed.

parul5sahoo commented 1 year ago

Hi @pwschuurman 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

For this enhancement, please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked.

As always, we are here to help should questions come up. Thanks!

cathchu commented 1 year ago

Hi there @pwschuurman 👋 1.26 Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for 1.26 release. I see you've opened https://github.com/kubernetes/website/pull/37224. I'd like to confirm that all Docs related changes will be included in this PR.

If not, please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

pwschuurman commented 1 year ago

Hi there @pwschuurman wave 1.26 Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for 1.26 release. I see you've opened kubernetes/website#37224. I'd like to confirm that all Docs related changes will be included in this PR.

If not, please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

Thanks @cathchu, yes ubernetes/website/pull/37224 is the only documentation associated with this PR. I do have a blog as well, but this is tracked by the communications team.

parul5sahoo commented 1 year ago

Hey @pwschuurman,

As the Code freeze is just a day away, just wanted to confirm that there are no other open PRs in the K/K repo or any repo in general for this enhancement except for the ones outlined in the issues description? Please try to get the open PRs merged before code freeze, so that the enhancement can be marked tracked.

pwschuurman commented 1 year ago

Hi @parul5sahoo, yes this is the only k/k PR. There arare two other PRs, one for documentation and one for the blog post. Working on getting the k/k PR submitted today

parul5sahoo commented 1 year ago

Please try to get it merged before Code Freeze.

rhockenbury commented 1 year ago

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

pwschuurman commented 1 year ago

Hi @rhockenbury I just filed for an exception request: https://groups.google.com/g/kubernetes-sig-apps/c/SqUMOWxwwpo

This exception is just pending on a single PR (https://github.com/kubernetes/kubernetes/pull/112744), which has been signed off by sig-apps and is just pending final API review.

leonardpahlke commented 1 year ago

exception request accepted

/milestone v1.26 /label tracked/yes /label lead-opted-in /remove tracked/no

leonardpahlke commented 1 year ago

/remove-label tracked/no

marosset commented 1 year ago

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

soltysh commented 1 year ago

@pwschuurman are you planning to promote this to beta in 1.27?

pwschuurman commented 1 year ago

@soltysh Yes, I would like to promote to beta in 1.27. Working on the testing requirements for KEP in beta.

pwschuurman commented 1 year ago

@soltysh Would you be able to opt this KEP in for 1.27 release milestone (https://www.kubernetes.dev/blog/2022/09/09/enhancements-opt-in/)?

soltysh commented 1 year ago

/label lead-opted-in /milestone v1.27 /stage beta

pwschuurman commented 1 year ago

@soltysh Do you mind to take a look at https://github.com/kubernetes/kubernetes/pull/115468? I'd like to get the e2e tests submitted and running in testgrid (https://testgrid.k8s.io/google-gce#gci-gce-alpha-enabled-default) so we can have a clear signal prior to promoting the feature flag.

soltysh commented 1 year ago

@pwschuurman let's start with just that integration for now (from https://github.com/kubernetes/kubernetes/pull/115466) as a starting point (which is already tagged and should merge shortly), and when promoting to beta and enabling the feature permanently we'll merge https://github.com/kubernetes/kubernetes/pull/115468, wdyt?

marosset commented 1 year ago

Hello @pwschuurman 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this enhancement it looks like https://github.com/kubernetes/enhancements/pull/3768 will address all of these requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

marosset commented 1 year ago

With #3768 this enhancement is ready to be tracked for v1.27 Thanks!

marosset commented 1 year ago

Hi @pwschuurman :wave:,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

pwschuurman commented 1 year ago

Hi @marosset,

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Both of these are pending on API review for https://github.com/kubernetes/kubernetes/pull/115260, but will be ready to merge after this approval.

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

I also have a PR in kube-state-metrics: https://github.com/kubernetes/kube-state-metrics/pull/1959. I'm assuming this does not need to be merged by code freeze, since it's not in the k/k repo?

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 3 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/3335#issuecomment-2009067098): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atiratree commented 1 month ago

This can be graduated to GA. @pwschuurman could you pick this up?

/remove-lifecycle rotten /reopen

k8s-ci-robot commented 1 month ago

@atiratree: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/3335#issuecomment-2140260486): >This can be graduated to GA. @pwschuurman could you pick this up? > >/remove-lifecycle rotten >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
pwschuurman commented 1 month ago

@atiratree Yes, I can graduate this to GA

pwschuurman commented 1 month ago

@soltysh I'd like to target 1.31 release milestone for stable promotion. Would you be able to opt-in this KEP?

soltysh commented 1 month ago

/label lead-opted-in /stage alpha /milestone v1.31

soltysh commented 1 month ago

/stage stable

dipesh-rawat commented 1 month ago

Hello @pwschuurman 👋, 1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage stable for 1.31 (correct me, if otherwise).

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following: (It looks like https://github.com/kubernetes/enhancements/pull/4694 will address most of the pending issues)

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

dipesh-rawat commented 4 weeks ago

Hi @pwschuurman 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/3335#issuecomment-2153686809 that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

soltysh commented 4 weeks ago

@dipesh-rawat which bits exactly are missing, I've looked at the comment you've mentioned above and it looks like https://github.com/kubernetes/enhancements/pull/4694 resolved them all, no?

dipesh-rawat commented 4 weeks ago

@soltysh I see the pull request https://github.com/kubernetes/enhancements/pull/4694 was merged after the reminder comment was posted. With everything now merged, all the requirements are in place, and this enhancement looks good.

dipesh-rawat commented 4 weeks ago

Hello @pwschuurman 👋, 1.31 Enhancements team here.

Now that PR https://github.com/kubernetes/enhancements/pull/4694 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!