search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.39k stars 1.45k forks source link

Kubelet Evented PLEG for Better Performance #3386

Open harche opened 2 years ago

harche commented 2 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

harche commented 2 years ago

/sig-node

Priyankasaggu11929 commented 2 years ago

Hello @harche 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

Looks like for this one, we would need to update the following:

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

haircommander commented 2 years ago

I opened https://github.com/kubernetes/enhancements/pull/3410 to target at 1.25

Priyankasaggu11929 commented 2 years ago

/sig node

Priyankasaggu11929 commented 2 years ago

With KEP PR https://github.com/kubernetes/enhancements/pull/3410 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

Priyankasaggu11929 commented 2 years ago

Hello @haircommander @harche 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

I was able to find the following draft k/k PRs for the KEP:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open/draft k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Thank you for keeping the issue description up-to-date!

harche commented 2 years ago

Thanks @Priyankasaggu11929 for reaching out. I am planning to raise a PR by coming Monday.

harche commented 2 years ago

@Priyankasaggu11929 I just raised a PR - https://github.com/kubernetes/kubernetes/pull/111384

Priyankasaggu11929 commented 2 years ago

Hello @harche 👋

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022 (which is almost 2 days from now)

Please plan to have the open k/k PR merged before then.

The status of this enhancement is currently marked as at risk

Thank you

harche commented 2 years ago

API Changes PR - https://github.com/kubernetes/kubernetes/pull/111642

Priyankasaggu11929 commented 2 years ago

Hello :wave:, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

harche commented 2 years ago

@Priyankasaggu11929 Request for the exception has been raised - https://groups.google.com/g/kubernetes-sig-node/c/H_jmCppaurU/m/vwOzc-EFAAAJ

marosset commented 1 year ago

/milestone v1.26 /label lead-opted-in (I'm doing this on behalf of @ruiwen-zhao / SIG-node)

rhockenbury commented 1 year ago

/stage alpha /label tracked/yes /remove-label tracked/no

derekwaynecarr commented 1 year ago

/milestone v1.26 /label lead-opted-in

(this is a carry over from prior release, hope it makes alpha)

rhockenbury commented 1 year ago

Hello @harche, @haircommander, and @ruiwen-zhao 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to open a PR to make changes to the KEP yaml and KEP readme.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

harche commented 1 year ago

@rhockenbury Link to the PR - https://github.com/kubernetes/enhancements/pull/3575

rhockenbury commented 1 year ago

Thanks, please plan to get https://github.com/kubernetes/enhancements/pull/3575 merged up before enhancements freeze.

ruiwen-zhao commented 1 year ago

@rhockenbury https://github.com/kubernetes/enhancements/pull/3575 is now merged and it should check all the boxes in https://github.com/kubernetes/enhancements/issues/3386#issuecomment-1266093148

rhockenbury commented 1 year ago

Thanks, I have it marked as tracked now.

Atharva-Shinde commented 1 year ago

Hey @harche @ruiwen-zhao @haircommander 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

As always, we are here to help should questions come up. Thanks :)

katmutua commented 1 year ago

Hello @harche ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. As a reminder, please link all of your docs PR to this issue so we can easily track it.

harche commented 1 year ago

@katmutua Considering this feature is just alpha, I am not sure if we need to have docs.

cc @haircommander @ruiwen-zhao

krol3 commented 1 year ago

Hi @harche , here Carol from the Doc Lead of 1.26, I think we need to update the Kubernetes documentation features with alpha, for example here cc @reylejano

reylejano commented 1 year ago

@harche , For 1.26, since this enhancement has a feature gate of EventedPLEG, this should be added to the feature gates page in the Feature gates for Alpha or Beta features table: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

harche commented 1 year ago

Thanks @katmutua @krol3 and @reylejano. I have created a doc PR https://github.com/kubernetes/website/pull/37715 to add EventedPLEG in the features table.

harche commented 1 year ago

cc @swghosh @rphillips

Atharva-Shinde commented 1 year ago

Hey @harche @ruiwen-zhao @haircommander 👋, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow. Looks like we would at least need to get the code PR/s: https://github.com/kubernetes/kubernetes/pull/111384 (any other PRs?) merged before the code-freeze.

rhockenbury commented 1 year ago

With https://github.com/kubernetes/kubernetes/pull/111384 merged, we have this marked as tracked for code freeze.

harche commented 1 year ago

Hey @harche @ruiwen-zhao @haircommander wave, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow. Looks like we would at least need to get the code PR/s: kubernetes/kubernetes#111384 (any other PRs?) merged before the code-freeze.

Not directly a code PR, but there is this doc PR - https://github.com/kubernetes/website/pull/37715

marosset commented 1 year ago

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

harche commented 1 year ago

/label lead-opted-in

derekwaynecarr commented 1 year ago

/milestone v1.27 /label lead-opted-in /stage beta

k8s-ci-robot commented 1 year ago

@harche: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to [this](https://github.com/kubernetes/enhancements/issues/3386#issuecomment-1414403718): >/label lead-opted-in Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
marosset commented 1 year ago

Hello @harche, @haircommander, @ruiwen-zhao 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this enhancement, it looks like https://github.com/kubernetes/enhancements/issues/3386 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

harche commented 1 year ago

Hello @harche, @haircommander, @ruiwen-zhao wave, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.27
  • [x] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3386 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@marosset We are aiming to graduate this feature to beta.

harche commented 1 year ago

@marosset I see that this enhancement has been moved to 1.27 tracking board but the tag on this issue still says tracking/no. Not sure if I am missing something.

harche commented 1 year ago
marosset commented 1 year ago

This enhancement meets all of the requirements to be included in v1.27 and is now tracked for the release. Thanks @harche !

marosset commented 1 year ago

Hi @harche, @haircommander, @ruiwen-zhao :wave:,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

taniaduggal commented 1 year ago

Hi @harche 👋 , I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release. Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. Please feel free to reach out with any questions. Thanks!

harche commented 1 year ago

Thanks @taniaduggal. I have created a PR in k8s/website - https://github.com/kubernetes/website/pull/39913

SergeyKanzhelev commented 1 year ago

Wanted to post it here: https://kubernetes.slack.com/archives/C05KQLJEWHX/p1692383024035069

We see from Containerd that events may overflow and not being send to kubelet. Which will lead to wrong results.

Before moving this forward we need to understand how is it happened and whether we see it in other cases. Loosing events will result in bad outcome and hard to troubleshoot bugs

pacoxu commented 10 months ago

Recent issues around this KEP:

pacoxu commented 8 months ago

I opened https://github.com/kubernetes/kubernetes/pull/122124 to fix the known issue mentioned v1.29.

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 2 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/3386#issuecomment-2157289269): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hpx7 commented 2 months ago

Should this be reopened?