search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Remove transient node predicates from KCCM's service controller #3458

Open alexanderConstantinescu opened 2 years ago

alexanderConstantinescu commented 2 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

salehsedghpour commented 8 months ago

Hello @alexanderConstantinescu and @thockin 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

alexanderConstantinescu commented 8 months ago

@salehsedghpour : I made a mistake in the last release and got a prr-review for Stable, but forgot to update the code afterwards. In this release we're only updating the code and the prr-review file already exists, see: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-network/3458.yaml

Is this fine?

salehsedghpour commented 8 months ago

Yes, thanks for the clarification. With this information, this enhancements is now tracked for enhancement freeze.

chanieljdan commented 7 months ago

Hi @alexanderConstantinescu and @thockin 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

a-mccarthy commented 7 months ago

Hi @thockin,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

salehsedghpour commented 7 months ago

Hey again @alexanderConstantinescu and @thockin 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

For this enhancement, I couldn't find any (open) PRs in k/k. With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

alexanderConstantinescu commented 7 months ago

@salehsedghpour : this is the only PR which was needed for this release: https://github.com/kubernetes/kubernetes/pull/122961 - the implementation was done a while ago. This PR just promotes the feature to stable

salehsedghpour commented 7 months ago

@alexanderConstantinescu thanks for clarification. As https://github.com/kubernetes/kubernetes/pull/122961 is already merged, this can now be marked as tracked for code freeze.

May you please also make sure that this PR is added to issue description as well?

salehsedghpour commented 7 months ago

@alexanderConstantinescu, Enhancements team here! As this enhancement is targeting stable for this release, may you please update the status field in the kep.yaml file to implemented after code PRs are merged and the feature gates are removed.

alexanderConstantinescu commented 7 months ago

Hi @salehsedghpour : just to confirm: this feature is going GA in 1.30, so we will remove the feature gate in 1.31. Should I mark it implemented in 1.31 or 1.30 ?

salehsedghpour commented 7 months ago

Thanks @alexanderConstantinescu, with this please consider marking it as implemented in 1.31.

alexanderConstantinescu commented 7 months ago

Thanks @alexanderConstantinescu, with this please consider marking it as implemented in 1.31.

Will do!

danwinship commented 5 months ago

@alexanderConstantinescu can you update the checklist in the initial comment with the current state? (Like, it currently shows that alpha is incomplete, but my understanding from reading the comments here is that it's actually GA.)

alexanderConstantinescu commented 5 months ago

I've updated the description to this PR, should be up-to-date now.

thockin commented 5 months ago

GA'ed in 30, Cleanup in 32

sreeram-venkitesh commented 4 months ago

Hi! v1.31 Enhancements lead here 👋🏼

I'm assuming the status will be updated to implemented in v1.32 along with the cleanup, right? I'll remove the lead-opted-in label and remove this KEP from the v1.31 tracking board. Please let me know if this works.

/remove-label lead-opted-in

alexanderConstantinescu commented 4 months ago

GA'ed in 30, Cleanup in 32

@thockin : isn't it cleanup in 31? Ref: https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L1144 - might be that the comment is wrong and that we need to let it soak for 2 releases in stable?

thockin commented 4 months ago

Unless I am losing my mind, cleanup is GA+2

Shubham82 commented 2 months ago

Hi @alexanderConstantinescu, as discussed above do you have any plan to update the comment mentioned in the kube_feature.go i.e. instead of GA in 1.30, remove in 1.31 it should be GA in 1.30, remove in 1.32

StableLoadBalancerNodeSet: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // GA in 1.30, remove in 1.32

Shubham82 commented 2 months ago

Hi @alexanderConstantinescu, as discussed above do you have any plan to update the comment mentioned in the kube_feature.go i.e. instead of GA in 1.30, remove in 1.31 it should be GA in 1.30, remove in 1.32

StableLoadBalancerNodeSet: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // GA in 1.30, remove in 1.32

I will update it.

Shubham82 commented 2 months ago

I have Fixed comment in following PR: https://github.com/kubernetes/kubernetes/pull/126383 PTAL!