search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.34k stars 1.44k forks source link

СRI image pulling with progress notification #3542

Open byako opened 1 year ago

byako commented 1 year ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

byako commented 1 year ago

/sig node

k8s-ci-robot commented 1 year ago

@byako: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes/enhancements/issues/3542#issuecomment-1257586883): >/sig sig-node Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
byako commented 1 year ago

/sig node

marosset commented 1 year ago

/milestone v1.26 /label lead-opted-in (I'm doing this on behalf of @ruiwen-zhao / SIG-node)

rhockenbury commented 1 year ago

/stage alpha /label tracked/yes

derekwaynecarr commented 1 year ago

/remove-label lead-opted-in

This design needs more time in SIG Node and would be reviewed during 1.26 for evaluation in 1.27.

rhockenbury commented 1 year ago

/label tracked/no /remove-label tracked/yes /milestone clear

byako commented 1 year ago

The design is proposed now in KEP PR.

rhockenbury commented 1 year ago

Just want to clarify - in #3547, it looks like the milestones are targeting v1.26. Based on a prior comment from @derekwaynecarr, we have this enhancement as Removed from Milestone. Let me know if you do in fact want to opt in for the v1.26 cycle.

byako commented 1 year ago

Yes, @rhockenbury, that is the intention, if the proposal is approved or agreed for its details to be ironed out during v1.26 cycle - we'd like to opt this into v1.26 cycle.

rhockenbury commented 1 year ago

I can opt it in but it's going to be pretty tight to meet the requirements for enhancements freeze since freeze will happen in a few hours.

/label lead-opted-in /label tracked/yes /remove-label tracked/no

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk.

rhockenbury commented 1 year ago

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

dvasilen commented 1 year ago

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

If I read this correctly, this feature, much needed by many, will not make it to 1.26... It has been in the pipeline for too long. Hopefully, we'll see it implemented in the next release.

byako commented 1 year ago

I presume you meant 1.27, since 1.26 was released almost two months ago. I'll try to progress with it for 1.27, but code freeze is in one month, so there is a risk. I've been busy with primary-work related tasks, unfortunately, but I'm still committed to this KEP. Apologies for the delay.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/3542#issuecomment-1464923186): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

@dvasilen: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to [this](https://github.com/kubernetes/enhancements/issues/3542#issuecomment-1464925527): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
byako commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@byako: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/3542#issuecomment-1465668656): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
byako commented 1 year ago

Moving to 1.28, had no time this quarter.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/enhancements/issues/3542#issuecomment-1504848732): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
byako commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@byako: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/3542#issuecomment-1504853668): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
byako commented 1 year ago

/remove-lifecycle rotten

SergeyKanzhelev commented 1 year ago

@byako do you plan to work on this for 1.28 release?

byako commented 1 year ago

Yes, @SergeyKanzhelev , I've started today with this as main task.

SergeyKanzhelev commented 1 year ago

@byako can you mark the PR https://github.com/kubernetes/enhancements/pull/3547 as non-draft when it is ready for review. I see you updated version in PR's kep.yaml so applying milestone here:

/milestone v1.28

byako commented 1 year ago

Sure, I intend to present PoC for kubelet implementation on next sig-node meeting, I believe that is what was requested for CRI API review, based on the comments then I'll switch it to non-draft. Thanks for the tip.

byako commented 1 year ago

Seems that we forgot to label this, it's included in 1.28 KEP planning, but not in the 1.28 Enhancements tracking.

/label lead-opted-in

k8s-ci-robot commented 1 year ago

@byako: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to [this](https://github.com/kubernetes/enhancements/issues/3542#issuecomment-1596674723): >Seems that we forgot to label this, it's included in 1.28 KEP planning, but not in the 1.28 Enhancements tracking. > >/label lead-opted-in Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Atharva-Shinde commented 1 year ago

Hey @byako, as the enhancements freeze has begun since 16th June 2023, this KEP now needs an exception request to get into the 1.28 release cycle. Please file an exception request ASAP so that it can be reviewed by the PRR team and SIG leads :)

byako commented 1 year ago

Moved to 1.29

Rishit-dagli commented 1 year ago

/milestone clear

saschagrunert commented 11 months ago

@byako do you need support here in 1.29?

byako commented 10 months ago

Thanks @saschagrunert, I actually don't know. reading https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md, my next step is to file for PRR review. So I'll do that, that's what I overlooked in 1.28 cycle.

saschagrunert commented 10 months ago

@byako exactly. Let's also check with @kubernetes/sig-node-feature-requests that it's tracked for 1.29. :+1:

byako commented 10 months ago

At least it was present in tracking project https://github.com/orgs/kubernetes/projects/161

saschagrunert commented 10 months ago

Yes, but SIG Node leads have to opt-in as well.

SergeyKanzhelev commented 10 months ago

/label lead-opted-in /milestone v1.29

@byako @saschagrunert who should be marked as a primary contact for this KEP?

byako commented 10 months ago

@SergeyKanzhelev I'm fine with being a primary contact, I've some bandwidth for this this quarter.

salehsedghpour commented 10 months ago

Hello @byako 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage alpha for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

byako commented 10 months ago

Changed status to implementable, waiting for sig-node approvers to give an approval for KEP PR.

salehsedghpour commented 9 months ago

Hi @byako , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like https://github.com/kubernetes/enhancements/pull/3547 will address most of the requirements.

Let me know if I missed anything. Thanks!

byako commented 9 months ago

That's right, I've tried to address everything there was to address. Let's see if I can get anyone to approve anything.

npolshakova commented 9 months ago

Hello 👋, 1.29 Enhancements Lead here. Unfortunately, this enhancement did not meet requirements for v1.29 enhancements freeze. Feel free to file an exception to add this back to the release tracking process. Thanks!

/milestone clear

drigz commented 7 months ago

@byako I'm not sure whether I can help, but is there a particular person or group that you're waiting for review or approval from?

We're running Kubernetes in edge environments with slow downlinks, sometimes as low as 10 Mbps, so this would be really valuable feature and much more friendly than my current hack (watch ls -s /var/lib/containerd/io.containerd.content.v1.content/ingest/). Thank you for getting it to this point!

byako commented 7 months ago

@drigz, I'm happy to see that someone else is interested in this feature! Long story short - this did not make is into 1.28, 1.29 either because of a bad luck or miscommunication, or both. See KEP PR https://github.com/kubernetes/enhancements/pull/3547

I'll try to make this happen in 1.30, which starts about now.

The KEP itself consists of two parts: the CRI protocol part and Kubelet implementation part. What needs to be done still is Kubelet implementation part of this KEP, it has to be re-designed. SIG-scalability had concerns about impact of this feature at scale, and there were alternative implementation suggestions. The CRI protocol change appears to be fine, but I failed to secure the approval label, that seems to be just a formality.

In last cycle we agreed to remove the Kubelet implementation part from the KEP because there was too little time left to iron it out, but that didn't help either. Now that the new cycle is upon us, I think we can try to come up with new Kubelet implementation suggestion and hopefully both of them will be approved. If not - we can then push harder this time to get at least CRI change in 1.30.

I'm not sure how much time I will have in 1.30 cycle for this KEP, but there will be some. We'll see at next SIG-node meeting if I'm still driving this KEP or if someone else has more time for it than I do.