Introduce `MatchLabelKeys` to Pod Affinity and Pod Anti Affinity

[sanposhiho]

Enhancement Description

• One-line enhancement description (can be used as a release note): Introduce MatchLabelKeys to Pod Affinity and Pod Anti Affinity
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity
• Discussion Link: https://github.com/kubernetes/kubernetes/issues/112947
• Primary contact (assignee): @sanposhiho
• Responsible SIGs: sig/scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): v1.29
  • Beta release target (x.y): v1.30
  • Stable release target (x.y): v1.32
• [x] Alpha
  • [x] KEP (k/enhancements) update PR(s):
  • 1.27 https://github.com/kubernetes/enhancements/pull/3651
  • https://github.com/kubernetes/enhancements/pull/4069
  • [x] Code (k/k) update PR(s):　
  • https://github.com/kubernetes/kubernetes/pull/116065
  • [x] Docs (k/website) update PR(s):
  • https://github.com/kubernetes/website/pull/43812
• [ ] Beta
  • [x] KEP (k/enhancements) update PR(s):
  • 1.30 https://github.com/kubernetes/enhancements/pull/4450
  • 1.31 https://github.com/kubernetes/enhancements/pull/4627
  • [x] Code (k/k) update PR(s):
  • 1.29 https://github.com/kubernetes/kubernetes/pull/116065
  • 1.31 https://github.com/kubernetes/kubernetes/pull/123638
  • [ ] Docs (k/website) update(s):
  • https://github.com/kubernetes/website/pull/45181
  • https://github.com/kubernetes/website/pull/46833

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig scheduling /assign

[sanposhiho]

@kubernetes/sig-scheduling-leads Do you think we can work on it this release? Or should postpone until the next release?

[Huang-Wei]

I took a review and I think we can include it in 1.27.

/label lead-opted-in

[sanposhiho]

@Huang-Wei Thanks! I'll take a look and modify KEP this weekend. Do we need to add the milestone to track this issue as a v1.27 feature? If so, could you? (I don't have permission to add milestone on it.) https://github.com/kubernetes/enhancements/milestone/29

[sanposhiho]

/milestone v1.27

[k8s-ci-robot]

@sanposhiho: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/3633#issuecomment-1379800862): >/milestone v1.27 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[ahg-g]

/milestone v1.27

[ahg-g]

/stage alpha /milestone v1.27 /label lead-opted-in

[marosset]

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: v1.27
• [ ] KEP readme has a updated detailed test plan section filled out
• [ ] KEP readme has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, it looks like once https://github.com/kubernetes/enhancements/pull/3651 merges all the above requirements will be met.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[sanposhiho]

Hi @marosset, https://github.com/kubernetes/enhancements/pull/3651 just got merged.

[marosset]

Hi @sanposhiho - With #3651 merged this enhancement is now tracked for now inclusion in the v1.27 release.

Thanks!

/label tracked/yes

[marosset]

Hi @sanposhiho :wave:,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [ ] All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• https://github.com/kubernetes/kubernetes/pull/116065

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

[marosset]

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear /remove-label tracked/yes /label tracked/no

[ahg-g]

One use case for this: https://github.com/kubernetes-sigs/jobset/issues/27

[sanposhiho]

@ahg-g Could you add /milestone v1.28 on it? I'm planning to continue working on it in v1.28.

[ahg-g]

/stage alpha /milestone v1.28 /label lead-opted-in

[Atharva-Shinde]

@ahg-g By your comment above, just checking again if we are opting-in this enhancement for v1.28 release?

[ahg-g]

@ahg-g By your comment above, just checking again if we are opting-in this enhancement for v1.28 release?

Yes we are

[Atharva-Shinde]

/label lead-opted-in

[npolshakova]

Hi @sanposhiho 👋, Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise.)

Here's where this enhancement currently stands:

• [x] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.28
• [x] KEP readme has a updated detailed test plan section filled out
• [x] KEP readme has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like there was one field that missed as part of the 1.27 enhancement review. The KEP status field is currently set to provisional but it should be changed to implementable. In addition to that update you need a PRR approval from PRR team. Let me know if you have any questions!

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[npolshakova]

Hi @sanposhiho 👋, just checking in again before the enhancements freeze on 01:00 UTC Friday, 16th June 2023. The status of this enhancement is currently at risk. It looks like the PRR is approved, but the KEP status field needs to be updated to implementable. Let me know if I missed anything. Thanks!

[sanposhiho]

The status is updated. https://github.com/kubernetes/enhancements/pull/4092

[Atharva-Shinde]

Hey @sanposhiho

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[taniaduggal]

Hello @sanposhiho 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[npolshakova]

Hey again @sanposhiho :wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

• [x] All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• [ ] All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

• https://github.com/kubernetes/kubernetes/pull/116065

Also please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

[Rishit-dagli]

Hey @sanposhiho , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

[sanposhiho]

@Rishit-dagli @taniaduggal Sorry about the delay, I missed the message before. I created the draft PR: https://github.com/kubernetes/website/pull/42011

[Atharva-Shinde]

Hello @sanposhiho 👋, 1.28 Enhancements Lead here.

Unfortunately, the implementation (code related) PR associated with this enhancement was not in the merge-ready state by the code-freeze and hence this enhancement is now being removed from the v1.28 milestone.

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

[alculquicondor]

/sig scheduling

@sanposhiho are you pursuing this in 1.29?

[sanposhiho]

Yes, still waiting for reviews on https://github.com/kubernetes/kubernetes/pull/116065. I'll keep working on it.

[alculquicondor]

For now, can you update the target version in the KEP? IIUC, the design stays the same?

[sanposhiho]

For now, can you update the target version in the KEP? IIUC, the design stays the same?

Yep, let me open the PR to just update the target version.

[npolshakova]

It looks like the lead-opted-in label was removed from this KEP, but you're still targeting 1.29, correct?

/label lead-opted-in

[npolshakova]

Hi @sanposhiho 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [x] KEP readme using the latest template has been merged into the k/enhancements repo.
• [x] KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• [x] KEP readme has up-to-date graduation criteria
• [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze. 🚀

[Princesso]

Hey there @sanposhiho ! 👋, v1.29 Docs team shadow here. Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release. Thank you!

[Princesso]

Hi @sanposhiho! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

[alculquicondor]

https://github.com/kubernetes/website/pull/39779 it should be that one

[Princesso]

@alculquicondor, the PR is closed. Could you or @sanposhiho kindly open another one against dev-1.29 for this release cycle? Thanks

[Huang-Wei]

cc @sanposhiho

[alculquicondor]

Created one https://github.com/kubernetes/website/pull/43566

[sanposhiho]

@Princesso Sorry, I missed your last reminder. Thanks @alculquicondor for creating that.

[kcmartin]

Hi @sanposhiho! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

[sanposhiho]

@kcmartin

I don't think this enhancement is big enough to write a blog post, at least during the alpha stage. Maybe we'll want to have one in beta, but let us skip the blog post for this release.

[AnaMMedina21]

Hello @sanposhiho 👋, v1.29 Enhancements team here.

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023

Here's where this enhancement currently stands:

• [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update KEP Link to https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity, add any Docs link such as https://github.com/kubernetes/website/pull/43566 and ensure they are approved.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

With all this, the status of this KEP is At Risk for Code Freeze.

As always, we are here to help if any questions come up. Thanks!

[sanposhiho]

@AnaMMedina21 We already merged the PR necessary for this enhancement. https://github.com/kubernetes/kubernetes/pull/116065 is the only one.

[AnaMMedina21]

@sanposhiho In the Issue Description can you update the KEP link to the latest link? The link broke when it got renamed from matchlabelselectors and this KEP will be Tracked for Code Freeze when https://github.com/kubernetes/kubernetes/pull/116065 is approved

[npolshakova]

Hello @sanposhiho 👋, 1.29 Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. Let me know if there are any test PRs we should track. Thanks!

[kevarr]

@sanposhiho is there a similar enhancement planned to add MatchLabelKeys/mismatchLabelKeys to the PodDisruptionBudgetSpec as well?

[alculquicondor]

That doesn't sound possible, as there is no Pod to get the keys from.

[sanposhiho]

@kubernetes/sig-scheduling-leads Can we make it beta in this release? If Yes, can anyone /label lead-opted-in?

[Huang-Wei]

/label lead-opted-in