search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.43k stars 1.48k forks source link

Reserve nodeport ranges for dynamic and static allocation #3668

Closed xuzhenglun closed 5 months ago

xuzhenglun commented 1 year ago

Enhancement Description

aojea commented 1 year ago

/sig network

wojtek-t commented 1 year ago

@thockin @aojea - I think we want to opt-in this for 1.27, right?

aojea commented 1 year ago

yes, @xuzhenglun that is the plan , right?

xuzhenglun commented 1 year ago

yes, @xuzhenglun that is the plan , right?

yes, it is. now PR is ready and waiting for next step review https://github.com/kubernetes/kubernetes/pull/114418

wojtek-t commented 1 year ago

/label lead-opted-in

Atharva-Shinde commented 1 year ago

Hello @xuzhenglun 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

xuzhenglun commented 1 year ago

Hello @xuzhenglun 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.27
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [x] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde KEP has fixed in #3809, should I do anything else to remove at risk label?

Atharva-Shinde commented 1 year ago

@xuzhenglun With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

mickeyboxell commented 1 year ago

Hi @xuzhenglun 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

xuzhenglun commented 1 year ago

I think a blog is enough for this KEP, WDYT? @aojea

Placeholder doc PR link: https://github.com/kubernetes/website/pull/39850 @mickeyboxell

Atharva-Shinde commented 1 year ago

Hey again @xuzhenglun 👋 Enhancements team here, Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

Also please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

thockin commented 1 year ago

NEXT: Aiming for Beta in 1.28

aojea commented 1 year ago

@xuzhenglun ^^^^

xuzhenglun commented 1 year ago

@thockin @aojea

sorry for the late reply, I created a new PR for promoting this to beta in 1.28

thockin commented 1 year ago

@xuzhenglun https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3668-reserved-service-nodeport-range/kep.yaml still says "beta" and needs a PRR final update. Thanks @wojtek-t for the ping.

aramase commented 1 year ago

Hello @xuzhenglun 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

aojea commented 1 year ago

@thockin @aramase @wojtek-t it is beta for 1.28, and the PR updated PRR and the KEP https://github.com/kubernetes/enhancements/pull/3985

what is missing?

wojtek-t commented 1 year ago

actually, I somehow thought we're targetting GA - for Beta indeed PRR is approved: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-network/3668.yaml#L4

So from my perspective it's fine

@aramase - anything you're missing?

Atharva-Shinde commented 1 year ago

Hey folks, with all the requirements for this KEP in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

aramase commented 1 year ago

Hey again @xuzhenglun:wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

If there are any other k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

Atharva-Shinde commented 1 year ago

Hey @xuzhenglun 👋 Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/117877 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

thockin commented 1 year ago

I am tracking this for GA in 1.29 - is that correct?

xuzhenglun commented 1 year ago

@thockin

  • Reserve Nodeport Ranges For Dynamic And Static Port Allocation #3682

The criteria for GA says that we need 2 beta versions before GA, and this feature was beta in 1.28. So I think it should GA in 1.30. Please correct me if I'm wrong

thockin commented 1 year ago

Where are you seeing that things must spend 2 releases in beta? If that is new, it's news to me. If that has always been true, I have utterly forgotten, and we certainly have not always followed it.

Especially in this case where we're following pretty exactly the recipe laid out by the equivalent feature for IPs

xuzhenglun commented 1 year ago

@thockin

Where are you seeing that things must spend 2 releases in beta?

  1. It was firstly mentioned in KEP review comment by @aojea .

    1.30, the criteria for GA says

  2. And I saw it in deprecation-policy it says:

    Beta feature to GA: 6 months or 2 releases (whichever is longer)

I'm not pretty sure if I can publish it in 1.29, do we need someone else's opinion? But in my shoes, I'm glad to publish it ASAP.

aojea commented 1 year ago

@liggitt are we being to strict ? ^^^

liggitt commented 1 year ago

There's no requirement to stay in beta for two releases. Some features have more graduation requirements or require more feedback or exposure or proving out, but mechanically it's fine to have a single beta release before graduating.

aojea commented 1 year ago

ok, so it seems I was too conservative here and we are good to go with one release for this feature, since this is a follow up on a previous feature

Especially in this case where we're following pretty exactly the recipe laid out by the equivalent feature for IPs

@xuzhenglun do you mind updating the KEP and PR kubernetes to go GA in 1.29?

xuzhenglun commented 1 year ago

@aojea

do you mind updating the KEP and PR kubernetes to go GA in 1.29?

No problem, I will update the KEP ASAP.

@thockin

I am tracking this for GA in 1.29 - is that correct?

According to the results discussed above, I think this is good to go for GA in 1.29.

thockin commented 1 year ago
  1. And I saw it in deprecation-policy it says

That speaks to how long the gate will continue to exist after it reaches GA: "Feature gates must function..." :)

sanchita-07 commented 1 year ago

Hello @xuzhenglun 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we just need to mark the status as implemented for the latest-milestone: 1.29 as this is targeting for stable.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

Thank you!

xuzhenglun commented 1 year ago

@sanchita-07

HI, I'm a little confused about the status implemented.

I noticed that you mentioned that the implemented status should be marked after the feature gates are removed. However, this KEP has just transitioned to GA in version 1.29. The feature gates are still functioning and are planned to be removed in version 1.31.

So in this situation, I'm not sure whether we should change the status to implemented.

thockin commented 1 year ago

Implemented means GA

On Sat, Sep 30, 2023, 2:40 AM Reficul @.***> wrote:

@sanchita-07 https://github.com/sanchita-07

HI, I'm a little confused about the status implemented.

I noticed that you mentioned that the implemented status should be marked after the feature gates are removed. However, this KEP has just transitioned to GA in version 1.29. The feature gates are still functioning and are planned to be removed in version 1.31.

So in this situation, I'm not sure whether we should change the status to implemented.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/3668#issuecomment-1741726815, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKWAVD7SCBUQCKRUWXV6KDX47SKVANCNFSM6AAAAAASNPS6NU . You are receiving this because you were mentioned.Message ID: @.***>

sanchita-07 commented 1 year ago

@npolshakova can you chime in here, and help clarify the doubt, please?

npolshakova commented 1 year ago

@sanchita-07

HI, I'm a little confused about the status implemented.

I noticed that you mentioned that the implemented status should be marked after the feature gates are removed. However, this KEP has just transitioned to GA in version 1.29. The feature gates are still functioning and are planned to be removed in version 1.31.

So in this situation, I'm not sure whether we should change the status to implemented.

Hi @xuzhenglun, 1.29 Enhancement lead here! To clarify the confusion- KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed. Once the code pr removing the feature gate is merged in, this KEP should be marked as implemented and this issue closed out. Since you are keeping the feature gate until 1.31, this can stay implementable until the feature gates are removed in 1.31. Thanks!

xuzhenglun commented 1 year ago

Hi @sanchita-07, as npolshakova clarified above, This KEP will remain implementable for now. So, am I good for the 1.29 release? I'm happy to address any further tasks if needed.

sanchita-07 commented 1 year ago

Hi @xuzhenglun, with all the requirements for this KEP in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is marked as Tracked for Enhancement Freeze. Thank you :)

harshitasao commented 1 year ago

Hi @xuzhenglun 👋, v1.29 Docs Shadow here Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

xuzhenglun commented 1 year ago

HI @harshitasao,

All documents changed has been merged in https://github.com/kubernetes/website/pull/42774

sanchita-07 commented 1 year ago

Hey again @xuzhenglun 👋, 1.29 Enhancements team here.

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023:

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PR was merged before code freeze:

With all this, the status of this KEP is tracked for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

kcmartin commented 12 months ago

Hi @xuzhenglun ! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

salehsedghpour commented 9 months ago

/remove-label lead-opted-in

salehsedghpour commented 9 months ago

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

xuzhenglun commented 6 months ago

/remove-lifecycle stale

This targes v1.31.

aojea commented 6 months ago

@xuzhenglun this is GA since 1.29, what is missing?

xuzhenglun commented 6 months ago

@aojea

@xuzhenglun this is GA since 1.29, what is missing?

As https://github.com/kubernetes/enhancements/issues/3668#issuecomment-1742136398 mentioned, this feature gate will be kept befoew 1.31.

So I guess that there are a few thing need to be done in v1.31:

  1. remove the feature gate in k/k
  2. change KEP to implemented and merge https://github.com/kubernetes/enhancements/pull/4254
  3. we can close this after all things above are done.
aojea commented 6 months ago

Awesome, please go ahead and let's get to the finish line

thockin commented 5 months ago

@xuzhenglun Please feel free to remove the gate and update the KEP. Congratulations!

xuzhenglun commented 5 months ago

With PR of k/k and docs are merged, I think this can be closed. Thank guys all.

/close