search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.39k stars 1.45k forks source link

Allow for recreation of pods once fully terminated in the job controller #3939

Open kannon92 opened 1 year ago

kannon92 commented 1 year ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

kannon92 commented 1 year ago

/sig apps

wangyysde commented 1 year ago

/cc @wangyysde

alculquicondor commented 1 year ago

/assign I'm taking over the KEP while @kannon92 is on PTO

soltysh commented 1 year ago

/stage alpha /milestone v1.28 /label lead-opted-in

aramase commented 1 year ago

Hello @alculquicondor 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Atharva-Shinde commented 1 year ago

Hey @alculquicondor @kannon92 With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

kannon92 commented 1 year ago

Thank you so much to @alculquicondor for taking this over while I was on PTO. It is so exciting to see that this is tracked for this release. @alculquicondor reached out and I will take over the implementation of this PR.

/assign

aramase commented 1 year ago

Hey again @alculquicondor @kannon92 :wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

If there are any other k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

Atharva-Shinde commented 1 year ago

Thanks for filling an exception request! I'll reapply the v1.28 milestone if the exception request is approved.

Atharva-Shinde commented 1 year ago

/milestone clear

kannon92 commented 1 year ago

/reopen

k8s-ci-robot commented 1 year ago

@kannon92: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/3939#issuecomment-1642898254): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kannon92 commented 1 year ago

@Atharva-Shinde can you add back the 1.28 milestone?

Atharva-Shinde commented 1 year ago

/milestone v1.28

npolshakova commented 1 year ago

Hello 👋, 1.29 Enhancements Lead here.

If you wish to progress this enhancement in v1.29, please have the SIG lead opt-in your enhancement by adding the lead-opt-in and milestone v1.29 labels before the Production Readiness Review Freeze.

/remove-label lead-opted-in

kannon92 commented 1 year ago

I'm afraid I won't have capacity this release to take this work on. Luckily @dejanzele has asked to take on some of this work.

/assign @dejanzele

k8s-ci-robot commented 1 year ago

@kannon92: GitHub didn't allow me to assign the following users: dejanzele.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes/enhancements/issues/3939#issuecomment-1698211660): >I'm afraid I won't have capacity this release to take this work on. Luckily @dejanzele has asked to take on some of this work. > >/assign @dejanzele Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dejanzele commented 1 year ago

Hello,

As @kannon92, I will take this work. Thanks for all the effort you did Kevin!

kannon92 commented 1 year ago

Hello,

As @kannon92, I will take this work. Thanks for all the effort you did Kevin!

Please comment on the PR with /assign to assign it to yourself.

dejanzele commented 12 months ago

/assign dejanzele

dejanzele commented 11 months ago

Hi @aramase @Atharva-Shinde,

What is missing for this KEP to get completed? I am happy to help with the remaining work

kannon92 commented 11 months ago

Hi @aramase @Atharva-Shinde,

What is missing for this KEP to get completed? I am happy to help with the remaining work

Sig-Apps is the team that owns this feature. I am not sure if planning has happened for 1.29 for sig-apps.

I know that @alculquicondor and @mimowo would like to have this promoted to beta.

You can look at the KEP and see what items are required for beta.

I believe we stated the following items:

1) Turn the feature on by default. 2) Add metrics 3) Finish integration tests. 4) Since feature is always on, you can add e2e tests now.

alculquicondor commented 11 months ago

You need to start by sending a PR to kubernetes/enhancements to update the stage to beta and get the approval from SIG Apps.

npolshakova commented 11 months ago

Hello @dejanzele, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

soltysh commented 11 months ago

/label lead-opted-in /stage beta /milestone v1.29

sreeram-venkitesh commented 11 months ago

Hello @kannon92 @dejanzele 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v1.29(correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, everything is taken care of in https://github.com/kubernetes/enhancements/pull/4252. Please make sure that the PR is merged in time for the enhancements freeze.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova commented 11 months ago

With KEP PR enhancements/pull/4252 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

katcosgrove commented 11 months ago

Hey there @alculquicondor @kannon92 and @dejanzele :wave:, v1.29 Docs Lead here. Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

katcosgrove commented 10 months ago

Hi again @alculquicondor @kannon92 and @dejanzele! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

alculquicondor commented 10 months ago

Thanks for the reminder. I created https://github.com/kubernetes/website/pull/43529

@kannon92 could you update the issue description?

kcmartin commented 10 months ago

Hi @kannon92 @alculquicondor @dejanzele :wave: from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

alculquicondor commented 10 months ago

Thanks for the reminder @kcmartin. We did one for 1.28 https://kubernetes.io/blog/2023/08/21/kubernetes-1-28-jobapi-update/ We are not thinking of another one this time.

sreeram-venkitesh commented 10 months ago

Hey again @kannon92 @dejanzele @alculquicondor! 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

This KEP is tracked for code freeze since all the associated code PRs have been merged for the beta stage and has been updated in the issue description 🎉

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

sreeram-venkitesh commented 10 months ago

Hello @kannon92 @dejanzele @alculquicondor 👋, 1.29 Enhancements team here!

With all the implementation (code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. The tracked test PRs for this KEP are:

Please let me know if there are additional test PRs we should track. Thanks!

alculquicondor commented 10 months ago

The open PR just updates the KEP with the changes we decided during the implementation reviews. But all the test code is already merged.

sreeram-venkitesh commented 10 months ago

Ah okay, thanks for clarifying! This means that there are no more PRs to be merged into k/k for this KEP right?

dejanzele commented 9 months ago

@sreeram-venkitesh, In my opinion, we merged everything which is required for PodReplacementPolicy to go into Beta and the requirements are done.

kannon92 commented 9 months ago

k/website is not quite done but code freeze wise, we are looking good.

kannon92 commented 9 months ago

I updated this checklist. I think we have each component necessary for 1.29 now and we are good to go for 1.29. Thank you @dejanzele for leading this effort. And thank you to @alculquicondor for doing the necessary docs updates!

salehsedghpour commented 8 months ago

/remove-label lead-opted-in

salehsedghpour commented 7 months ago

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

atiratree commented 3 months ago

https://github.com/kubernetes/enhancements/issues/4368 (https://github.com/kubernetes/enhancements/pull/4657) managed-by feature changes the handling of terminating pods. It is better to wait for that one, before graduating PodReplacementPolicy to GA.

atiratree commented 3 months ago

/remove-lifecycle rotten

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale