search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.46k stars 1.49k forks source link

Consider Terminating Pods in Deployments #3973

Open kannon92 opened 1 year ago

kannon92 commented 1 year ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

kannon92 commented 1 year ago

/sig apps

atiratree commented 1 year ago

@kannon92 can you please link a correct KEP in the description?

dejanzele commented 1 year ago

As discussed with @kannon92, I will be taking over this KEP.

/assign dejanzele

atiratree commented 1 year ago

@dejanzele I had a similar discussion with @kannon92 some time ago about this as well. And I have the KEP mostly written, just need to finish it..

atiratree commented 11 months ago

@kannon92 @dejanzele I have opened the new version of the KEP in https://github.com/kubernetes/enhancements/pull/4357.

kannon92 commented 11 months ago

/assign @atiratree

atiratree commented 10 months ago

/label lead-opted-in /milestone v1.30 /stage alpha

k8s-ci-robot commented 10 months ago

@atiratree: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/3973#issuecomment-1906475691): >/label lead-opted-in >/milestone v1.30 >/stage alpha Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 10 months ago

@atiratree: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to [this](https://github.com/kubernetes/enhancements/issues/3973#issuecomment-1906475691): >/label lead-opted-in >/milestone v1.30 >/stage alpha Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
soltysh commented 10 months ago

/label lead-opted-in /milestone v1.30 /stage alpha

meganwolf0 commented 10 months ago

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

meganwolf0 commented 9 months ago

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is still at risk for enhancement freeze. Please make sure you get all changes merged before the enhancement freeze deadline. Thank you!

salehsedghpour commented 9 months ago

With all the requirements fulfilled in #4357 this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

celestehorgan commented 9 months ago

Hello @kannon92 :wave:, 1.30 Docs Shadow here. Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

natalisucks commented 9 months ago

Hi @atiratree and @dejanzele,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

atiratree commented 9 months ago

hi, I have opened placeholder PRs:

meganwolf0 commented 9 months ago

Hey again @atiratree 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

atiratree commented 9 months ago

I have updated the https://github.com/kubernetes/kubernetes/pull/123430 PR with an implementation, but I am still missing the tests, so we will not be able to merge this feature in 1.30 due to not enough time.

Even though it might be possible to finish this if we had enough review capacity, I would prefer not to for the following reasons:

meganwolf0 commented 9 months ago

Thank you @atiratree - In this case I will mark this enhancement Removed from Milestone

kannon92 commented 9 months ago

updated links.

atiratree commented 9 months ago

In today's sig-apps call, we have decided to postpone the introduction of the annotation into 1.31 along with the alpha version of the feature. We will specifically document in the KEP/docs that this feature should be used with the latest kubectl. In the next release (1.32), the rollbacks should be backwards compatible.

salehsedghpour commented 9 months ago

/milestone clear

sreeram-venkitesh commented 6 months ago

Hi @atiratree 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

atiratree commented 6 months ago

I would like to land this enhancement in 1.31.

KEP update: https://github.com/kubernetes/enhancements/pull/4670

soltysh commented 6 months ago

/label lead-opted-in /milestone v1.31

ArkaSaha30 commented 6 months ago

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024..

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

sreeram-venkitesh commented 5 months ago

With https://github.com/kubernetes/enhancements/pull/4670 merged, we can mark this KEP as tracked for enhancements freeze! 🎉

edithturn commented 5 months ago

Hello, @atiratree and @dejanzele!

👋 from the v1.31 Communications Team!

We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

atiratree commented 5 months ago

@edithturn I have opened a placeholder PR for the blog post: https://github.com/kubernetes/website/pull/45268

edithturn commented 5 months ago

@edithturn I have opened a placeholder PR for the blog post: kubernetes/website#45268

Thank you so much @atiratree , please te us know if you need any help! :)

ArkaSaha30 commented 4 months ago

Hey again @atiratree 👋, Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

Regarding this enhancement, it appears that there is currently 1 open PR in the k/k repository which is in draft state. The other PR listed in the description has been closed.

For this KEP, we would need to do the following:

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

ArkaSaha30 commented 4 months ago

Hey again @SergeyKanzhelev 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in about 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. A few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/3973#issuecomment-2215269277 still need to be completed. The following open PR as per the description still needs to be merged, PR mentioned in the description has been marked as closed:

If you anticipate missing code freeze, you can file an exception request in advance.

sreeram-venkitesh commented 4 months ago

Hello @atiratree 👋 v1.31 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.31 milestone.

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

sreeram-venkitesh commented 4 months ago

We've received an exception request for this KEP: https://groups.google.com/g/kubernetes-sig-release/c/SLTNXQvnOtM

tjons commented 2 months ago

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

atiratree commented 2 months ago

hi @soltysh and @kannon92, I would like to pursue this feature again this release. Here is the KEP update: https://github.com/kubernetes/enhancements/pull/4903

kannon92 commented 2 months ago

hi @soltysh and @kannon92, I would like to pursue this feature again this release. Here is the KEP update: #4903

I updated the description. I am not a sig-apps reviewer/approver but LGTM. Those yaml fields look great.

soltysh commented 1 month ago

/label lead-opted-in /milestone v1.32

SergeyKanzhelev commented 1 month ago

Hey again @SergeyKanzhelev 👋, 1.31 Enhancements team here,

sorry, not sure why I was tagged here. Please let me know if anything needed here

jenshu commented 1 month ago

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting stage alpha for v1.32 (correct me, if otherwise)

Here’s where this enhancement currently stands:

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

soltysh commented 1 month ago

sorry, not sure why I was tagged here. Please let me know if anything needed here

I believe a simple mistake - sorry Sergey :wink:

mbianchidev commented 1 month ago

Hi hi @dejanzele @atiratree 👋 from the v1.32 Communications Team!

We'd love for you to consider writing a feature blog about your enhancement. Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and it is graduating.

To opt-in, let us know by opening a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we finalize the blog schedule.

rdalbuquerque commented 1 month ago

Hello @atiratree :wave:, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

atiratree commented 1 month ago

Hi, I have opened PRs for docs and a blog:

jenshu commented 1 month ago

Hey again @atiratree 👋, v1.32 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

tjons commented 3 weeks ago

Hello @atiratree 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.32 milestone.

If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

atiratree commented 3 weeks ago

Unfortunately we did not manage to finish the API review in time, so we will postpone this feature to the next release.

We also spun off part of the feature/review into an additional PR:

@kannon92 could you please update the description?

atiratree commented 1 week ago

Opened a new KEP update https://github.com/kubernetes/enhancements/pull/4976 and targetting 1.33 now.