search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.42k stars 1.47k forks source link

Add support for a drop-in kubelet configuration directory #3983

Open haircommander opened 1 year ago

haircommander commented 1 year ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

haircommander commented 1 year ago

/sig node

SergeyKanzhelev commented 1 year ago

/milestone v1.28

Adding to the milestone for tracking based on discussions at sig node meeting.

ffromani commented 1 year ago

+1!!! (non binding) @haircommander I'd love to help here to get this in kubelet

SergeyKanzhelev commented 1 year ago

/stage alpha

SergeyKanzhelev commented 1 year ago

/label lead-opted-in

ruheenaansari34 commented 1 year ago

Hello @haircommander 👋, 1.28 Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023.

This enhancement is targeting stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to take care of:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

yuqi-zhang commented 1 year ago

Hi @ruheenaansari34 , I've updated the ID, thanks for pointing that out!

Is there anything else needed at the moment other than getting consensus to merge the enhancement?

ruheenaansari34 commented 1 year ago

@yuqi-zhang Please take care of the following before the Enhancement freeze to meet the requirements:

The status of this enhancement is still marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

yuqi-zhang commented 1 year ago

Thanks! I've marked it as implementable after discussion with @haircommander . We will work to get it merged

Atharva-Shinde commented 1 year ago

Thanks @yuqi-zhang :) With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀. The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well.

Rishit-dagli commented 1 year ago

Hello @haircommander :wave:, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Rishit-dagli commented 1 year ago

Hey @haircommander , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

haircommander commented 1 year ago

yes I will take care of it, thanks @Rishit-dagli !

haircommander commented 1 year ago

done! https://github.com/kubernetes/website/pull/42013

ruheenaansari34 commented 1 year ago

Hey again @haircommander :wave: Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

Atharva-Shinde commented 1 year ago

Hey @haircommander 👋 Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/119390 merged as per the issue description I updated above, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

Rishit-dagli commented 1 year ago

Hello @haircommander wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: https://github.com/kubernetes/website/pull/42013

haircommander commented 1 year ago

thank you! I have moved it out of draft

katcosgrove commented 1 year ago

Hey y'all! I'm swinging by for the v1.28 Docs team. Today is the docs deadline. Is there anything we can help you with to get this merged?

haircommander commented 1 year ago

sorry I am updating it now, I will get this done soon.

npolshakova commented 1 year ago

/remove-label lead-opted-in

SergeyKanzhelev commented 1 year ago

/milestone v1.29 /stage beta /label lead-opted-in

SergeyKanzhelev commented 1 year ago

@haircommander please send the PR to update KEP details for beta in 1.29

salehsedghpour commented 1 year ago

Hello @haircommander 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

kannon92 commented 1 year ago

/assign @sohankunkerkar

k8s-ci-robot commented 1 year ago

@kannon92: GitHub didn't allow me to assign the following users: sohankunkerkar.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes/enhancements/issues/3983#issuecomment-1737391321): >/assign @sohankunkerkar Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sohankunkerkar commented 1 year ago

I'm working on this issue.

kannon92 commented 1 year ago

/assign @sohankunkerkar

salehsedghpour commented 1 year ago

Hi @haircommander @sohankunkerkar , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like https://github.com/kubernetes/enhancements/pull/4242 will address all of the requirements.

Let me know if I missed anything. Thanks!

Please keep the issue description up-to-date with appropriate information such that PR.

salehsedghpour commented 1 year ago

As #4242 is merged, the status of this enhancement is marked as tracked for enhancement freeze.

drewhagen commented 1 year ago

Hello @haircommander @sohankunkerkar :wave:, v1.29 Docs Shadow here. Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

drewhagen commented 1 year ago

Hi @haircommander @sohankunkerkar! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

sohankunkerkar commented 1 year ago

@drewhagen Thanks for your patience. Here's the link for the placeholder PR: https://github.com/kubernetes/website/pull/43542

kcmartin commented 1 year ago

Hi @sohankunkerkar @haircommander! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

salehsedghpour commented 12 months ago

Hey again @sohankunkerkar @haircommander 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

Please update the Issue description to include all the related PRs (including https://github.com/kubernetes/kubernetes/pull/121193, I guess) of this KEP under beta section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

npolshakova commented 11 months ago

Hello @sohankunkerkar @haircommander 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

npolshakova commented 11 months ago

With https://github.com/kubernetes/kubernetes/pull/121193 merged this is now marked as tracked for code freeze for 1.29! 🚀

salehsedghpour commented 9 months ago

/remove-label lead-opted-in

SergeyKanzhelev commented 9 months ago

/stage beta /milestone v1.30

(as per https://github.com/kubernetes/enhancements/pull/4419/)

mrunalp commented 8 months ago

/label lead-opted-in

AnaMMedina21 commented 8 months ago

Hello @haircommander👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

SergeyKanzhelev commented 8 months ago

@sohankunkerkar @haircommander when working on documentation for the feature, it would be nice if you can compare how the merge logic same/differ from the kubeadm logic mentioned here: https://github.com/kubernetes/enhancements/pull/4031#issuecomment-1572671760

kubeadm patch mechanism replacement is not a goal, but since it is already being used, it is a good way to check usability of drop-in configuration

celestehorgan commented 8 months ago

Hi @sohankunkerkar @haircommander!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

===

I notice that your Alpha PR was empty and closed due to this going Beta in 1.30. Let us know if you need any help deciding what needs writing :)

sohankunkerkar commented 8 months ago

Hi @celestehorgan, Thank you for the reminder. I have submitted a PR for updating the documentation to the main branch. Upon merging, I will open a PR targeting the 1.30-dev branch. To provide some context, this feature was originally planned for Beta release in 1.29. However, due to last-minute bug fixes, we decided to delay the move to Beta and allow for some soak time before proceeding. Since there were no significant changes to the feature, I did not update the documentation in 1.29, which is why you see an empty PR, but thanks for the help :)

Checksumz commented 8 months ago

Hi @haircommander ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

AnaMMedina21 commented 7 months ago

Hello @haircommander 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

wangzhen127 commented 7 months ago

Hi @haircommander, I am interested at this feature. I saw in the KEP that during beta phase, it includes "Implement the capability to query the kubelet's full effective configuration via API, covering both standard mode and standalone kubelet mode." Have we had this capability already? Can you share how to query the kubelet's full effective config? Thanks!

sohankunkerkar commented 7 months ago

wangzhen127 Thanks for your interest. Today, we can query the Kubelet config by setting up the kubectl proxy and using a curl command to query the /configz endpoint (curl -X GET http://127.0.0.1:8001/api/v1/nodes/<node-name>/proxy/configz | jq .). This is more of a gap in the Kubernetes documentation. Additionally, we need to refine the language used in the KEP to make it sound more like a documentation request than an implementation.

wangzhen127 commented 7 months ago

Ah, I see. Thanks for the clarification! So basically kubectl get --raw "/api/v1/nodes/<nodename>/proxy/configz" | jq

sohankunkerkar commented 7 months ago

Ah, I see. Thanks for the clarification! So basically kubectl get --raw "/api/v1/nodes/<nodename>/proxy/configz" | jq

Yeah,that's another way to query the configz endpoint.