search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.42k stars 1.47k forks source link

Job success/completion policy #3998

Open tenzen-y opened 1 year ago

tenzen-y commented 1 year ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig apps /wg batch /assign

alculquicondor commented 1 year ago

@soltysh I'm not sure if this will make it to the enhancements freeze, but would you consider a lead-opted-in?

soltysh commented 1 year ago

@soltysh I'm not sure if this will make it to the enhancements freeze, but would you consider a lead-opted-in?

Sorry, I won't be able to get there before today's freeze

tenzen-y commented 1 year ago

Since many discussions are left, I will try to complete it for the next release cycle (v1.29). Thanks to everyone!

dejanzele commented 11 months ago

Hey @tenzen-y,

Are you still working on this KEP?

I just finished graduation of the PodReplacementPolicy to Beta and I have capacity to take on additional work if you don't have capacity to work on this KEP.

tenzen-y commented 11 months ago

KEP-3998: Job success/completion policy #4062

I'm working on this now. I will move this forward in the next release cycle (v1.30) since the enhancement freeze for this release (v1.29) came.

https://github.com/kubernetes/enhancements/pull/4062#issuecomment-1748926798

kannon92 commented 8 months ago

@soltysh since the KEP is being reviewed, did you consider adding this as a feature for sig-apps for 1.30?

soltysh commented 8 months ago

/label lead-opted-in /milestone v1.30 /stage alpha

pnbrown commented 8 months ago

Hello @tenzen-y 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

tenzen-y commented 8 months ago

@pnbrown Thank you for contacting me.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

This enhancement is still targeting for alpha stage. Could you confirm again?

pnbrown commented 8 months ago

That's my mistake. Editing now

tenzen-y commented 8 months ago

That's my mistake. Editing now

Thanks.

pnbrown commented 8 months ago

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

celestehorgan commented 8 months ago

Hi @tenzen-y!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

tenzen-y commented 8 months ago

Hi @tenzen-y!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Sure. Thank you for reminding me! Created: https://github.com/kubernetes/website/pull/45135

natalisucks commented 8 months ago

Hi @tenzen-y,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

tenzen-y commented 7 months ago

Hi @tenzen-y,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@natalisucks Hi, thank you for contacting me. I created a placeholder PR here: https://github.com/kubernetes/website/pull/45274.

pnbrown commented 7 months ago

Hey again @tenzen-y 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

salehsedghpour commented 7 months ago

With the exception request being approved, this can now be marked as tracked for code freeze

sreeram-venkitesh commented 5 months ago

Hi @tenzen-y 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

atiratree commented 4 months ago

@tenzen-y do you want to graduate this feature to Beta in 1.31?

tenzen-y commented 4 months ago

@tenzen-y do you want to graduate this feature to Beta in 1.31?

@atiratree Yes, I would like to move this forward. Are there any sig-apps TLs that can lead to opted-in for this enhancement?

tenzen-y commented 4 months ago

@soltysh Hi! Could you add a lead-opted-in label to this issue? Thanks in advance!

soltysh commented 4 months ago

/label lead-opted-in /milestone v1.31 /stage beta

soltysh commented 4 months ago

@tenzen-y do you have a KEP ready for the promotion? link?

prianna commented 4 months ago

Hello @tenzen-y 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting stage beta for v1.31 (correct me if otherwise)

Here's where this enhancement currently stands:

For this KEP, it looks like we still need to do the following:

The status of this enhancement is marked as at risk for enhancement freeze. Once you have the PR with these changes created, please update the issue description with links so we can track merge and update status accordingly.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

tenzen-y commented 4 months ago

@prianna Beta graduation KEP PR was merged. So could you update the check list? Thank you!

prianna commented 4 months ago

Hey folks, with the merge of https://github.com/kubernetes/enhancements/pull/4702/files, here's where this enhancement currently stands:

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

salaxander commented 4 months ago

Hello @tenzen-y 👋, 1.31 Docs Shadow here.

Does the work related to this KEP planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

a-mccarthy commented 4 months ago

Hi @tenzen-y, 👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Princesso commented 3 months ago

Hello @tenzen-y 👋, 1.31 Docs Shadow here.

Does the work related to this KEP planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

Hi @tenzen-y, good day. Gentle reminder to open a Doc placeholder PR against v1.31 for updates to this enhancement before June 27th, 2024 which is the deadline for having a doc PR up. Thank you!

tenzen-y commented 3 months ago

Hello @tenzen-y 👋, 1.31 Docs Shadow here. Does the work related to this KEP planned for 1.31 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release. Thank you!

Hi @tenzen-y, good day. Gentle reminder to open a Doc placeholder PR against v1.31 for updates to this enhancement before June 27th, 2024 which is the deadline for having a doc PR up. Thank you!

Thank you for reminding me. I opened it there: https://github.com/kubernetes/website/pull/46970

a-mccarthy commented 3 months ago

@tenzen-y, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

prianna commented 3 months ago

Hey again @tenzen-y 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

You linked a bugfix PR but it looks like the feature gates still need updating, is there a different PR to graduate JobSuccessPolicy? Please let me know if there are other PRs in k/k we should be tracking for this KEP and update your issue description to match. 🙏

If you anticipate missing code freeze, you can file an exception request in advance. As always, we are here to help if any questions come up. Thanks!

carlory commented 3 months ago

@prianna I raised a PR to promote it to beta.

carlory commented 3 months ago

@tenzen-y is working on both tasks. https://github.com/kubernetes/kubernetes/pull/126017#issuecomment-2222166128 cc @prianna I closed my PR.

tenzen-y commented 3 months ago

@prianna I updated the code list in this description.

prianna commented 3 months ago

@tenzen-y @carlory Thank you for raising the PRs and updating the issue description. I'll keep an eye on this for merges for the following PRs:

Wishing you expediency of reviews and many passing tests.

tenzen-y commented 2 months ago

@prianna Hi, Prianna. All codes (k/k) have already been merged.

sreeram-venkitesh commented 2 months ago

Thanks @tenzen-y! Marking this KEP as tracked for code freeze 🎉

sreeram-venkitesh commented 2 months ago

@tenzen-y I found a PR related to this KEP: https://github.com/kubernetes/kubernetes/pull/121863#issuecomment-2227176413. You've mentioned earlier in the PR that the PR was related to the beta graduation of this KEP. Is that taken care of, or are there any pending changes that affect this KEP?

Please let us know as we are in code freeze now, thanks!

carlory commented 2 months ago

FYI @sreeram-venkitesh https://github.com/kubernetes/kubernetes/pull/126017#issuecomment-2222175789

tenzen-y commented 2 months ago

@tenzen-y I found a PR related to this KEP: kubernetes/kubernetes#121863 (comment). You've mentioned earlier in the PR that the PR was related to the beta graduation of this KEP. Is that taken care of, or are there any pending changes that affect this KEP?

Please let us know as we are in code freeze now, thanks!

Sorry for your confusion. As @carlory mentioned above, there is https://github.com/kubernetes/kubernetes/pull/121863 bug before we introduce the JobSuccessPolicy. So, I'm trying to fix the bug separate from this KEP. Once I get approval from sig apps approvers, I will contact release team members as a separate issue.

sreeram-venkitesh commented 2 months ago

No worries @tenzen-y! Thanks a lot for the clarification.

Once I get approval from sig apps approvers, I will contact release team members as a separate issue.

Does this PR needs to go in the v1.31 release? If its not related to the KEP, we are good here. You can reach out later once you get the approval.

tenzen-y commented 2 months ago

No worries @tenzen-y! Thanks a lot for the clarification.

Once I get approval from sig apps approvers, I will contact release team members as a separate issue.

Does this PR needs to go in the v1.31 release? If its not related to the KEP, we are good here. You can reach out later once you get the approval.

Yes, https://github.com/kubernetes/kubernetes/pull/121863 is not related to this Enhancement.

tjons commented 1 month ago

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in