search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.45k stars 1.49k forks source link

Add Pod Index Label for StatefulSets and Indexed Jobs #4017

Open danielvegamyhre opened 1 year ago

danielvegamyhre commented 1 year ago

Enhancement Description

Note: We will release the feature directly in Beta state since there is no benefit in having an alpha release, since we are simply adding a new label so there is very little risk (unlike removing an existing label which other things may depend on, for example).

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

danielvegamyhre commented 1 year ago

/sig apps /assign

soltysh commented 1 year ago

/label beta /milestone v1.28 /label lead-opted-in

k8s-ci-robot commented 1 year ago

@soltysh: The label(s) /label beta cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, lead-opted-in, tracked/no, tracked/out-of-tree, tracked/yes. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to [this](https://github.com/kubernetes/enhancements/issues/4017#issuecomment-1556864488): >/label beta >/milestone v1.28 >/label lead-opted-in Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
soltysh commented 1 year ago

/stage beta

npolshakova commented 1 year ago

Hi @danielvegamyhre 👋, Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise.)

Here's where this enhancement currently stands:

It looks like https://github.com/kubernetes/enhancements/pull/4019 will address some of these requirements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ahg-g commented 1 year ago

@Atharva-Shinde this is only pending PRR review

Atharva-Shinde commented 1 year ago

@Atharva-Shinde this is only pending PRR review

Ack. We'll mark this as tracked after it is approved.

npolshakova commented 1 year ago

Looks like the PRR is approved and https://github.com/kubernetes/enhancements/pull/4019 has gone in so this is now tracked for 1.28 🚀

katcosgrove commented 1 year ago

Hello @danielvegamyhre! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

npolshakova commented 1 year ago

Hey again @danielvegamyhre :wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

Rishit-dagli commented 1 year ago

Hey @danielvegamyhre , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

danielvegamyhre commented 1 year ago

@Rishit-dagli Docs PR created here: https://github.com/kubernetes/website/pull/42059

Atharva-Shinde commented 1 year ago

Hey @danielvegamyhre 👋 Enhancements Lead here

With all the implementation(code related) PRs merged as per the issue description: https://github.com/kubernetes/kubernetes/pull/118883 https://github.com/kubernetes/kubernetes/pull/119232

This enhancement is now marked as tracked for the v1.28 Code Freeze!

danielvegamyhre commented 1 year ago

All items for beta in 1.28 release have been completed.

npolshakova commented 1 year ago

Hello 👋, 1.29 Enhancements Lead here.

If you wish to progress this enhancement in v1.29, please have the SIG lead opt-in your enhancement by adding the lead-opt-in and milestone v1.29 labels before the Production Readiness Review Freeze.

/remove-label lead-opted-in

salehsedghpour commented 10 months ago

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

danielvegamyhre commented 10 months ago

@salehsedghpour we will graduate this to GA

/label lead-opted-in /milestone v1.30

k8s-ci-robot commented 10 months ago

@danielvegamyhre: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes/enhancements/issues/4017#issuecomment-1894759546): >@salehsedghpour we will graduate this to GA > >/label lead-opted-in >/milestone v1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
danielvegamyhre commented 10 months ago

/stage ga

k8s-ci-robot commented 10 months ago

@danielvegamyhre: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to [this](https://github.com/kubernetes/enhancements/issues/4017#issuecomment-1894759546): >@salehsedghpour we will graduate this to GA > >/label lead-opted-in >/milestone v1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ahg-g commented 10 months ago

/label lead-opted-in /milestone v1.30

ahg-g commented 10 months ago

/stage stable

meganwolf0 commented 10 months ago

Hello @danielvegamyhre 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

meganwolf0 commented 9 months ago

Hello @danielvegamyhre 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is still at risk for enhancement freeze. Please make sure you get all changes merged before the enhancement freeze deadline. Thank you!

meganwolf0 commented 9 months ago

Hello @danielvegamyhre 👋, 1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.30, please file an exception request. Thanks!

salehsedghpour commented 9 months ago

/milestone clear

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tenzen-y commented 6 months ago

/remove-lifecycle stale

sreeram-venkitesh commented 6 months ago

Hi @tenzen-y 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

atiratree commented 6 months ago

@danielvegamyhre do you plan to graduate this feature in 1.31?

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

alaypatel07 commented 2 months ago

/remove-lifecycle stale

I can help with moving this feature to stable in 1.32.

cc @kannon92

kannon92 commented 2 months ago

/assign @alaypatel07

danielvegamyhre commented 2 months ago

Thanks @alaypatel07 :)

kannon92 commented 2 months ago

@alaypatel07 To move this forward, please start with an update to the KEP. The KEP deadline is coming up so let's get this created soon and I can help get it ready for KEP review.

kannon92 commented 2 months ago

@soltysh It looks like @alaypatel07 is eager to work on this for 1.32. Can we get a lead-opt-in for this feature? I think we can promote this to stable in this release.

soltysh commented 1 month ago

/label lead-opted-in /milestone v1.32 /stage stable

shecodesmagic commented 1 month ago

Hello @alaypatel07 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

Also, in the KEP readme, please make sure you update Release Signoff Checklist where applicable. Second If there are any questions in the KEP readme file that doesn’t apply to your KEP, please reply to them with NA if haven’t already and dont leave them blank.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

shecodesmagic commented 1 month ago

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

michellengnx commented 1 month ago

Hello @alaypatel07 and @danielvegamyhre :wave:, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

rashansmith commented 1 month ago

Hello @alaypatel07 @danielvegamyhre 👋 from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

michellengnx commented 1 month ago

Hello @alaypatel07 and @danielvegamyhre 👋, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Hello @alaypatel07 and @danielvegamyhre 👋,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is 4 days away at Thursday October 24, 2024 18:00 PDT.

Thanks, Michelle

rashansmith commented 4 weeks ago

Hello @alaypatel07 @danielvegamyhre 👋 from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Hello @alaypatel07, this is a reminder for the feature blog post for v1.32.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Please reach out if you have any questions!

alaypatel07 commented 3 weeks ago

@rashansmith @michellengnx apologies for delayed response, but I dont think a blog post is needed for this feature.

shecodesmagic commented 3 weeks ago

Hello @danielvegamyhre @alaypatel07 :wave:, Enhancements team here (again 😁 )

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024.

Here’s where this enhancement currently stands:

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP if missing):

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

tjons commented 2 weeks ago

Hello @danielvegamyhre @alaypatel07 👋, Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.32 Code Freeze!

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.