search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.46k stars 1.49k forks source link

Discover cgroup driver from CRI #4033

Open marquiz opened 1 year ago

marquiz commented 1 year ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

marquiz commented 1 year ago

/sig node

SergeyKanzhelev commented 1 year ago

/milestone v1.28

SergeyKanzhelev commented 1 year ago

/label lead-opted-in

SergeyKanzhelev commented 1 year ago

/stage alpha

salehsedghpour commented 1 year ago

Hello @marquiz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

salehsedghpour commented 1 year ago

Hi @marquiz 👋, just checking in before the enhancements freeze on 01:00 UTC Friday, 16th June 2023.

The status for this enhancement is at risk.

For this KEP, we would just need to update the following:

Let me know if I missed anything. Thanks!

marquiz commented 1 year ago

Thanks @salehsedghpour. The first two of the items should now be addressed:

salehsedghpour commented 1 year ago

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀

The status of this enhancement is marked as tracked.

VibhorChinda commented 1 year ago

Hello @marquiz :wave:, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Rishit-dagli commented 1 year ago

Hey @marquiz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

salehsedghpour commented 1 year ago

Hey again @marquiz :wave: Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 . Here’s the enhancement’s state for the upcoming code freeze:

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

VibhorChinda commented 1 year ago

Hey @marquiz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023. Thanks.

marquiz commented 1 year ago

@VibhorChinda thanks 🫡 I will work on that tomorrow

Atharva-Shinde commented 1 year ago

Hey @marquiz 👋 Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/118770 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

VibhorChinda commented 1 year ago

Hello @marquiz :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

marquiz commented 1 year ago

@VibhorChinda argh, I had submitted the documentation to the main branch, against the guidance 🙈 I now re-submitted towards dev-1.28 (https://github.com/kubernetes/website/pull/42160).

npolshakova commented 1 year ago

/remove-label lead-opted-in

salehsedghpour commented 10 months ago

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

marquiz commented 10 months ago

Plan is for beta in v1.31 (description updated)

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

SergeyKanzhelev commented 6 months ago

/label lead-opted-in /milestone v1.31 /stage beta /remove-lifecycle stale

dipesh-rawat commented 6 months ago

Hello @marquiz 👋, 1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for 1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

It looks like https://github.com/kubernetes/enhancements/pull/4682 will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

dipesh-rawat commented 5 months ago

Hi @marquiz @haircommander👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

The current status of this enhancement is still marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4033#issuecomment-2148631605 that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

haircommander commented 5 months ago

KEP update PR merged https://github.com/kubernetes/enhancements/pull/4682 :) @marquiz can you update the description?

dipesh-rawat commented 5 months ago

Hello @marquiz @haircommander,

Now that PR https://github.com/kubernetes/enhancements/pull/4682 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

Aside from the minor nits mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

haircommander commented 5 months ago

/assign

dipesh-rawat commented 5 months ago

@marquiz @haircommander, We're currently in enhancements freeze at the moment. We need a update in the kep.yaml to set the stage: beta. Could you please make this update to the kep.yaml as soon as you can.

haircommander commented 5 months ago

i'm afraid I don't have the power to edit and I think @marquiz is on vacation

hacktivist123 commented 5 months ago

Hello @marquiz @haircommander 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

rashansmith commented 5 months ago

Hi @haircommander,

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Princesso commented 5 months ago

Hello @marquiz @haircommander 👋,

Hello @marquiz @haircommander 👋, gentle reminder to raise a docs placeholder PR for this enhancement, if it needs documentation for the v1.31. The deadline for raising the a draft PR is Thursday June 27, 2024 18:00 PDT.

haircommander commented 5 months ago

here it is https://github.com/kubernetes/website/pull/46965 thank you for the reminder!

rashansmith commented 5 months ago

Hey @marquiz @haircommander , friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

haircommander commented 5 months ago

Thanks for the reminder, I don't think this feature needs a blog

neolit123 commented 5 months ago

Thanks for the reminder, I don't think this feature needs a blog

if not for beta, it would be really nice for GA. the cgroup driver mismatch this has been historically the #1 reason for user miss-config when setting up k8s.

haircommander commented 5 months ago

good point, I guess we could have one. I've opened a placeholder https://github.com/kubernetes/website/pull/47054

dipesh-rawat commented 5 months ago

Hey again @marquiz @haircommander👋, Enhancements team here,

Just checking in as we approach code freeze at at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, the one PR (https://github.com/kubernetes/kubernetes/pull/119441) referred to in the description has already been closed.

For this KEP, we would need to do the following:

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

Edited: To include the PR related to the KEP as highlighted in https://github.com/kubernetes/enhancements/issues/4033#issuecomment-2200871460

haircommander commented 5 months ago

thanks @dipesh-rawat ! I have opened the beta bump PR here

dipesh-rawat commented 4 months ago

Hey again @marquiz @haircommander 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in around two weeks time, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4033#issuecomment-2200814111 that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

dipesh-rawat commented 4 months ago

I have opened the beta bump PR here

@haircommander Thanks for pointing out this PR; I have added it in the original comment. Also, would it be possible to raise another PR in this kubernetes/enhancements repo to update the stage to beta as well in kep.yaml, as mentioned in the comment (here)?

dipesh-rawat commented 4 months ago

Hey again @marquiz @haircommander @pacoxu 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze next week, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. For this KEP, we would need to do the following:

If you anticipate missing code freeze, you can file an exception request in advance.

haircommander commented 4 months ago

thanks for the reminder @dipesh-rawat , I have opened https://github.com/kubernetes/enhancements/pull/4769

haircommander commented 4 months ago

I'm unable to edit the issue description and I think @marquiz is out, but https://github.com/kubernetes/kubernetes/pull/125828 is the only implementation PR needed

dipesh-rawat commented 4 months ago

I'm unable to edit the issue description and I think @marquiz is out

I see in the edit history that @pacoxu has previously edited the issue description. We could request him this time as well. I’ll also check if anyone from the Release Team has access to this.

Once the milestone update PR https://github.com/kubernetes/enhancements/pull/4769 is merged, this should be ready for code freeze.

neolit123 commented 4 months ago

edited the OP to have https://github.com/kubernetes/kubernetes/pull/125828 where the ? was.

sreeram-venkitesh commented 4 months ago

Looks like the implementation PR https://github.com/kubernetes/kubernetes/pull/125828 has been merged. @haircommander @neolit123 We don't have any other code PRs for this KEP right?

haircommander commented 4 months ago

nope! this is done :)

dipesh-rawat commented 4 months ago

Hi @haircommander Thanks for confirmation.

Everything seems to be in place for this KEP issue now that the following code implementation PR have been merged.

This enhancement is now marked as tracked for code freezefor the 1.31 Code Freeze!

dipesh-rawat commented 4 months ago

@haircommander It would be appreciated if following update to the KEP milestone would also be merged (ideally before the release):

haircommander commented 3 months ago

Since this went to beta in 1.31, I'm moving this to Not for release