search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.42k stars 1.47k forks source link

Kubelet support for Split Image Filesystem #4191

Open kannon92 opened 1 year ago

kannon92 commented 1 year ago

Enhancement Description

Nice to haves:

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

Princesso commented 3 months ago

Hello @kannon92 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

Hi @kannon92, v1.31 Doc Lead here, gentle reminder to reopen the Doc placeholder PR for this enhancement before June 27th, 2024 which is the deadline for having a doc PR up.

kannon92 commented 3 months ago

@kwilczynski a blog post for this feature would be useful! That link you posted was not for this feature. I had a vision for two part blog post: introduce how you have separate container runtime file system and a blog post featuring the split file system.

If we can get the e2e tests working, then I think we should write a blog post for this feature.

kwilczynski commented 3 months ago

@kwilczynski a blog post for this feature would be useful! That link you posted was not for this feature.

@kannon92, do you mean, you wanted to have a separate blog post about the concept (~the one I linked to would be that~this is more about how to use it, rather), and then another about how to use the new functionality?

kannon92 commented 3 months ago

so this feature doesn’t enable a separate container runtime file system. That has existed since early days of K8s. That post was to highlight how to configure kubelet/container runtime to have a separate file system.

This feature would need a post highlighting this feature (where read only layers are separate from writeable layer).

kwilczynski commented 3 months ago

[...]

This feature would need a post highlighting this feature (where read only layers are separate from writeable layer).

@kannon92, got it. I will look into a new blog post that highlights this new concept. I think, our users might get confused a little bit as to what the difference is between the two concepts, from the pragmatic point of view, so indeed a blog post might be useful.

kwilczynski commented 3 months ago

Hello everyone! I have opened a Pull Request to add missing documentation (to be completed later):

/cc @kannon92 @mrunalp @SergeyKanzhelev @johnbelamaric @rashansmith @Princesso

prianna commented 3 months ago

Hey again @kannon92 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please let me know if there are other PRs in k/k we should be tracking for this KEP, and please update your enhancement description with the requisite PRs.

If you anticipate missing code freeze, you can file an exception request in advance. As always, we are here to help if any questions come up. Thanks!

kwilczynski commented 3 months ago

@prianna, we will get the mentioned Pull Request merged in time. Thank you for the reminder.

kwilczynski commented 3 months ago

/retitle Kubelet support for Split Image Filesystem

prianna commented 3 months ago

Thanks @kwilczynski. With the final implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.31 Code Freeze! Thanks for updating your issue with the PRs and let me know if anything changes.

kwilczynski commented 3 months ago

@prianna, thank you for keeping an eye on us. Appreciated. :smile:

I will let you know if anything changes. No worries.

sreeram-venkitesh commented 2 months ago

Moving the KEP to At risk for code freeze for now because of https://github.com/kubernetes/kubernetes/pull/126313

x-ref: https://github.com/kubernetes/kubernetes/issues/126314#issuecomment-2246829684

sreeram-venkitesh commented 2 months ago

Removed from milestone as mentioned in https://github.com/kubernetes/kubernetes/issues/126314#issuecomment-2246849617.

/milestone clear

kwilczynski commented 2 months ago

@sreeram-venkitesh, we were able to land a fix quickly. Which is already merged and the problem with failing tests has been fixed. Would you be able to move us back into the milestone for 1.31? We don't want to miss it... if it can be helped.

sreeram-venkitesh commented 2 months ago

/milestone v1.31

Status updated to tracked for code freeze 🥳 with https://github.com/kubernetes/kubernetes/pull/126335 and https://github.com/kubernetes/kubernetes/pull/126205 merged.

@kwilczynski: https://github.com/kubernetes/kubernetes/pull/126429 is not part of the exception request for this KEP right?

kannon92 commented 2 months ago

#126429 is not part of the exception request.

kannon92 commented 2 months ago

Posted a query about potential support in containerd: https://github.com/containerd/containerd/issues/10517

haircommander commented 1 month ago

Since this went in beta in 1.32 and doesn't have adoptors yet, I think we will not make progress on this in 1.32 (outside of potential containerd support)

kannon92 commented 1 month ago

@haircommander one thing I don't understand (which is why I put in proposed for consideration) is that I have one bug fix for beta I would like reviews for 1.32.

If we want to only include phase changes than that is fine. But it doesn't really track the work that is done within a stage.

I have https://github.com/kubernetes/kubernetes/issues/126559 which has a PR open.

haircommander commented 1 month ago

yeah to simplify planning i figure we can use the board to track enhancements that the release team will follow (that require a change to the KEP, documentation, etc).

tjons commented 1 month ago

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in