search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Custom profile in kubectl debug #4292

Open ardaguclu opened 11 months ago

ardaguclu commented 11 months ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

ardaguclu commented 11 months ago

/sig cli

soltysh commented 8 months ago

/label lead-opted-in /milestone v1.30

soltysh commented 8 months ago

/stage alpha

soltysh commented 8 months ago

/assign @ardaguclu

tjons commented 8 months ago

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to complete the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ardaguclu commented 8 months ago

@tjons thanks for checking the KEP. But I have added graduation criteria as you can see in https://github.com/kubernetes/enhancements/pull/4293/files#diff-708a3d9c4718ca7f3da37b08c6cbee5ff7fc7df4f496783dd213b7abf0f2c216R98, do you mean adding somewhere else?.

tjons commented 8 months ago

@ardaguclu whoops, missed that in the diff! thanks for updating me. I've updated my commend accordingly.

tjons commented 8 months ago

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

natalisucks commented 7 months ago

Hi @ardaguclu,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

Vyom-Yadav commented 7 months ago

Hello @ardaguclu 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

Going through the changes this PR entails, we'll need a docs PR. Marking this as Need Docs. Thanks for this cool feature!

tjons commented 7 months ago

Hey again @ardaguclu 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

tjons commented 7 months ago

Hello @ardaguclu 👋, Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.30 Code Freeze!

Starttoaster commented 6 months ago

This feature makes the kubectl debug command actually useful to me, so thank you for it. My team has always been somewhat turned-off from building their applications in shell-less base images because it was really annoying and difficult to runtime debug those containers, so being able to mount data volumes and such in the debug container will be a huge security win for us, I think. Couple of suggestions but I can't overstate how I'm already happy with the current state of it:

Since both of those feature suggestions kind of clash in usage, it might make more sense to consider doing one (if not neither) of them. The raw json in the flag idea is mostly just how I imagined the flag worked before I tried it. The yaml idea might be more generally useful to other people.

This is actually my first time replying to a KEP issue here so let me know if there is anything else I can provide to the team here.

sreeram-venkitesh commented 4 months ago

Hi @ardaguclu 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

ardaguclu commented 4 months ago

@eddiezane could you please add the lead-opted-in label to track the work in 1.31?. Thanks.

eddiezane commented 4 months ago

/label lead-opted-in

soltysh commented 4 months ago

/milestone v1.31

soltysh commented 4 months ago

/stage beta

tjons commented 4 months ago

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

For this KEP, we would just need to complete the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

ardaguclu commented 4 months ago

@tjons thanks for the reminder. I assume that KEP is up to date with regards to template, could you please point the which field lacks comparing to the latest template? or the only issue is updating the fields as done in https://github.com/kubernetes/enhancements/pull/4689

tjons commented 4 months ago

Your KEP itself looks good - my note is just a reminder that it needs to be merged :)

ardaguclu commented 4 months ago

@Starttoaster under the light of your suggestions, in beta stage, yaml support is added.

Princesso commented 3 months ago

Hello @ardaguclu :wave:, 1.31 Docs Lead here. Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release. Thank you!

sreeram-venkitesh commented 3 months ago

Marking the KEP as tracked for enhancements freeze 🎉

ardaguclu commented 3 months ago

Hello @ardaguclu 👋, 1.31 Docs Lead here. Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release. Thank you!

@Princesso sorry for the late reply. This KEP doesn't require any modification in existing docs. Thank you for the reminder.

edithturn commented 3 months ago

Hello, @ardaguclu!

👋 from the v1.31 Communications Team!

We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

ardaguclu commented 3 months ago

@edithturn I opened this https://github.com/kubernetes/website/pull/46909 as a placeholder for the feature blog of this feature.

edithturn commented 3 months ago

@edithturn I opened this https://github.com/kubernetes/website/pull/46909 as a placeholder for the feature blog of this feature.

Hello @ardaguclu, thank you for your response, please let me know If you need any help!

tjons commented 3 months ago

Hey again @ardaguclu - 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024. .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

tjons commented 2 months ago

With all PRs to k/k merged, this enhancement is now tracked for code freeze!

tjons commented 2 weeks ago

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

ardaguclu commented 2 weeks ago

/sig cli /milestone v1.32 /stage stable /label lead-opted-in

ardaguclu commented 2 weeks ago

/milestone v1.32

dipesh-rawat commented 1 week ago

Hello @ardaguclu 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

It looks like https://github.com/kubernetes/enhancements/pull/4824 will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!