search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.46k stars 1.49k forks source link

Relaxed DNS search string validation #4427

Open sethev opened 10 months ago

sethev commented 10 months ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

sethev commented 10 months ago

/sig network

jpbetz commented 10 months ago

/milestone v1.30

jpbetz commented 10 months ago

@thockin This one needs /label lead-opted-in

AnaMMedina21 commented 9 months ago

Hello @sethev πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage <insert-stage-here> for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

sethev commented 9 months ago

@AnaMMedina21 working on the implementable field (https://github.com/kubernetes/enhancements/pull/4493)

Does the description update look ok?

AnaMMedina21 commented 9 months ago

@sethev Looks great! Will keep an eye out for https://github.com/kubernetes/enhancements/pull/4493

sethev commented 9 months ago

@AnaMMedina21 status set to implementable!

This enhancement is targeting for stage for v1.30 (correct me, if otherwise)

This is targeting alpha for v1.30

meganwolf0 commented 9 months ago

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze πŸš€

chanieljdan commented 9 months ago

Hi @sethev @thockin πŸ‘‹, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

a-mccarthy commented 9 months ago

Hi @thockin and @sethev,

πŸ‘‹ from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

chanieljdan commented 9 months ago

Hi @sethev @thockin πŸ‘‹, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @sethev @thockin πŸ‘‹, could you review the above before the placeholder deadline tonight? Thanks!

sethev commented 9 months ago

@chanieljdan opened a place holder here: https://github.com/kubernetes/website/pull/45299

AnaMMedina21 commented 9 months ago

Hey again @sethev πŸ‘‹ Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

sethev commented 9 months ago

@AnaMMedina21 i should have a PR submitted tomorrow, but it looks like i've missed the code freeze for 1.30 :(

drewhagen commented 8 months ago

πŸ‘‹ Hello @sethev

‼️ This KEP needs documentation with a review complete by Doc Freeze on March 26th 18:00 PT (coming up quick!) to get this into the release. After that date, an exception needs to be filed and may risk this feature not getting released with 1.30.

The start of a review was due a week ago, and I see that the documentation is still a draft. Both SIG-Docs and a technical reviewer from SIG network needs to review documentation by that March 26th date.

As a user of Kubernetes, I really appreciate your contribution with good documentation to help me understand how to utilize your new enhancement. Thanks!

salehsedghpour commented 8 months ago

This PR was labeled tracked for code freeze by mistake. As it doesn't have any PR, I'm removing this from milestone.

/milestone clear

thockin commented 6 months ago

@sethev - are you going to be working on this in 1.31 ?

thockin commented 6 months ago

@sethev the clock for 1.31 is ticking - AFAICT there is not an open PR for this (though there was an older one pre-KEP) - are you still pursuing this?

thockin commented 5 months ago

@sethev - are you still around? If not, then this KEP is likely to get closed, unless someone else picks it up.

@zengyuxing007 FYI

https://github.com/kubernetes/kubernetes/issues/125883

adrianmoisey commented 4 months ago

/assign

zengyuxing007 commented 3 months ago

/assign

@adrianmoisey thanks ，looking forward to your good news

thockin commented 3 months ago

@adrianmoisey is shooting for alpha in 1.32

shecodesmagic commented 2 months ago

Hello @sethev @adrianmoisey πŸ‘‹, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

thockin commented 2 months ago

@adrianmoisey

adrianmoisey commented 2 months ago

Hello @shecodesmagic,

Sorry, I'm new and this is the first KEP I've been involved with.

  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.

How do I do this? kep.yml has this set: https://github.com/kubernetes/enhancements/blob/c297b651fb9591829b13001fdb9fd11b7ee94c4f/keps/sig-network/4427-relaxed-dns-search-validation/kep.yaml#L7

  • [ ] KEP readme has up-to-date graduation criteria

Also unsure what this means. The KEP has the following: https://github.com/kubernetes/enhancements/tree/c297b651fb9591829b13001fdb9fd11b7ee94c4f/keps/sig-network/4427-relaxed-dns-search-validation#graduation-criteria

Please keep the issue description up-to-date with appropriate stages as well. Thank you!

I don't have edit access on this issue, so I can't change the issue description.

I'm unsure if this helps, but the KEP was updated in https://github.com/kubernetes/enhancements/pull/4755 Code was written and merged in https://github.com/kubernetes/kubernetes/pull/127167

Just to summarise: I unsure of what actions I need to take in order to push this forward.

shecodesmagic commented 2 months ago

@adrianmoisey Thanks for clarifying. I had only looked at the initial draft merged pr here: https://github.com/kubernetes/enhancements/pull/4428 Please ensure the Release Signoff Checklist is updated(mark the items as checked where applicable) as well: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/4427-relaxed-dns-search-validation/README.md#release-signoff-checklist

adrianmoisey commented 2 months ago

@adrianmoisey Thanks for clarifying. I had only looked at the initial draft merged pr here: #4428 Please ensure the Release Signoff Checklist is updated(mark the items as checked where applicable) as well: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/4427-relaxed-dns-search-validation/README.md#release-signoff-checklist

Thanks for the nudge! I've made https://github.com/kubernetes/enhancements/pull/4884 to address that. Let me know if anything else is required. It seems like I still need to do a website PR, which I'll look into.

adrianmoisey commented 2 months ago

I'm trying to figure out if any website changes are needed.

https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config makes no promises about the values. Additionally, the type doc also doesn't mention any promises around the format of the setting: https://github.com/kubernetes/kubernetes/blob/dc481fef903ac4d1b486fc0aa39795ad1f3d3213/pkg/apis/core/types.go#L3896-L3900

adrianmoisey commented 1 month ago

As per step 2 of https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval

/assign jpbetz

aojea commented 1 month ago

As per step 2 of https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval

you need PRR for beta, this is alpha in 1.32, it seems this feature is all set, code and KEP merged, you need to think if you want to update the docs referencing the change https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config

adrianmoisey commented 1 month ago

you need PRR for beta,

Oh, thanks for clarifying that!

this is alpha in 1.32, it seems this feature is all set, code and KEP merged

Thanks for the clarification!

you need to think if you want to update the docs referencing the change https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config

I made a comment higher up, since there are currently no documented promises of what characters the search string allows, it doesn't seen necessary to update the docs. I'm not married to that idea and can easily be convinced that updating the docs makes sense

rashansmith commented 1 month ago

Hello @adrianmoisey @jpbetz @thockin πŸ‘‹ from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

aaron-prindle commented 1 month ago

In the description of this issue can someone who has perms update the Code section to link to the implementation here IIUC: https://github.com/kubernetes/kubernetes/pull/127167. Was reading through the thread to understand the status and find the impl, might help someone in the future. Thanks!

AnshumanTripathi commented 1 month ago

Hello @adrianmoisey @jpbetz @thockin πŸ‘‹, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

AnshumanTripathi commented 1 month ago

Hi @adrianmoisey @jpbetz @thockin πŸ‘‹,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is Thursday Oct 24 at 18:00 PDT.

Thanks,

Anshuman

danwinship commented 1 month ago

@AnshumanTripathi from an earlier comment:

since there are currently no documented promises of what characters the search string allows, it doesn't seen necessary to update the docs.

rashansmith commented 1 month ago

Hello @adrianmoisey @jpbetz @thockin πŸ‘‹ from the v1.32 Communications Team!

Sending another reminder!

We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

tjons commented 1 month ago

Hey again @adrianmoisey πŸ‘‹ v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs have been merged:

Can you please add it to the issue description along with any other PRs planned?

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

adrianmoisey commented 1 month ago

Thanks @tjons Unfortunately I don't have edit access to the description of this issue, but I found someone who does, and it's since been updated.

tjons commented 1 month ago

With all the PRs merged, this enhancement is now tracked for code freeze!