Relaxed DNS search string validation

sethev commented 8 months ago

Enhancement Description

One-line enhancement description (can be used as a release note): Support relaxed validation of DNS search strings
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/4427-relaxed-dns-search-validation
Discussion Link: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/4427-relaxed-dns-search-validation
Primary contact (assignee):
Responsible SIGs: sig-network
Enhancement target (which target equals to which milestone):
- Alpha release target (x.y): 1.30
- Beta release target (x.y): 1.31
- Stable release target (x.y): 1.32
[x] Alpha
- [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4428
- [ ] Code (k/k) update PR(s):
- [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

sethev commented 8 months ago

/sig network

jpbetz commented 8 months ago

/milestone v1.30

jpbetz commented 8 months ago

@thockin This one needs /label lead-opted-in

AnaMMedina21 commented 7 months ago

Hello @sethev 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage <insert-stage-here> for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

[x] KEP readme using the latest template has been merged into the k/enhancements repo.
[] KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
[x] KEP readme has up-to-date graduation criteria
[x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

Please update kep.yaml, KEP status needs to be marked as implementable
Can you also update your issue description to link to the KEP? https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/4427-relaxed-dns-search-validation

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

sethev commented 7 months ago

@AnaMMedina21 working on the implementable field (https://github.com/kubernetes/enhancements/pull/4493)

Does the description update look ok?

AnaMMedina21 commented 7 months ago

@sethev Looks great! Will keep an eye out for https://github.com/kubernetes/enhancements/pull/4493

sethev commented 7 months ago

@AnaMMedina21 status set to implementable!

This enhancement is targeting for stage for v1.30 (correct me, if otherwise)

This is targeting alpha for v1.30

meganwolf0 commented 7 months ago

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

chanieljdan commented 7 months ago

Hi @sethev @thockin 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

a-mccarthy commented 7 months ago

Hi @thockin and @sethev,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

chanieljdan commented 7 months ago

Hi @sethev @thockin 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @sethev @thockin 👋, could you review the above before the placeholder deadline tonight? Thanks!

sethev commented 7 months ago

@chanieljdan opened a place holder here: https://github.com/kubernetes/website/pull/45299

AnaMMedina21 commented 7 months ago

Hey again @sethev 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

[x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
[x] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

sethev commented 7 months ago

@AnaMMedina21 i should have a PR submitted tomorrow, but it looks like i've missed the code freeze for 1.30 :(

drewhagen commented 6 months ago

👋 Hello @sethev

‼️ This KEP needs documentation with a review complete by Doc Freeze on March 26th 18:00 PT (coming up quick!) to get this into the release. After that date, an exception needs to be filed and may risk this feature not getting released with 1.30.

The start of a review was due a week ago, and I see that the documentation is still a draft. Both SIG-Docs and a technical reviewer from SIG network needs to review documentation by that March 26th date.

As a user of Kubernetes, I really appreciate your contribution with good documentation to help me understand how to utilize your new enhancement. Thanks!

salehsedghpour commented 6 months ago

This PR was labeled tracked for code freeze by mistake. As it doesn't have any PR, I'm removing this from milestone.

/milestone clear

thockin commented 4 months ago

@sethev - are you going to be working on this in 1.31 ?

thockin commented 4 months ago

@sethev the clock for 1.31 is ticking - AFAICT there is not an open PR for this (though there was an older one pre-KEP) - are you still pursuing this?

thockin commented 3 months ago

@sethev - are you still around? If not, then this KEP is likely to get closed, unless someone else picks it up.

@zengyuxing007 FYI

https://github.com/kubernetes/kubernetes/issues/125883

adrianmoisey commented 2 months ago

/assign

zengyuxing007 commented 1 month ago

/assign

@adrianmoisey thanks ，looking forward to your good news

thockin commented 1 month ago

@adrianmoisey is shooting for alpha in 1.32

shecodesmagic commented 5 days ago

Hello @sethev @adrianmoisey 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

[x] KEP readme using the latest template has been merged into the k/enhancements repo.
[x] KEP status is marked as implementable for latest-milestone: v1.32.
[x] KEP readme has up-to-date graduation criteria
[x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

[x] KEP status is marked as implementable for latest-milestone: v1.32.
[x] KEP readme has up-to-date graduation criteria (Is this indeed up to date since the PR was marked as "initial draft"?)

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

thockin commented 4 days ago

@adrianmoisey

adrianmoisey commented 3 days ago

Hello @shecodesmagic,

Sorry, I'm new and this is the first KEP I've been involved with.

[ ] KEP status is marked as implementable for latest-milestone: v1.32.

How do I do this? kep.yml has this set: https://github.com/kubernetes/enhancements/blob/c297b651fb9591829b13001fdb9fd11b7ee94c4f/keps/sig-network/4427-relaxed-dns-search-validation/kep.yaml#L7

[ ] KEP readme has up-to-date graduation criteria

Also unsure what this means. The KEP has the following: https://github.com/kubernetes/enhancements/tree/c297b651fb9591829b13001fdb9fd11b7ee94c4f/keps/sig-network/4427-relaxed-dns-search-validation#graduation-criteria

Please keep the issue description up-to-date with appropriate stages as well. Thank you!

I don't have edit access on this issue, so I can't change the issue description.

I'm unsure if this helps, but the KEP was updated in https://github.com/kubernetes/enhancements/pull/4755 Code was written and merged in https://github.com/kubernetes/kubernetes/pull/127167

Just to summarise: I unsure of what actions I need to take in order to push this forward.

shecodesmagic commented 3 days ago

@adrianmoisey Thanks for clarifying. I had only looked at the initial draft merged pr here: https://github.com/kubernetes/enhancements/pull/4428 Please ensure the Release Signoff Checklist is updated(mark the items as checked where applicable) as well: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/4427-relaxed-dns-search-validation/README.md#release-signoff-checklist

adrianmoisey commented 3 days ago

@adrianmoisey Thanks for clarifying. I had only looked at the initial draft merged pr here: #4428 Please ensure the Release Signoff Checklist is updated(mark the items as checked where applicable) as well: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/4427-relaxed-dns-search-validation/README.md#release-signoff-checklist

Thanks for the nudge! I've made https://github.com/kubernetes/enhancements/pull/4884 to address that. Let me know if anything else is required. It seems like I still need to do a website PR, which I'll look into.

adrianmoisey commented 2 days ago

I'm trying to figure out if any website changes are needed.

https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config makes no promises about the values. Additionally, the type doc also doesn't mention any promises around the format of the setting: https://github.com/kubernetes/kubernetes/blob/dc481fef903ac4d1b486fc0aa39795ad1f3d3213/pkg/apis/core/types.go#L3896-L3900

adrianmoisey commented 11 hours ago

As per step 2 of https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval

/assign jpbetz

kubernetes / enhancements

Relaxed DNS search string validation #4427

Enhancement Description