search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.4k stars 1.47k forks source link

Restarting sidecar containers during Pod termination #4438

Open matthyx opened 8 months ago

matthyx commented 8 months ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

matthyx commented 8 months ago

/sig node

SergeyKanzhelev commented 8 months ago

/stage alpha /milestone v1.30

mrunalp commented 8 months ago

/label lead-opted-in

AnaMMedina21 commented 7 months ago

Hello @matthyx 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Checksumz commented 7 months ago

Hi @matthyx ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

matthyx commented 7 months ago

Hi @matthyx ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

https://github.com/kubernetes/website/pull/45142

Vyom-Yadav commented 7 months ago

Hello @matthyx 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

A feature gate is being added, so we'll need docs, marking it as Need Docs. Thanks!

AnaMMedina21 commented 7 months ago

Hey again @matthyx 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP, I didn't see any in the description As always, we are here to help if any questions come up. Thanks!

matthyx commented 7 months ago

@AnaMMedina21 this is the main PR https://github.com/kubernetes/kubernetes/pull/121412 however I'm not sure it will be finished on time... I will keep you posted here! /cc @gjkim42

matthyx commented 7 months ago

@AnaMMedina21 we have missed code freeze, let's try again for 1.31

Vyom-Yadav commented 6 months ago

@AnaMMedina21 I updated the status to Removed From Milestone

pacoxu commented 6 months ago

/milestone clear

sreeram-venkitesh commented 4 months ago

Hi 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

SergeyKanzhelev commented 4 months ago

/label lead-opted-in /milestone v1.31

SergeyKanzhelev commented 4 months ago

/assign @matthyx

sreeram-venkitesh commented 4 months ago

Hello @matthyx 👋, v1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, everything is taken care of in https://github.com/kubernetes/enhancements/pull/4660, please make sure to get it merged before the enhancements freeze!

The status of this enhancement is marked as At risk for enhancements freeze. Once the above PR is merged, I can mark it as tracked. Please keep the issue description up-to-date with appropriate stages and the relevant PRs as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Let me know if you have any questions! Thank you!

sreeram-venkitesh commented 3 months ago

@matthyx Pinging once again as a slight reminder that we're reaching the enhancements freeze deadline this Friday, June 14th!

sreeram-venkitesh commented 3 months ago

With #4660 merged, we can mark this KEP as tracked for enhancements freeze! 🎉

matthyx commented 3 months ago

With #4660 merged, we can mark this KEP as tracked for enhancements freeze! 🎉

Thanks!

LaurentGoderre commented 3 months ago

@matthyx v1.31 Docs team here. I have two questions. I see that there was a docs PR but it is now closed with no changes, I am wondering what happened there.

Also, I am wondering if as part of this enhancement there could be a note of this behavior in https://github.com/kubernetes/website/blob/d9949e15fd037a193aa7608f00c190c974351734/content/en/docs/tutorials/services/pods-and-endpoint-termination-flow.md

matthyx commented 3 months ago

@matthyx v1.31 Docs team here. I have two questions. I see that there was a docs PR but it is now closed with no changes, I am wondering what happened there.

Also, I am wondering if as part of this enhancement there could be a note of this behavior in https://github.com/kubernetes/website/blob/d9949e15fd037a193aa7608f00c190c974351734/content/en/docs/tutorials/services/pods-and-endpoint-termination-flow.md

@LaurentGoderre I will reopen the docs PR to cover the new flag, and I think it's a good idea to mention that in the termination page 👍

rashansmith commented 3 months ago

Hi @matthyx,

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

rashansmith commented 3 months ago

Hey @matthyx, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

gjkim42 commented 3 months ago

@matthyx Could you fix this link?

matthyx commented 3 months ago

Hey @matthyx, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

https://github.com/kubernetes/website/pull/45142

sreeram-venkitesh commented 2 months ago

Hey again @matthyx @gjkim42 👋 v1.31 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

If you anticipate missing code freeze, you can file an exception request in advance.

Marking this KEP as At risk for code freeze for now until https://github.com/kubernetes/kubernetes/pull/125710 is approved. Please update this PR in the issue description and also please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

sreeram-venkitesh commented 2 months ago

Hi again @matthyx! We're a week away from the code freeze deadline and I wanted to ping you as a slight reminder for getting https://github.com/kubernetes/kubernetes/pull/125710 merged in time before the deadline. Please let me know if there are any other PRs that we should be tracking as well. Thanks!

LaurentGoderre commented 2 months ago

@matthyx could you also please add that PR link tot the issue description.

sreeram-venkitesh commented 2 months ago

Hello @matthyx @gjkim42 👋 v1.31 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.31 milestone.

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

kannon92 commented 1 month ago

Are you planning to work on the implementation in 1.32?

matthyx commented 1 month ago

Are you planning to work on the implementation in 1.32?

yes if we can have the review cycles of @smarterclayton :)

tjons commented 2 weeks ago

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

haircommander commented 2 weeks ago

/milestone v1.32 /label lead-opted-in

tjons commented 4 days ago

Hello @matthyx 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

matthyx commented 3 days ago

Hello @matthyx 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: v1.32.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday, October 3rd, 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo. The Risks and Mitigations, Drawbacks, and Alternatives sections are all missing - if you can fill those out this KEP will be then be able to be tracked.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

https://github.com/kubernetes/enhancements/pull/4890