search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.42k stars 1.47k forks source link

Move cgroup v1 support into maintenance mode #4569

Open harche opened 6 months ago

harche commented 6 months ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

harche commented 6 months ago

/sig node

harche commented 6 months ago

/assign

SergeyKanzhelev commented 6 months ago

I updated the name of a KEP (this issue title) as per our decision: https://github.com/kubernetes/enhancements/pull/4572#issuecomment-2059937137.

@harche can you please update it in kep.yaml as well?

SergeyKanzhelev commented 5 months ago

/label lead-opted-in /milestone v1.31

tjons commented 4 months ago

Hello @harche 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage stable for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

sreeram-venkitesh commented 4 months ago

/stage alpha

harche commented 4 months ago

@sreeram-venkitesh this feature is going straight for GA. There is no alpha or beta stage for this feature.

sreeram-venkitesh commented 4 months ago

@harche Thanks for clarifying! Would you consider this KEP as of type Deprecation? (See Type column in the enhancements tracking board) Does maintenance mode entail that the feature/KEP is planned to be deprecated? Please also update the issue description.

/stage stable

harche commented 4 months ago

Thanks for clarifying! Would you consider this KEP as of type Deprecation?

This KEP is not going to deprecate cgroup v1 support, hence we would not like to classify it as deprecation.

sreeram-venkitesh commented 4 months ago

Thanks for the quick update!

hacktivist123 commented 4 months ago

Hello @harche :wave:, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

harche commented 4 months ago

Hello @harche 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

https://github.com/kubernetes/website/pull/46801

rashansmith commented 4 months ago

Hi @harche,

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

rashansmith commented 3 months ago

Hey @harche, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

harche commented 3 months ago

Hey @harche, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@rashansmith thanks for reaching out. I have created a placeholder PR for the blog post - https://github.com/kubernetes/website/pull/47069

a-mccarthy commented 3 months ago

Thanks for clarifying! Would you consider this KEP as of type Deprecation?

This KEP is not going to deprecate cgroup v1 support, hence we would not like to classify it as deprecation.

@harche Hi there 👋 I'm Abbie the release comms lead. Just wanted to double check, should this KEP be included in our deprecations and removals blog for 1.31? I see that we aren't classifying this as a deprecation, but do you think its worth highlight to users in the same way? thanks!

tjons commented 3 months ago

Hi @harche - 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024 .

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

tjons commented 3 months ago

@harche could you add https://github.com/kubernetes/kubernetes/pull/126031 to the issue description?

harche commented 3 months ago

@harche could you add kubernetes/kubernetes#126031 to the issue description?

Done, thanks.

kannon92 commented 2 months ago

/stage alpha

sreeram-venkitesh commented 2 months ago

@harche @kannon92 Looks like all the PRs linked in https://github.com/kubernetes/enhancements/issues/4569#issuecomment-2213807932 are merged. Are we good for code freeze? Are there any other PRs that needs to be merged for this KEP? Thanks!

harche commented 2 months ago

/stage alpha

@kannon92 this is going straight for stable.

harche commented 2 months ago

@harche @kannon92 Looks like all the PRs linked in #4569 (comment) are merged. Are we good for code freeze? Are there any other PRs that needs to be merged for this KEP? Thanks!

All the PRs in kubernetes/kubernetes are merged, the documentation PRs (kubernetes/website) are still getting reviewed.

kannon92 commented 2 months ago

/stage alpha

@kannon92 this is going straight for stable.

Oh.

Can you update the description then?

I see that they are added to alpha so I figured it was a mistake to have it labeled as stable.

harche commented 2 months ago

https://github.com/kubernetes/enhancements/blob/382fe4bf47680f12013349c84dc0a4749ba93c71/keps/sig-node/4569-cgroup-v1-maintenance-mode/README.md#graduation-criteria

harche commented 2 months ago

/stage alpha

@kannon92 this is going straight for stable.

Oh.

Can you update the description then?

I see that they are added to alpha so I figured it was a mistake to have it labeled as stable.

Updated, thanks.

sreeram-venkitesh commented 2 months ago

All the PRs in kubernetes/kubernetes are merged, the documentation PRs (kubernetes/website) are still getting reviewed.

Thanks @harche! Marking this KEP as tracked for code freeze 🎉

kannon92 commented 2 months ago

/stage stable

tjons commented 1 month ago

Hello 👋 1.32 Enhancements Lead here,

I'm closing milestone 1.31 now, If you have more work on this enhancement to complete in v1.32, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.32. Thanks!

/milestone clear

tjons commented 1 month ago

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in