kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.41k stars 1.47k forks source link

Deprecate & remove Kubelet RunOnce mode #4580

Closed HirazawaUi closed 2 months ago

HirazawaUi commented 5 months ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

HirazawaUi commented 5 months ago

/sig node /assign

SergeyKanzhelev commented 4 months ago

/label lead-opted-in /milestone v1.31

SergeyKanzhelev commented 4 months ago

/stage alpha

ArkaSaha30 commented 4 months ago

Hello @HirazawaUi 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024..

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

sreeram-venkitesh commented 3 months ago

With https://github.com/kubernetes/enhancements/pull/4581 merged, we can mark this KEP as tracked for enhancements freeze 🎉

mbianchidev commented 3 months ago

Hello there @HirazawaUi

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating. Or like in this case a deprecation & removal.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

hacktivist123 commented 3 months ago

Hello @HirazawaUi 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

ArkaSaha30 commented 2 months ago

Hey again @HirazawaUi 👋, Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

Regarding this enhancement, it appears that there are currently no open pull requests in the k/k repository related to it.

For this KEP, we would need to do the following:

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

ArkaSaha30 commented 2 months ago

Hey again @HirazawaUi 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in about 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. A few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4580#issuecomment-2215236706 still need to be completed:

If you anticipate missing code freeze, you can file an exception request in advance.

HirazawaUi commented 2 months ago

@ArkaSaha30 I'm pushing it forward, but we still have some issues that are unresolved.

ArkaSaha30 commented 2 months ago

@ArkaSaha30 I'm pushing it forward, but we still have some issues that are unresolved.

Since we are very close to the Code Freeze(02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.) I would request you to file an exception request if you anticipate it can make it to 1.31.

sreeram-venkitesh commented 2 months ago

I'm guessing https://github.com/kubernetes/kubernetes/pull/125649 is the only PR that we need to track for this KEP. This PR has got an approval and is waiting for conflicts to be fixed.

@HirazawaUi: Please let us know if there is anything else.

sreeram-venkitesh commented 2 months ago

Hello @HirazawaUi 👋 v1.31 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.31 milestone. (Your PR https://github.com/kubernetes/kubernetes/pull/125649 has a merge conflict).

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

HirazawaUi commented 2 months ago

/close @sreeram-venkitesh Thank you for your support, but we will close this issue and will not move forward with it.

k8s-ci-robot commented 2 months ago

@HirazawaUi: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/4580#issuecomment-2247881658): >/close >@sreeram-venkitesh Thank you for your support, but we will close this issue and will not move forward with it. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sreeram-venkitesh commented 2 months ago

@HirazawaUi Do we not need this KEP for the deprecation? Should someone else take up this KEP for the next cycle?