kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.39k stars 1.45k forks source link

Add Resource Health Status to the Pod Status for Device Plugin and DRA #4680

Open SergeyKanzhelev opened 3 months ago

SergeyKanzhelev commented 3 months ago

Enhancement Description

/sig node

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

SergeyKanzhelev commented 3 months ago

Discussed with @mrunalp and we fine to add this to milestone:

/milestone v1.31 /label lead-opted-in /stage alpha

ArkaSaha30 commented 3 months ago

Hello, @SergeyKanzhelev πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024..

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

jpbetz commented 2 months ago

PRR reviewer here. Is there a KEP to review? Only a few days left till enhancements freeze..

SergeyKanzhelev commented 2 months ago

PRR reviewer here. Is there a KEP to review? Only a few days left till enhancements freeze..

Yes, we have polished some imlpementation details, but from PRR perspective it is very straightforward

richabanker commented 2 months ago

Looks like this is the KEP PR: https://github.com/kubernetes/enhancements/pull/4681

SergeyKanzhelev commented 2 months ago

@ArkaSaha30 this KEP can be marked as done for all the checkboxes you listed. Thank you!

dipesh-rawat commented 2 months ago

Hello @SergeyKanzhelev πŸ‘‹, 1.31 Enhancements team here,

Now that PR https://github.com/kubernetes/enhancements/pull/4681 has been merged, all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. πŸš€

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

rashansmith commented 2 months ago

Hi @SergeyKanzhelev,

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Princesso commented 2 months ago

Hi @SergeyKanzhelev, gentle reminder to raise a draft doc PR against dev-1.31 for this enhancement, before Thursday, June 27, 2024, 18:00 PDT.

rashansmith commented 2 months ago

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

SergeyKanzhelev commented 2 months ago

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! https://github.com/kubernetes/website/pull/47029

rashansmith commented 2 months ago

Hello @SergeyKanzhelev,

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! kubernetes/website#47029

Hey @SergeyKanzhelev, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Done, thanks for reminder! kubernetes/website#47029

Hey @SergeyKanzhelev, you currently have a PR for a docs change. To submit a blog post placeholder, create a PR on The website blogpost directory. Here is an example PR. Let me know if you have any questions!

ArkaSaha30 commented 2 months ago

Hey again @SergeyKanzhelev πŸ‘‹, Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

Regarding this enhancement, it appears that there are currently no open pull requests in the k/k repository related to it.

For this KEP, we would need to do the following:

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

ArkaSaha30 commented 1 month ago

Hey again @SergeyKanzhelev πŸ‘‹, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in about 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. A few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4680#issuecomment-2215256757 still need to be completed. The following PR as per the description still needs to be merged:

If you anticipate missing code freeze, you can file an exception request in advance.

SergeyKanzhelev commented 1 month ago

Note for self to add to the beta graduation requirements: https://github.com/kubernetes/kubernetes/pull/126243#discussion_r1688403851

Potential code change to improve stress behavior: https://github.com/kubernetes/kubernetes/pull/126243/files#r1688457694

sreeram-venkitesh commented 1 month ago

@SergeyKanzhelev KEP has been tracked for code freeze after https://github.com/kubernetes/kubernetes/pull/126243 is merged πŸŽ‰

drewhagen commented 1 month ago

Hello @SergeyKanzhelev, Awesome job on passing code freeze.

I'm immediately switching to ⚠️Risk for Doc Freeze because it is very overdue to have documentation ready to review. (the deadline was last week, Tuesday, July 16th, 2024 18:00 PST and the diff on the website PR only has "TODO" in it) SIG Release Docs has reached out but we haven't heard a response. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ASAP.

❗️This is important because the next deadline is the Doc Freeze on Tuesday 30th July 2024, after which will require an approved exception for this feature to ship with 1.31 if docs aren't merged. We appreciate your prompt attention to getting these docs ready for review, because with that review, SIG Docs will need to review and approve per project standards, along with a technical review from your SIG. Any suggested changes must be addressed, reviewed again, approved, and merged. SIG Release is available to help facilitate these activities but there's limited time left!

Thanks for your cooperation. πŸš€