search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.45k stars 1.49k forks source link

feat: update kep 3288 #4879

Closed knight42 closed 1 month ago

knight42 commented 1 month ago

Note down why we decide not to support the combination of Stream and TailLines.

Per https://github.com/kubernetes/kubernetes/pull/127360#discussion_r1765526177

knight42 commented 1 month ago

/cc @SergeyKanzhelev @kannon92

SergeyKanzhelev commented 1 month ago

lgtm. I think KEP brings a lot of value even with this limitation. Implementation-wise for the long term if we decide to support this, we will need to think whether we can split files when they are written.

knight42 commented 1 month ago

@SergeyKanzhelev I have updated the kep as you suggested, PTAL.

pacoxu commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knight42, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[keps/sig-node/OWNERS](https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/OWNERS)~~ [mrunalp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment