search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.46k stars 1.49k forks source link

KEP-1847: Promote statefulset autodelete feature to stable #4901

Closed mattcary closed 1 month ago

mattcary commented 1 month ago

/assign @johnbelamaric /cc @msau42

soltysh commented 1 month ago

/hold I believe there were some concerns raised in https://github.com/kubernetes/enhancements/issues/1847#issuecomment-2310117535

soltysh commented 1 month ago

/assign

johnbelamaric commented 1 month ago

/approve for PRR /lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, mattcary, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[keps/prod-readiness/OWNERS](https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/OWNERS)~~ [johnbelamaric,soltysh] - ~~[keps/sig-apps/OWNERS](https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/OWNERS)~~ [johnbelamaric,soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atiratree commented 1 month ago

/hold cancel I believe this is good to merge. cc @soltysh