KEP-3695: Update podResourceV1 API

kubernetes / enhancements

Enhancements tracking repo for Kubernetes

Apache License 2.0

3.46k stars 1.49k forks source link

KEP-3695: Update podResourceV1 API #4913

Closed ArangoGutierrez closed 1 month ago

ArangoGutierrez commented 1 month ago

- One-line PR description: Update KEP 3695 to reflect current implementation

Issue link: KEP-3695

Other comments: as per the discussion on https://github.com/kubernetes/enhancements/issues/3695 I have removed all references to Networking to focus solely on the Node elements for this KEP.

ArangoGutierrez commented 1 month ago

/cc @klueska @SergeyKanzhelev

ArangoGutierrez commented 1 month ago

/cc @aojea

aojea commented 1 month ago

/lgtm

perfect, thank you very much, appreciate the prompt response

klueska commented 1 month ago

/approve

@mrunalp for final approval

ArangoGutierrez commented 1 month ago

/assign @derekwaynecarr

kannon92 commented 1 month ago

/assign @mrunalp

/lgtm

kannon92 commented 1 month ago

Just to clarify: this is just cleanup and not a implementation for this feature in 1.32?

Or do we want some development time/reviewers for this feature for 1.32?

klueska commented 1 month ago

No updates expected for this release in terms of code -- this was just a "cleanup" effort to bring the KEP in line with the current code and remove all references in the text saying that these extensions are intended for networking plugins.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, klueska, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[keps/sig-node/OWNERS](https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/OWNERS)~~ [mrunalp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment