KEP-753: SidecarContainers update oom score adj logic

bouaouda-achraf commented 3 weeks ago

One-line PR description: update OOM score calculation.
Issue link: https://github.com/kubernetes/enhancements/issues/753
Other comments : The OOM adjustment for sidecar container will match or fall below the OOM score adjustment of regular containers in the Pod.

bouaouda-achraf commented 3 weeks ago

linked with https://github.com/kubernetes/kubernetes/pull/128029 adding @SergeyKanzhelev in the loop.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bouaouda-achraf, SergeyKanzhelev Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[keps/sig-node/OWNERS](https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

SergeyKanzhelev commented 3 weeks ago

thank you for correcting. "The lower the better" values are always hard to reason correctly about

kannon92 commented 2 weeks ago

/assign @mrunalp @dchen1107

kubernetes / enhancements

KEP-753: SidecarContainers update oom score adj logic #4932